From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1A0D7242D65; Fri, 26 Sep 2025 16:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758903585; cv=none; b=QoQ/0BJaCWVChiFRuL54lPX6Buic/iHQkpxsaDjKle8N8Hc6m13dn5bpIZxZncgVESFtoaHbnxwe3ePLsT0BldMF/bvHh3zA9EeCPa/mFQ1njdi0be1F6RPn2twF2Bw9VzwBs7hYVVRL8nDwA32+EvdYcDB/pZR718iC9EFeA7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758903585; c=relaxed/simple; bh=g3N28JsRJOyCJChjvaPlbQw8NwaDKl6p9+ZI6M+/NMo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kiIhf5aZoTg5BuYedXWI+poUi+M22QQjZW/YDh2howvWIEhk3tBCnzh/HnnOxStWyWQejHl0vGQerFTHChUGfITJak68MjCuHIg1bF7lz+bpi80LADg7Qsd54t9MNEt5AMLztRUcoJSRS7nihRfCAZk86Evnb3WiTbCc8anVcfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 598C8168F; Fri, 26 Sep 2025 09:19:35 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F1D13F5A1; Fri, 26 Sep 2025 09:19:43 -0700 (PDT) Date: Fri, 26 Sep 2025 17:19:41 +0100 From: Leo Yan To: Ian Rogers Cc: Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Adrian Hunter , Quentin Monnet , Andrii Nakryiko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, bpf@vger.kernel.org Subject: Re: [PATCH 4/8] perf test coresight: Dismiss clang warning for memcpy thread Message-ID: <20250926161941.GG7985@e132581.arm.com> References: <20250925-perf_build_android_ndk-v1-0-8b35aadde3dc@arm.com> <20250925-perf_build_android_ndk-v1-4-8b35aadde3dc@arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Sep 25, 2025 at 12:38:36PM -0700, Ian Rogers wrote: > On Thu, Sep 25, 2025 at 3:26 AM Leo Yan wrote: > > > > clang-18.1.3 on Ubuntu 24.04.2 reports warning: > > > > memcpy_thread.c:30:1: warning: non-void function does not return a value in all control paths [-Wreturn-type] > > 30 | } > > | ^ > > > > Dismiss the warning with returning NULL from the thread function. > > > > Signed-off-by: Leo Yan > > lgtm, should this be moved into being a perf test workload as in > tools/perf/tests/workloads/ ? Now we have four programs under shell folder: $ cd linux/tools/perf/tests/shell $ find ./ -name *.c -o -name *.S ./coresight/unroll_loop_thread/unroll_loop_thread.c ./coresight/asm_pure_loop/asm_pure_loop.S ./coresight/thread_loop/thread_loop.c ./coresight/memcpy_thread/memcpy_thread.c If really do this, can move all programs into folders? tools/perf/tests/workloads/ - Common programs tools/perf/tests/workloads/arm64 - Arch specific programs Anyway, this should be a separate series to avoid complexity for enabling Clang build. Thanks, Leo