From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AA5D24BD03 for ; Tue, 30 Sep 2025 02:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200307; cv=none; b=C0JSEaCTf2rL/HF2y2A9U8+LSWbCQpYSbjY7AOjrFchlodv/V+iPtdO9R230HKHZP3SGbUk2kwPR8y/i6wICFV256UPxbevupfoLSY1NEpqKCEH62EJMqfakYq/rCq/hH79hH5wEIYr/5C18tNts1G8i1I/X5oynwlisdu/qf0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759200307; c=relaxed/simple; bh=0RaB9b3mDxARpzNAU+b9+OM/53UguV9OX02ut00avNs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y1G1itAWnoN0JywDgqEbqvb9XldWNlOaH+s18qCIH13ZzenAkVzcqVx9tSHKEjCH/iRrXu0dhuixKqIzMEbJiTyWVZ4wYVwcBtL5A6+5suA6QXxLlTUgW2zoaE6RSOufOUJM9EM0CQ3Upgw2BWyINwXFY1a+b9Bxz33jxd93xXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MmTgSTCi; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MmTgSTCi" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7841da939deso1841379b3a.2 for ; Mon, 29 Sep 2025 19:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759200305; x=1759805105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8p2Xfne7CGpLjN/MkaU3Ee28S3aCNgQ2oxnJpFebIbs=; b=MmTgSTCivQdUN6WGxhnHkpN5oRIKQd+LSfqs/sOS1wy2A8Aebb4kOPRHOFYP3Pye7z okcZ63/Z8oiXVqnARwwKT96xgQmpBZbY+wkkiB4SSSIYm1ClzYVE+/8XgMwVfFzunb+o XvcryWYV3OnknQgXuLeGqq/shiIkNcaQ0pXvEwa6uHBUtTc6CO7nO5P9ET3F1STh5Kjc Wv0H71Sbx8+0eaXFVfwdROUoeWJOWYekKay/Rifb38+oU2cqbXnZQc33Yqnqs21fy6rv 6JMUsBzxNF1hZRisA1VjjCVCTayeXC8zgP0SvJCR7PSv0VSdcEkaQkq7wsxKea2CKhui HyIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759200305; x=1759805105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8p2Xfne7CGpLjN/MkaU3Ee28S3aCNgQ2oxnJpFebIbs=; b=JhJ+7jYthnXq5Nn/WI10NPkCctHuZFgd4ETABK4aGhnVdV+gdwaEY5WAQ9R8dwYagz SFCpOiFahIVNU4ODMqiqsDRkrSm32bAoV6U9qIIUmj5lKxWqAo2pL8uzFrv0CxbLAjfZ DeXJLYUEFxiL7MAczlawVNEkkcHB1zi38vwK3nhlenwfm0OcajNuE2f9VaEDDkESZVw0 SKoks/hpPGvy6M8WWh9v6pKuY2B3CjNPnPad3UNaAHIC4BJpj2l+KJKRmEiqnAPhIbXe cnFrA4B6p7WLofL86sglh7MvrUtzty2k48cP7+u0Riu/OZGIci5FQGsmTcjbc29nFbFo tjUA== X-Forwarded-Encrypted: i=1; AJvYcCUzKT+Ld7N1j2FVNv5kgEtg5JHc8M3suM88BN+LMeDJbl5SDi5Wi/BiDj3RSlsdSjle3XwnnIMrYSDH0Kedox3d@vger.kernel.org X-Gm-Message-State: AOJu0Yys8YUueHyHF23KoVZtDG19XTZg/ezD6Z/lc/LIU8RgKdiBFJ9R F8jZTtygKs5UhPcIAVLu1b797kKE1hs/cxkdSgu8BTx8+G9wuQOwOZlp X-Gm-Gg: ASbGnctc6DXoj5e0LA1maUylMEqWRODQHJlg0+s47WzKj2+3yUpKHQzG2m8JwPDB+Pk t/EFp0Db4lw2hzRuOd08vqpLBzLZGEILH8VsmltSns0tEAtXkLndRBTjgMNq3Xn1NfTHGzw3SVr 0j7CwB8ZXzpX+qkdGk00OGFGPZQxx2ANKacWwtb940oY4Pgjzaaxn5jT1rCkP2WqX5f5WoK0j7O teUZy6XrHtUukEOxD+DNtITD5/0wNi0pz7ZzGTRQkMgG2IWjjmgIcjbvj0nSrhuifiWfDazy5c0 oTQGj/x5/DOk8zaJlwdcbS1yMlZMMto/SNlvXaGCO+6+qvjTV00H0AiBGs3KreI1JizjjbYjSg/ 1f8/08SGp4xMf4vAr+wnmjWnYaFWrwhSZCS4uZBF2QD6JDkN2RqanCxf6Yw8hDssWSA== X-Google-Smtp-Source: AGHT+IGPdLJDAcFgGXBMapnRTLkbwOuAH98GZaW3SdGH9OxArUIFVK7BxMIb+p319lKI1/5kl2O6lQ== X-Received: by 2002:a05:6a00:1404:b0:782:d4b6:f5e5 with SMTP id d2e1a72fcca58-782d4b6f88amr8934209b3a.13.1759200305238; Mon, 29 Sep 2025 19:45:05 -0700 (PDT) Received: from localhost ([45.142.167.196]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7822f628080sm6431314b3a.89.2025.09.29.19.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 19:45:04 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v6 09/23] mm/ksw: ignore false positives from exit trampolines Date: Tue, 30 Sep 2025 10:43:30 +0800 Message-ID: <20250930024402.1043776-10-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250930024402.1043776-1-wangjinchao600@gmail.com> References: <20250930024402.1043776-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Because trampolines run after the watched function returns but before the exit_handler is called, and in the original stack frame, so the trampoline code may overwrite the watched stack address. These false positives should be ignored. is_ftrace_trampoline() does not cover all trampolines, so add a local check to handle the remaining cases. Signed-off-by: Jinchao Wang --- mm/kstackwatch/watch.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index 887cc13292dc..722ffd9fda7c 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -2,6 +2,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include +#include #include #include #include @@ -18,10 +19,46 @@ bool panic_on_catch; module_param(panic_on_catch, bool, 0644); MODULE_PARM_DESC(panic_on_catch, "panic immediately on corruption catch"); +#define TRAMPOLINE_NAME "return_to_handler" +#define TRAMPOLINE_DEPTH 16 + +/* Resolved once, then reused */ +static unsigned long tramp_start, tramp_end; + +static void ksw_watch_resolve_trampoline(void) +{ + unsigned long sz, off; + + if (likely(tramp_start && tramp_end)) + return; + + tramp_start = kallsyms_lookup_name(TRAMPOLINE_NAME); + if (tramp_start && kallsyms_lookup_size_offset(tramp_start, &sz, &off)) + tramp_end = tramp_start + sz; +} + +static bool ksw_watch_in_trampoline(unsigned long ip) +{ + if (tramp_start && tramp_end && ip >= tramp_start && ip < tramp_end) + return true; + return false; +} static void ksw_watch_handler(struct perf_event *bp, struct perf_sample_data *data, struct pt_regs *regs) { + unsigned long entries[TRAMPOLINE_DEPTH]; + int i, nr = 0; + + nr = stack_trace_save_regs(regs, entries, TRAMPOLINE_DEPTH, 0); + for (i = 0; i < nr; i++) { + //ignore trampoline + if (is_ftrace_trampoline(entries[i])) + return; + if (ksw_watch_in_trampoline(entries[i])) + return; + } + pr_err("========== KStackWatch: Caught stack corruption =======\n"); pr_err("config %s\n", ksw_get_config()->user_input); dump_stack(); @@ -168,6 +205,7 @@ int ksw_watch_init(void) { int ret; + ksw_watch_resolve_trampoline(); ret = ksw_watch_alloc(); if (ret <= 0) return -EBUSY; -- 2.43.0