From: Collin Funk <collin.funk1@gmail.com>
To: irogers@google.com
Cc: acme@kernel.org, adrian.hunter@intel.com,
alexander.shishkin@linux.intel.com, collin.funk1@gmail.com,
james.clark@linaro.org, jolsa@kernel.org,
kan.liang@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, mark.rutland@arm.com,
mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org,
ravi.bangoria@amd.com
Subject: Re: [PATCH v1 1/2] perf test: Add an 'import perf' test shell script
Date: Tue, 30 Sep 2025 16:10:57 -0700 [thread overview]
Message-ID: <20250930231100.197258-1-collin.funk1@gmail.com> (raw)
In-Reply-To: <20250903184248.695267-1-irogers@google.com>
Ian Rogers <irogers@google.com> wrote:
> The 'import perf' test needs to set up a path to the python module as
> well as to know the python command to invoke. These are hard coded at
> build time to be build a directory and the python used in the build,
> which is less than desirable. Avoid the hard coded values by reusing
> the existing shell script python setup and determine a potential built
> python module via the path of the perf executable.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/python-use.sh | 36 ++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100755 tools/perf/tests/shell/python-use.sh
Aside from avoiding hard coded build directories, this also looks much cleaner to me.
Reviewed-by Collin Funk <collin.funk1@gmail.com>
Collin
prev parent reply other threads:[~2025-09-30 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 18:42 [PATCH v1 1/2] perf test: Add an 'import perf' test shell script Ian Rogers
2025-09-03 18:42 ` [PATCH v1 2/2] perf test: Remove C python_use test Ian Rogers
2025-09-30 20:02 ` [PATCH v1 1/2] perf test: Add an 'import perf' test shell script Ian Rogers
2025-10-01 13:42 ` Arnaldo Carvalho de Melo
2025-10-01 13:44 ` Arnaldo Carvalho de Melo
2025-10-01 14:55 ` Ian Rogers
2025-10-01 18:23 ` Arnaldo Carvalho de Melo
2025-10-01 18:29 ` Ian Rogers
2025-09-30 23:10 ` Collin Funk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930231100.197258-1-collin.funk1@gmail.com \
--to=collin.funk1@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).