From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Charlie Jenkins <charlie@rivosinc.com>,
Eric Biggers <ebiggers@kernel.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
James Clark <james.clark@linaro.org>,
Collin Funk <collin.funk1@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Li Huafei <lihuafei1@huawei.com>,
Athira Rajeev <atrajeev@linux.ibm.com>,
Stephen Brennan <stephen.s.brennan@oracle.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Haibo Xu <haibo1.xu@intel.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
bpf@vger.kernel.org, llvm@lists.linux.dev,
Song Liu <song@kernel.org>
Subject: [PATCH v7 00/11] Capstone/llvm improvements + dlopen support
Date: Sun, 5 Oct 2025 14:22:01 -0700 [thread overview]
Message-ID: <20251005212212.2892175-1-irogers@google.com> (raw)
Linking against libcapstone and libLLVM can be a significant increase
in dependencies and file size if building statically. For something
like `perf record` the disassembler and addr2line functionality won't
be used. Support dynamically loading these libraries using dlopen and
then calling the appropriate functions found using dlsym.
The patch series:
1) feature check libLLVM support and avoid always reinitializing the
disassembler.
2) adds BPF JIT disassembly support to in memory disassemblers (LLVM
and capstone) by just directing them at the BPF info linear JIT
instructions (note this doesn't support source lines);
3) adds fallback to srcline's addr2line so that llvm_addr2line is
tried first, then the deprecated libbfd and then the forked command
tried next, moving the code for forking out of the main srcline.c
file in the process.
4) adds perf_ variants of the capstone/llvm functions that will either
directly call the function or use dlsym to discover it;
The addr2line LLVM functionality is written in C++. To avoid linking
against libLLVM for this, a new LIBLLVM_DYNAMIC option is added where
the C++ code with the libLLVM dependency will be built into a
libperf-llvm.so and that dlsym-ed and called against. Ideally LLVM
would extend their C API to avoid this.
v7: Refactor now the first 5 patches, that largely moved code around,
have landed. Move the dlopen code to the end of the series so that
the first 8 patches can be picked improving capstone/LLVM support
without adding the dlopen code. Rename the cover letter and
disassembler cleanup patches.
v6: Refactor the libbfd along with capstone and LLVM, previous patch
series had tried to avoid this by just removing the deprecated
BUILD_NONDISTRO code. Remove the libtracefs removal into its own
patch.
v5: Rebase and comment typo fix.
v4: Rebase and addition of a patch removing an unused struct variable.
v3: Add srcline addr2line fallback trying LLVM first then forking a
process. This came up in conversation with Steinar Gunderson
<sesse@google.com>.
Tweak the cover letter message to try to address Andi Kleen's
<ak@linux.intel.com> feedback that the series doesn't really
achieve anything.
v2: Add mangling of the function names in libperf-llvm.so to avoid
potential infinite recursion. Add BPF JIT disassembly support to
LLVM and capstone. Add/rebase the BUILD_NONDISTRO cleanup onto the
series from:
https://lore.kernel.org/lkml/20250111202851.1075338-1-irogers@google.com/
Some other minor additional clean up.
Ian Rogers (11):
perf check: Add libLLVM feature
perf llvm: Reduce LLVM initialization
perf dso: Move read_symbol from llvm/capstone to dso
perf dso: Support BPF programs in dso__read_symbol
perf dso: Clean up read_symbol error handling
perf disasm: Make ins__scnprintf and ins__is_nop static
perf srcline: Fallback between addr2line implementations
perf disasm: Remove unused evsel from annotate_args
perf capstone: Support for dlopen-ing libcapstone.so
perf llvm: Support for dlopen-ing libLLVM.so
perf llvm: Mangle libperf-llvm.so function names
tools/perf/Documentation/perf-check.txt | 1 +
tools/perf/Makefile.config | 13 +
tools/perf/Makefile.perf | 24 +-
tools/perf/builtin-check.c | 1 +
tools/perf/tests/make | 2 +
tools/perf/util/Build | 3 +-
tools/perf/util/addr2line.c | 439 +++++++++++++++++++++
tools/perf/util/addr2line.h | 20 +
tools/perf/util/annotate.c | 1 -
tools/perf/util/capstone.c | 352 ++++++++++++-----
tools/perf/util/config.c | 2 +-
tools/perf/util/disasm.c | 18 +-
tools/perf/util/disasm.h | 4 -
tools/perf/util/dso.c | 112 ++++++
tools/perf/util/dso.h | 4 +
tools/perf/util/libbfd.c | 4 +-
tools/perf/util/libbfd.h | 6 +-
tools/perf/util/llvm-c-helpers.cpp | 120 +++++-
tools/perf/util/llvm-c-helpers.h | 24 +-
tools/perf/util/llvm.c | 374 +++++++++++++-----
tools/perf/util/llvm.h | 3 -
tools/perf/util/srcline.c | 495 ++----------------------
tools/perf/util/srcline.h | 1 -
23 files changed, 1314 insertions(+), 709 deletions(-)
create mode 100644 tools/perf/util/addr2line.c
create mode 100644 tools/perf/util/addr2line.h
--
2.51.0.618.g983fd99d29-goog
next reply other threads:[~2025-10-05 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 21:22 Ian Rogers [this message]
2025-10-05 21:22 ` [PATCH v7 01/11] perf check: Add libLLVM feature Ian Rogers
2025-10-05 21:22 ` [PATCH v7 02/11] perf llvm: Reduce LLVM initialization Ian Rogers
2025-10-05 21:22 ` [PATCH v7 03/11] perf dso: Move read_symbol from llvm/capstone to dso Ian Rogers
2025-10-05 21:22 ` [PATCH v7 04/11] perf dso: Support BPF programs in dso__read_symbol Ian Rogers
2025-10-05 21:22 ` [PATCH v7 05/11] perf dso: Clean up read_symbol error handling Ian Rogers
2025-10-05 21:22 ` [PATCH v7 06/11] perf disasm: Make ins__scnprintf and ins__is_nop static Ian Rogers
2025-10-05 21:22 ` [PATCH v7 07/11] perf srcline: Fallback between addr2line implementations Ian Rogers
2025-10-05 21:22 ` [PATCH v7 08/11] perf disasm: Remove unused evsel from annotate_args Ian Rogers
2025-10-05 21:22 ` [PATCH v7 09/11] perf capstone: Support for dlopen-ing libcapstone.so Ian Rogers
2025-10-05 21:22 ` [PATCH v7 10/11] perf llvm: Support for dlopen-ing libLLVM.so Ian Rogers
2025-10-05 21:22 ` [PATCH v7 11/11] perf llvm: Mangle libperf-llvm.so function names Ian Rogers
2025-10-06 18:39 ` [PATCH v7 00/11] Capstone/llvm improvements + dlopen support Arnaldo Carvalho de Melo
2025-10-06 18:41 ` Arnaldo Carvalho de Melo
2025-10-06 18:44 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251005212212.2892175-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexghiti@rivosinc.com \
--cc=atrajeev@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=charlie@rivosinc.com \
--cc=collin.funk1@gmail.com \
--cc=dvyukov@google.com \
--cc=ebiggers@kernel.org \
--cc=haibo1.xu@intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=llvm@lists.linux.dev \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).