From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332022E1EE7 for ; Thu, 9 Oct 2025 10:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007490; cv=none; b=oGOgkx6DXz1L9e9r2uBKc9htV5LQfvU7mReu1YNM8A0D9IIIxX6XLDem2xHT22cT0peFOGTMcM14n5tK5MDrlqMLi+f3zK/9hohfST4+ygNPAEvbUvYG22xB/CNqoHFHoLqRfikOvocBc4pPT3v2lK5S8AcIkhRTjvQ7o6gEl4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760007490; c=relaxed/simple; bh=jb47W2mefivkhEZpeuyQPhjnJkRHRCJ2NscvV1apXQg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nu4UvRhz1f3vgtc6kBSdhCqH8SltuH5E62LkmDU1vtvDTHylofvi8t/2UckjpjUF/+aZkqhUPAKSv7uc4OFaAnrQnL9iUjM+afud3Jqqfbozz1BqCTP17Zoyiiq+zpsMO7B2CoIXFvvFrfOlJbhTINX1uo4Z7uI/IRPboBOc1jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BcxnklMX; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BcxnklMX" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b6093f8f71dso470114a12.3 for ; Thu, 09 Oct 2025 03:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760007487; x=1760612287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kFRia/GHfKKxxNt0IUc2kN+EVm0fmr2Lz8hq8oGCXGU=; b=BcxnklMXY0S1nikXs8Pkm91y+PNuSzZyHikRCaKEHuMr5ix4y8kphhrxunKpwrJYdl dAdi7tRNY5bsvaY7esYI2tRCz8S1W+jDni7obTYASTK8T1ZPWsLP1qXR6pNidAKw0eI2 wV5lwdWHNqCYgpt3bS00s+xHePICE8i4Aa9TTuX67P7YGvP8gmgKPmYhBX5+I8Hzk01t iS41WM6ySQC4q8VQk8FyNNr980zejO5HpzHBc1RjNSColYAozKZSnjFQ7XGE+LLe4Ody rcqnn3nIwNKyGSiiWOvAAUy5OWg/5TtRSjh513Zx82fsDN41lq2oH2F0HNX13KxxHACf G0Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760007487; x=1760612287; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFRia/GHfKKxxNt0IUc2kN+EVm0fmr2Lz8hq8oGCXGU=; b=MAduIP8gqsB97lkQU53JIDDgezu5xYnvHFYWD3m2cyKwf7drAZs4NTlXCvFzC7JdXe yLdWRc/09J1bkrKxMto7jJsnaBVJ/1xU9N1kNyH5lbhflx6iX70MqeFNSq/wTWmwLik5 CvgnqjPXeh9ygh9qC3ddNRFYTNJkz2+DeDlOwwVjlaFRHhm6Mu0Ii9Ez7SGYrP9A/MFm nonM/fJrVchhldNNKc0qCvgX+pCxhzl9+qofYB2g9ZLsX8u4nxRn6c1UwUMexViuus7g 1PCZ/quswtna06cPz3jPlQuit7/TlQxe08nQRrOak1c/FDLiCdJLRmuFfQqBQMEkUbnj 6hqQ== X-Forwarded-Encrypted: i=1; AJvYcCVNZJKmTRWmI14TdeflGLgtEt5qNdWGu0aElw6JpvrE9mMmZlNP6RofC9fpDJaWoH1UiqlwuxLtGlx8O0FTK9nH@vger.kernel.org X-Gm-Message-State: AOJu0YyqkBUoIECEh56Thxrvj4WwAsVL9IWjAhVNZgbMmxjcU9px8GCm v2q8eYZi6PNJvCRo4r4ztMapzwWfQN7vhw5QmlsS6OAkBbuzzipDsn3a X-Gm-Gg: ASbGncsALS+Rl37TQUpfxcksnHUl9KFQzU1wvhTj0byt26HVeI7IeFhNy4bzgN0Rav/ 5bFx69/EmGr5TvZNqoNq4OH82aIeV0JFXIuLQs61OxQ9Q+WU8b88dCX/QddusISOCIxC1Lf4d7i da/RRGpmNtSVbr85F0bBrs1rB6kT0DwPSsbZyLd97hY6uH5lCBmfYbbL8Yh7XgEy0SS6ji9wU+h j09Vms9RG92n1M0mqk2juEE7/1IiPD9dYmSUCWLQRch0j1weT4rpX4iFqKf6Joq/yhAhSDDnAW4 8ej3LpGkUEt8nAiFMnAeG/OqUfjO71ksb6Mb74CxtYeDm2cyADEmSYVvm0GumUicVa6kSrCDdLC KD79RoDQ5KuRvgz9WefxgMiHUCe/wwtDNgdmOkiXGDoHcsIwrrce9nQrFzINz8VYic0ciMK4= X-Google-Smtp-Source: AGHT+IEEjbaanbFet6ymw5rLaG4ER6hS8x4PnRfmIgvGUILNfBcq5r77DsCvwjAQjB7po7/MVjYJ6Q== X-Received: by 2002:a17:902:e94e:b0:270:4aa8:2dcc with SMTP id d9443c01a7336-2902737c5e9mr92201005ad.19.1760007487406; Thu, 09 Oct 2025 03:58:07 -0700 (PDT) Received: from localhost ([45.142.165.62]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b51105813sm6628595a91.10.2025.10.09.03.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 03:58:06 -0700 (PDT) From: Jinchao Wang To: Andrew Morton , Masami Hiramatsu , Peter Zijlstra , Mike Rapoport , Alexander Potapenko , Randy Dunlap , Marco Elver , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Kees Cook , Alice Ryhl , Sami Tolvanen , Miguel Ojeda , Masahiro Yamada , Rong Xu , Naveen N Rao , David Kaplan , Andrii Nakryiko , Jinjie Ruan , Nam Cao , workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, "David S. Miller" , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org Cc: Jinchao Wang Subject: [PATCH v7 15/23] mm/ksw: manage probe and HWBP lifecycle via procfs Date: Thu, 9 Oct 2025 18:55:51 +0800 Message-ID: <20251009105650.168917-16-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009105650.168917-1-wangjinchao600@gmail.com> References: <20251009105650.168917-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow dynamic enabling/disabling of KStackWatch through user input of proc. With this patch, the entire system becomes functional. Signed-off-by: Jinchao Wang --- mm/kstackwatch/kernel.c | 60 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 2 deletions(-) diff --git a/mm/kstackwatch/kernel.c b/mm/kstackwatch/kernel.c index 898ebb2966fe..57628bace365 100644 --- a/mm/kstackwatch/kernel.c +++ b/mm/kstackwatch/kernel.c @@ -14,6 +14,43 @@ static struct ksw_config *ksw_config; static struct dentry *dbgfs_config; static struct dentry *dbgfs_dir; +static bool watching_active; + +static int ksw_start_watching(void) +{ + int ret; + + /* + * Watch init will preallocate the HWBP, + * so it must happen before stack init + */ + ret = ksw_watch_init(); + if (ret) { + pr_err("ksw_watch_init ret: %d\n", ret); + return ret; + } + + ret = ksw_stack_init(); + if (ret) { + pr_err("ksw_stack_init ret: %d\n", ret); + ksw_watch_exit(); + return ret; + } + watching_active = true; + + pr_info("start watching: %s\n", ksw_config->user_input); + return 0; +} + +static void ksw_stop_watching(void) +{ + ksw_stack_exit(); + ksw_watch_exit(); + watching_active = false; + + pr_info("stop watching: %s\n", ksw_config->user_input); +} + struct param_map { const char *name; /* long name */ const char *short_name; /* short name (2 letters) */ @@ -117,8 +154,18 @@ static int ksw_parse_config(char *buf, struct ksw_config *config) static ssize_t ksw_dbgfs_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) { - return simple_read_from_buffer(buf, count, ppos, ksw_config->user_input, - ksw_config->user_input ? strlen(ksw_config->user_input) : 0); + const char *out; + size_t len; + + if (watching_active && ksw_config->user_input) { + out = ksw_config->user_input; + len = strlen(out); + } else { + out = "not watching\n"; + len = strlen(out); + } + + return simple_read_from_buffer(buf, count, ppos, out, len); } static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, @@ -133,6 +180,9 @@ static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, if (copy_from_user(input, buffer, count)) return -EFAULT; + if (watching_active) + ksw_stop_watching(); + input[count] = '\0'; strim(input); @@ -147,6 +197,12 @@ static ssize_t ksw_dbgfs_write(struct file *file, const char __user *buffer, return ret; } + ret = ksw_start_watching(); + if (ret) { + pr_err("Failed to start watching with %d\n", ret); + return ret; + } + return count; } -- 2.43.0