From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Leo Yan <leo.yan@arm.com>
Subject: [PATCH v2 05/25] perf arm_spe: Decode ASE and FP fields in other operation
Date: Fri, 17 Oct 2025 11:04:54 +0100 [thread overview]
Message-ID: <20251017-perf_support_arm_spev1-3-v2-5-2d41e4746e1b@arm.com> (raw)
In-Reply-To: <20251017-perf_support_arm_spev1-3-v2-0-2d41e4746e1b@arm.com>
Add a check for other operation, which prevents any incorrectly
classifying. Parse the ASE and FP fields.
After:
. 0000002f: 48 06 OTHER ASE FP INSN-OTHER
. 00000031: b2 08 80 48 01 08 00 ff ff VA 0xffff000801488008
. 0000003a: 9a 00 00 LAT 0 XLAT
. 0000003d: 42 16 EV RETIRED L1D-ACCESS TLB-ACCESS
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 +++++-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
index 533920b738cbcb39136d1ba3d88e99f9d8009e74..21b65a9b40f481b6cb25aaf01ab627ade046ff72 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
@@ -351,8 +351,12 @@ static int arm_spe_pkt_desc_op_type(const struct arm_spe_pkt *packet,
arm_spe_pkt_out_string(&err, &buf, &buf_len, " FP");
if (payload & SPE_OP_PKT_SVE_PRED)
arm_spe_pkt_out_string(&err, &buf, &buf_len, " PRED");
- } else {
+ } else if (SPE_OP_PKT_OTHER_SUBCLASS_OTHER(payload)) {
arm_spe_pkt_out_string(&err, &buf, &buf_len, "OTHER");
+ if (payload & SPE_OP_PKT_OTHER_ASE)
+ arm_spe_pkt_out_string(&err, &buf, &buf_len, " ASE");
+ if (payload & SPE_OP_PKT_OTHER_FP)
+ arm_spe_pkt_out_string(&err, &buf, &buf_len, " FP");
arm_spe_pkt_out_string(&err, &buf, &buf_len, " %s",
payload & SPE_OP_PKT_COND ?
"COND-SELECT" : "INSN-OTHER");
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
index 48bd9e9ef132b11b79ffe2e2fbc7cfe4c340ff92..704601c6dbe30e93f83a82670d0d60344a22222a 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
@@ -123,8 +123,12 @@ enum arm_spe_events {
#define SPE_OP_PKT_HDR_CLASS_LD_ST_ATOMIC 0x1
#define SPE_OP_PKT_HDR_CLASS_BR_ERET 0x2
+#define SPE_OP_PKT_OTHER_SUBCLASS_OTHER(v) (((v) & GENMASK_ULL(7, 3)) == 0x0)
#define SPE_OP_PKT_OTHER_SUBCLASS_SVE(v) (((v) & (BIT(7) | BIT(3) | BIT(0))) == 0x8)
+#define SPE_OP_PKT_OTHER_ASE BIT(2)
+#define SPE_OP_PKT_OTHER_FP BIT(1)
+
#define SPE_OP_PKT_LDST_SUBCLASS_GP_REG(v) (((v) & GENMASK_ULL(7, 1)) == 0x0)
#define SPE_OP_PKT_LDST_SUBCLASS_SIMD_FP(v) (((v) & GENMASK_ULL(7, 1)) == 0x4)
#define SPE_OP_PKT_LDST_SUBCLASS_UNSPEC_REG(v) (((v) & GENMASK_ULL(7, 1)) == 0x10)
--
2.34.1
next prev parent reply other threads:[~2025-10-17 10:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 10:04 [PATCH v2 00/25] perf arm_spe: Extend operations Leo Yan
2025-10-17 10:04 ` [PATCH v2 01/25] perf arm_spe: Fix memset subclass in operation Leo Yan
2025-10-17 10:04 ` [PATCH v2 02/25] perf arm_spe: Unify operation naming Leo Yan
2025-10-17 10:04 ` [PATCH v2 03/25] perf arm_spe: Decode GCS operation Leo Yan
2025-10-17 10:04 ` [PATCH v2 04/25] perf arm_spe: Rename SPE_OP_PKT_IS_OTHER_SVE_OP macro Leo Yan
2025-10-17 10:04 ` Leo Yan [this message]
2025-10-17 10:04 ` [PATCH v2 06/25] perf arm_spe: Decode SME data processing packet Leo Yan
2025-10-17 10:04 ` [PATCH v2 07/25] perf arm_spe: Remove unused operation types Leo Yan
2025-10-17 10:04 ` [PATCH v2 08/25] perf arm_spe: Consolidate " Leo Yan
2025-10-17 10:04 ` [PATCH v2 09/25] perf arm_spe: Introduce data processing macro for SVE operations Leo Yan
2025-10-17 10:04 ` [PATCH v2 10/25] perf arm_spe: Report register access in record Leo Yan
2025-10-17 10:05 ` [PATCH v2 11/25] perf arm_spe: Report MTE allocation tag " Leo Yan
2025-10-17 10:05 ` [PATCH v2 12/25] perf arm_spe: Report extended memory operations in records Leo Yan
2025-10-17 10:05 ` [PATCH v2 13/25] perf arm_spe: Report associated info for SVE / SME operations Leo Yan
2025-10-17 10:05 ` [PATCH v2 14/25] perf arm_spe: Report memset and memcpy in records Leo Yan
2025-10-17 10:05 ` [PATCH v2 15/25] perf arm_spe: Report GCS in record Leo Yan
2025-10-17 10:05 ` [PATCH v2 16/25] perf arm_spe: Expose SIMD information in other operations Leo Yan
2025-10-17 10:05 ` [PATCH v2 17/25] perf arm_spe: Synthesize memory samples for SIMD operations Leo Yan
2025-10-17 10:05 ` [PATCH v2 18/25] perf/uapi: Extend data source fields Leo Yan
2025-11-12 18:03 ` Leo Yan
2025-11-12 18:15 ` Leo Yan
2025-10-17 10:05 ` [PATCH v2 19/25] tools/include: Sync uapi/linux/perf.h with the kernel sources Leo Yan
2025-10-17 10:05 ` [PATCH v2 20/25] perf mem: Print extended fields Leo Yan
2025-10-17 10:05 ` [PATCH v2 21/25] perf arm_spe: Set extended fields in data source Leo Yan
2025-10-17 10:05 ` [PATCH v2 22/25] perf sort: Support sort ASE and SME Leo Yan
2025-10-17 10:05 ` [PATCH v2 23/25] perf sort: Sort disabled and full predicated flags Leo Yan
2025-10-17 10:05 ` [PATCH v2 24/25] perf report: Update document for SIMD flags Leo Yan
2025-10-17 10:05 ` [PATCH v2 25/25] perf arm_spe: Improve SIMD flags setting Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017-perf_support_arm_spev1-3-v2-5-2d41e4746e1b@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).