Re: [PATCH 05/25] perf arm_spe: Decode ASE and FP fields in other operation

[Leo Yan <leo.yan@arm.com>]

On Thu, Oct 09, 2025 at 10:06:34AM +0100, James Clark wrote:

[...]

> > > --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> > > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> > > @@ -351,8 +351,12 @@ static int arm_spe_pkt_desc_op_type(const
> > > struct arm_spe_pkt *packet,
> > >                   arm_spe_pkt_out_string(&err, &buf, &buf_len, " FP");
> > >               if (payload & SPE_OP_PKT_SVE_PRED)
> > >                   arm_spe_pkt_out_string(&err, &buf, &buf_len, " PRED");
> > > -        } else {
> > > +        } else if (SPE_OP_PKT_OTHER_SUBCLASS_OTHER(payload)) {
> > >               arm_spe_pkt_out_string(&err, &buf, &buf_len, "OTHER");
> > > +            if (payload & SPE_OP_PKT_OTHER_ASE)
> > > +                arm_spe_pkt_out_string(&err, &buf, &buf_len, " ASE");
> > > +            if (payload & SPE_OP_PKT_OTHER_FP)
> > > +                arm_spe_pkt_out_string(&err, &buf, &buf_len, " FP");
> > >               arm_spe_pkt_out_string(&err, &buf, &buf_len, " %s",
> > >                              payload & SPE_OP_PKT_COND ?
> > >                              "COND-SELECT" : "INSN-OTHER");
> > 
> > A warning for unknown packet type would be useful here now that there is
> > no final else catch-all.
> > 
> 
> Although I see it's consistent with other cases now. Maybe it could be a
> later fix to add unknown packet type warnings for all cases.

Yeah, a new version of the patch set will address the comments in this
series, except that I'd prefer to defer adding a warning for unknown
types.

Thanks a lot for review!

Leo