[PATCH 0/3] perf jevents: Fix build when there are other json files in the tree

[PATCH 0/3] perf jevents: Fix build when there are other json files in the tree

[James Clark]

I hit this issue because I'm using clangd with a json compile database.
Not sure if anyone else will actually hit this, but it's not impossible
and the fix is trivial anyway. The first commit is the fix so has a tag.
The other two commits are minor related cleanups.

Signed-off-by: James Clark <james.clark@linaro.org>
---
James Clark (3):
      perf jevents: Fix build when there are other json files in the tree
      perf jevents: Remove unused makefile variable
      perf jevents: Suppress circular dependency warnings

 tools/perf/pmu-events/Build | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
base-commit: ad83f3b7155db28e82de24dbaa1af2b8f5d972a3
change-id: 20251020-james-perf-fix-json-find-9ffed1e52693

Best regards,
-- 
James Clark <james.clark@linaro.org>

[PATCH 1/3] perf jevents: Fix build when there are other json files in the tree

[James Clark]

The unquoted glob *.json will expand to a real file if, for example,
there is any file in the Perf source ending in .json. This can happen
when using tools like Bear and clangd which generate a
compile_commands.json file. With the glob already expanded by the shell,
the find command will fail to wildcard any real json events files.

Fix it by wrapping the star in quotes so it's passed to find rather than
the shell.

This fixes the following build error (most of the diff output omitted):

  $ make V=1 -C tools/perf O=/tmp/perf_build_with_json

  TEST    /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log
  ...
   /* offset=121053 */ "node-access\000legacy cache\000Local memory read accesses\000legacy-cache-config=6\000\00010\000\000\000\000\000"
   /* offset=121135 */ "node-misses\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
   /* offset=121221 */ "node-miss\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
  ...
  -       {
                  .event_table = { 0, 0 },
                  .metric_table = { 0, 0 },
          },
  make[3]: *** [pmu-events/Build:54: /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log] Error 1

Fixes: 4bb55de4ff03 ("perf jevents: Support copying the source json files to OUTPUT")
Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/pmu-events/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index 4ebf37c14978..ee8ba74f82de 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -1,6 +1,6 @@
 pmu-events-y	+= pmu-events.o
 JDIR		=  pmu-events/arch/$(SRCARCH)
-JSON		=  $(shell find pmu-events/arch -name *.json -o -name *.csv)
+JSON		=  $(shell find pmu-events/arch -name '*.json' -o -name '*.csv')
 JDIR_TEST	=  pmu-events/arch/test
 JSON_TEST	=  $(shell [ -d $(JDIR_TEST) ] &&			\
 			find $(JDIR_TEST) -name '*.json')

-- 
2.34.1

Re: [PATCH 1/3] perf jevents: Fix build when there are other json files in the tree

[Leo Yan]

On Mon, Oct 20, 2025 at 05:08:26PM +0100, James Clark wrote:
> The unquoted glob *.json will expand to a real file if, for example,
> there is any file in the Perf source ending in .json. This can happen
> when using tools like Bear and clangd which generate a
> compile_commands.json file. With the glob already expanded by the shell,
> the find command will fail to wildcard any real json events files.
> 
> Fix it by wrapping the star in quotes so it's passed to find rather than
> the shell.
> 
> This fixes the following build error (most of the diff output omitted):
> 
>   $ make V=1 -C tools/perf O=/tmp/perf_build_with_json
> 
>   TEST    /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log
>   ...
>    /* offset=121053 */ "node-access\000legacy cache\000Local memory read accesses\000legacy-cache-config=6\000\00010\000\000\000\000\000"
>    /* offset=121135 */ "node-misses\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
>    /* offset=121221 */ "node-miss\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
>   ...
>   -       {
>                   .event_table = { 0, 0 },
>                   .metric_table = { 0, 0 },
>           },
>   make[3]: *** [pmu-events/Build:54: /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log] Error 1
> 
> Fixes: 4bb55de4ff03 ("perf jevents: Support copying the source json files to OUTPUT")
> Signed-off-by: James Clark <james.clark@linaro.org>

Searched a bit, if without quotes, the wildcard will be expanded by make
but not by shell.  It makes sense for me to fix it with quotes.

Reviewed-by: Leo Yan <leo.yan@arm.com>

Re: [PATCH 1/3] perf jevents: Fix build when there are other json files in the tree

[James Clark]

On 20/10/2025 5:38 pm, Leo Yan wrote:
> On Mon, Oct 20, 2025 at 05:08:26PM +0100, James Clark wrote:
>> The unquoted glob *.json will expand to a real file if, for example,
>> there is any file in the Perf source ending in .json. This can happen
>> when using tools like Bear and clangd which generate a
>> compile_commands.json file. With the glob already expanded by the shell,
>> the find command will fail to wildcard any real json events files.
>>
>> Fix it by wrapping the star in quotes so it's passed to find rather than
>> the shell.
>>
>> This fixes the following build error (most of the diff output omitted):
>>
>>    $ make V=1 -C tools/perf O=/tmp/perf_build_with_json
>>
>>    TEST    /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log
>>    ...
>>     /* offset=121053 */ "node-access\000legacy cache\000Local memory read accesses\000legacy-cache-config=6\000\00010\000\000\000\000\000"
>>     /* offset=121135 */ "node-misses\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
>>     /* offset=121221 */ "node-miss\000legacy cache\000Local memory read misses\000legacy-cache-config=0x10006\000\00010\000\000\000\000\000"
>>    ...
>>    -       {
>>                    .event_table = { 0, 0 },
>>                    .metric_table = { 0, 0 },
>>            },
>>    make[3]: *** [pmu-events/Build:54: /tmp/perf_build_with_json/pmu-events/empty-pmu-events.log] Error 1
>>
>> Fixes: 4bb55de4ff03 ("perf jevents: Support copying the source json files to OUTPUT")
>> Signed-off-by: James Clark <james.clark@linaro.org>
> 
> Searched a bit, if without quotes, the wildcard will be expanded by make
> but not by shell.  It makes sense for me to fix it with quotes.
> 

I think it is the shell. The only * expanded by make is file names on 
the right hand side of rules. Either way it only makes a difference to 
the commit message.

> Reviewed-by: Leo Yan <leo.yan@arm.com>

Thanks for the review.

[PATCH 2/3] perf jevents: Remove unused makefile variable

[James Clark]

JDIR is unused since commit 4bb55de4ff03 ("perf jevents: Support copying
the source json files to OUTPUT"), remove it.

Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/pmu-events/Build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index ee8ba74f82de..c5e2d5f13766 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -1,5 +1,4 @@
 pmu-events-y	+= pmu-events.o
-JDIR		=  pmu-events/arch/$(SRCARCH)
 JSON		=  $(shell find pmu-events/arch -name '*.json' -o -name '*.csv')
 JDIR_TEST	=  pmu-events/arch/test
 JSON_TEST	=  $(shell [ -d $(JDIR_TEST) ] &&			\

-- 
2.34.1

[PATCH 3/3] perf jevents: Suppress circular dependency warnings

[James Clark]

When doing an in source build, $(OUTPUT) is empty so the rule has the
same input and output file. Suppress the warning by only adding the rule
when doing an out of source build. The same condition already exists for
the clean rule for json files.

This fixes the following warnings:

  make[3]: Circular pmu-events/arch/nds32/mapfile.csv <- pmu-events/arch/nds32/mapfile.csv dependency dropped.
  make[3]: Circular pmu-events/arch/powerpc/mapfile.csv <- pmu-events/arch/powerpc/mapfile.csv dependency dropped.
  ...

Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/pmu-events/Build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
index c5e2d5f13766..a46ab7b612df 100644
--- a/tools/perf/pmu-events/Build
+++ b/tools/perf/pmu-events/Build
@@ -29,10 +29,12 @@ $(PMU_EVENTS_C): $(EMPTY_PMU_EVENTS_C)
 	$(call rule_mkdir)
 	$(Q)$(call echo-cmd,gen)cp $< $@
 else
-# Copy checked-in json for generation.
+# Copy checked-in json to OUTPUT for generation if it's an out of source build
+ifneq ($(OUTPUT),)
 $(OUTPUT)pmu-events/arch/%: pmu-events/arch/%
 	$(call rule_mkdir)
 	$(Q)$(call echo-cmd,gen)cp $< $@
+endif
 
 $(LEGACY_CACHE_JSON): $(LEGACY_CACHE_PY)
 	$(call rule_mkdir)

-- 
2.34.1

Re: [PATCH 3/3] perf jevents: Suppress circular dependency warnings

[Namhyung Kim]

On Mon, Oct 20, 2025 at 05:08:28PM +0100, James Clark wrote:
> When doing an in source build, $(OUTPUT) is empty so the rule has the
> same input and output file. Suppress the warning by only adding the rule
> when doing an out of source build. The same condition already exists for
> the clean rule for json files.
> 
> This fixes the following warnings:
> 
>   make[3]: Circular pmu-events/arch/nds32/mapfile.csv <- pmu-events/arch/nds32/mapfile.csv dependency dropped.
>   make[3]: Circular pmu-events/arch/powerpc/mapfile.csv <- pmu-events/arch/powerpc/mapfile.csv dependency dropped.
>   ...

I noticed this too and confirm it's fixed by this change.

Tested-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> 
> Signed-off-by: James Clark <james.clark@linaro.org>
> ---
>  tools/perf/pmu-events/Build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> index c5e2d5f13766..a46ab7b612df 100644
> --- a/tools/perf/pmu-events/Build
> +++ b/tools/perf/pmu-events/Build
> @@ -29,10 +29,12 @@ $(PMU_EVENTS_C): $(EMPTY_PMU_EVENTS_C)
>  	$(call rule_mkdir)
>  	$(Q)$(call echo-cmd,gen)cp $< $@
>  else
> -# Copy checked-in json for generation.
> +# Copy checked-in json to OUTPUT for generation if it's an out of source build
> +ifneq ($(OUTPUT),)
>  $(OUTPUT)pmu-events/arch/%: pmu-events/arch/%
>  	$(call rule_mkdir)
>  	$(Q)$(call echo-cmd,gen)cp $< $@
> +endif
>  
>  $(LEGACY_CACHE_JSON): $(LEGACY_CACHE_PY)
>  	$(call rule_mkdir)
> 
> -- 
> 2.34.1
> 

Re: [PATCH 0/3] perf jevents: Fix build when there are other json files in the tree

[Leo Yan]

On Mon, Oct 20, 2025 at 05:08:25PM +0100, James Clark wrote:
> I hit this issue because I'm using clangd with a json compile database.
> Not sure if anyone else will actually hit this, but it's not impossible
> and the fix is trivial anyway. The first commit is the fix so has a tag.
> The other two commits are minor related cleanups.

I can reproduce the issue and the redundant warning, and confirmed
the series can fix them:

Tested-by: Leo Yan <leo.yan@arm.com>

Re: [PATCH 0/3] perf jevents: Fix build when there are other json files in the tree

[Namhyung Kim]

On Mon, 20 Oct 2025 17:08:25 +0100, James Clark wrote:
> I hit this issue because I'm using clangd with a json compile database.
> Not sure if anyone else will actually hit this, but it's not impossible
> and the fix is trivial anyway. The first commit is the fix so has a tag.
> The other two commits are minor related cleanups.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung