From: Tianyou Li <tianyou.li@intel.com>
To: Namhyung Kim <namhyung@kernel.org>, James Clark <james.clark@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
tianyou.li@intel.com, wangyang.guo@intel.com, pan.deng@intel.com,
zhiguo.zhou@intel.com, jiebin.sun@intel.com,
thomas.falcon@intel.com, dapeng1.mi@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] perf tools annotate: Align the symbol_annotate return code
Date: Mon, 20 Oct 2025 10:14:34 +0800 [thread overview]
Message-ID: <20251020021434.29082-2-tianyou.li@intel.com> (raw)
In-Reply-To: <aPRbfdU92XRLR-2N@google.com>
Return error code from the symbol_annotate previously checks the
evsel__get_arch from '<0', now to '!=0'.
Suggested-by: James Clark <james.clark@linaro.org>
Tested-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Tianyou Li <tianyou.li@intel.com>
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 39d6594850f1..859e802a1e5e 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1021,7 +1021,7 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
int err, nr;
err = evsel__get_arch(evsel, &arch);
- if (err < 0)
+ if (err)
return err;
if (parch)
--
2.47.1
next prev parent reply other threads:[~2025-10-20 1:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 16:10 [PATCH] perf tools annotate: fix a crash when annotate the same symbol with 's' and 'T' Tianyou Li
2025-10-15 12:30 ` James Clark
2025-10-15 16:49 ` Li, Tianyou
2025-10-15 17:20 ` [PATCH v2] " Tianyou Li
2025-10-15 17:30 ` James Clark
2025-10-16 3:36 ` Li, Tianyou
2025-10-16 13:06 ` James Clark
2025-10-16 15:04 ` Li, Tianyou
2025-10-16 15:18 ` James Clark
2025-10-16 16:04 ` Li, Tianyou
2025-10-19 3:31 ` Namhyung Kim
2025-10-20 1:19 ` Li, Tianyou
2025-10-20 2:14 ` [PATCH v3 1/2] " Tianyou Li
2025-10-20 4:10 ` Namhyung Kim
2025-10-20 6:35 ` Li, Tianyou
2025-10-20 2:14 ` Tianyou Li [this message]
2025-10-20 4:11 ` [PATCH v3 2/2] perf tools annotate: Align the symbol_annotate return code Namhyung Kim
2025-10-20 6:33 ` Li, Tianyou
2025-10-20 7:30 ` [PATCH v4 1/2] perf tools annotate: fix a crash when annotate the same symbol with 's' and 'T' Tianyou Li
2025-10-21 13:56 ` James Clark
2025-10-22 0:39 ` Namhyung Kim
2025-10-20 7:30 ` [PATCH v4 2/2] perf tools annotate: Align the symbol_annotate return code Tianyou Li
2025-10-21 13:56 ` James Clark
2025-10-16 3:45 ` [PATCH v3] perf tools annotate: fix a crash when annotate the same symbol with 's' and 'T' Tianyou Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020021434.29082-2-tianyou.li@intel.com \
--to=tianyou.li@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jiebin.sun@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=pan.deng@intel.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=thomas.falcon@intel.com \
--cc=wangyang.guo@intel.com \
--cc=zhiguo.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).