From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v1 2/2] perf test: Add test that command line period overrides sysfs/json values
Date: Wed, 29 Oct 2025 15:26:38 -0700 [thread overview]
Message-ID: <20251029222638.816100-2-irogers@google.com> (raw)
In-Reply-To: <20251029222638.816100-1-irogers@google.com>
The behavior of weak terms is subtle, add a test that they aren't
accidentally broken.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/record_weak_term.sh | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100755 tools/perf/tests/shell/record_weak_term.sh
diff --git a/tools/perf/tests/shell/record_weak_term.sh b/tools/perf/tests/shell/record_weak_term.sh
new file mode 100755
index 000000000000..7b747b383796
--- /dev/null
+++ b/tools/perf/tests/shell/record_weak_term.sh
@@ -0,0 +1,25 @@
+#!/bin/bash
+# record weak terms
+# SPDX-License-Identifier: GPL-2.0
+# Test that command line options override weak terms from sysfs or inbuilt json.
+set -e
+
+shelldir=$(dirname "$0")
+# shellcheck source=lib/setup_python.sh
+. "${shelldir}"/lib/setup_python.sh
+
+
+event=$(perf list --json | $PYTHON -c "import json,sys; next((print(e['EventName']) for e in json.load(sys.stdin) if e.get('Encoding') and 'period=' in e.get('Encoding')))")
+if [[ "$?" != "0" ]]
+then
+ echo "No sysfs/json events with inbuilt period."
+ exit 2
+fi
+
+if ! perf record -c 1000 -vv -e "$event" -o /dev/null true 2>&1 | \
+ grep -q -F '{ sample_period, sample_freq } 1000'
+then
+ echo "Unexpected verbose output and sample period"
+ exit 1
+fi
+exit 0
--
2.51.1.851.g4ebd6896fd-goog
next prev parent reply other threads:[~2025-10-29 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 22:26 [PATCH v1 1/2] perf pmu: Make pmu_alias_terms weak again Ian Rogers
2025-10-29 22:26 ` Ian Rogers [this message]
2025-11-04 3:37 ` [PATCH v1 2/2] perf test: Add test that command line period overrides sysfs/json values Namhyung Kim
2025-11-04 5:22 ` Ian Rogers
2025-11-06 5:50 ` Namhyung Kim
2025-10-30 5:46 ` [PATCH v1 1/2] perf pmu: Make pmu_alias_terms weak again Namhyung Kim
2025-10-30 15:08 ` Ian Rogers
2025-11-04 3:30 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029222638.816100-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).