From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54F9170826 for ; Fri, 31 Oct 2025 16:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761928003; cv=none; b=aau/557YgusiNR31dxw/WL83GDKCgUTrpiwZAJ0bolGbZT4o/27N/cUduwzLXm3H8U8AFSWTfizTZvWKCaEKTMv6uHS13EIhBdVnFQeNdoWCuOVH1PrvmiDqOqci92h1C1crf0dfG5luFgy6N3bTkLeBqZ0E2GLmGcz9nNXq9dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761928003; c=relaxed/simple; bh=aFM2GNujzxVsQyhmP57xjxMcqYfoxDpjgoh4PV5rLj4=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=SUCrgdOh8nkt5L0UTft5Oz60NEIg0buP5vpnVPmEuMSFVnTpnBP7Hnav6/SouZhk513NGA78KVvycS1ZAMAz29zXR1Gc/96+C6oboQXR7dDyxbEp3E2mhz2TN+RD3ICpV9wRegrFJSSLh2ogoISNB3t+EaTOJpM0g2vVNkHA5dE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ALcijxMI; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ALcijxMI" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2950509239eso23186455ad.0 for ; Fri, 31 Oct 2025 09:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761928001; x=1762532801; darn=vger.kernel.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=MJ5wTxyIGhkSgxSwr5/lDAZSF9YM9vLUs7BuLenptwQ=; b=ALcijxMIQ4aQ+XO7mWqlcrdem8sCrAK+BcwDHzXpYd7LKI4f8vmnAt6xywC/C4vCcs L6yKwWF5mM5E6tl3cSz2TZK9tSNvFiX5B2WTn5R48ra7mMFRmusOJPmumMSlTgQtlxZS HZLepDBFEF4rR8tzCPSbGtjLmCJHNo7ajfg+2oYaLQ18guMknKsrzyLYANybIGw+fFu0 kUN4Arwq1K4UXYTrD66gGrJNlXPOzWaZJ4aFWQ7afEwEpkNNfKElQ64u/UqdX+ZX6ccF Q5/Io2xjB1sc7ZjDEjTbxFNu1kjpmzXLhuigUIZx+lsU1nnTL5fvIyjoaH9Ou7xTmCH3 tg0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761928001; x=1762532801; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MJ5wTxyIGhkSgxSwr5/lDAZSF9YM9vLUs7BuLenptwQ=; b=e4sajdqs8YjlBQrLijhoOeP1zfj/yrzgOKsof2KCNnjsx/LTrii3s649/hjJnMtP7n D0QMXPnepGthiTv0OCPdKrRx6Ey48fRknJaJ6GAAb8iIV8AAGu+WfctbTL1CSTlKHH0E uH6eWaM2gH/wHl3z5X+7gpCl3SDrA+HMnPj+gEUALcpGzS3D6w0xRG+q8TpEu6xI21Qj B2TITkmmz3S6g21ArE9dzAampFev4ZRbToN1PS4I1CmWsxayLNuvQTV352a7onQ1mnwS Jn5bOABWsNB2/c/ANSenwnMGvKV5MAw/ytp3qX449JlbSdxSCHiVAiFWcyJKke5FB8wB SMbg== X-Forwarded-Encrypted: i=1; AJvYcCUL6J2HXRMlTDM9y4mgXrSB242wSWQ4ateW1K8zYKd+h0F5H8/k3RCZPmzUn+k49/qfld1I77ctM3tsQnvosJZT@vger.kernel.org X-Gm-Message-State: AOJu0YwPbXYP4t0CuvagJG/l70JmqTTBIunIicodj8DBalGEzOKVBy8/ pIqPePXtMTkc+Q28AjaYeFq6gDyotC5Ne/0ipZWG2injeTVAPDbNZBUQBrxXQ2vNjslsqn1TOP2 LfEt9tUIiEQ== X-Google-Smtp-Source: AGHT+IGqzeQNFo9eZuSMefnUMIWuDO4SEu5Sqd6gAL3qsuKNC3EDvj3K+NUnEMB3YhqprC4/SfYhertKPrkP X-Received: from pjzj21.prod.google.com ([2002:a17:90a:eb15:b0:340:8351:124d]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c409:b0:276:d3e:6844 with SMTP id d9443c01a7336-2951a493552mr62350685ad.33.1761928001013; Fri, 31 Oct 2025 09:26:41 -0700 (PDT) Date: Fri, 31 Oct 2025 09:26:37 -0700 Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.51.1.930.gacf6e81ea2-goog Message-ID: <20251031162637.1456191-1-irogers@google.com> Subject: [PATCH v1] perf vendor power9 nest metrics: Correct unit from MB to MiB From: Ian Rogers To: Athira Rajeev , Kajol Jain , Madhavan Srinivasan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" 6.1e-5 is very close to 1/16384, where 16384 is 2^14, i.e. a power of 2. When units are in powers of 2 the IEC unit is MiB (mebibytes) rather than MB (megabytes) where the values are powers of 10. This patch corrects the unit for uniformity and because such units may be pattern matched against. Signed-off-by: Ian Rogers --- .../perf/pmu-events/arch/powerpc/power9/nest_metrics.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json index 7a5d1bf543f8..8d028a7c2777 100644 --- a/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json +++ b/tools/perf/pmu-events/arch/powerpc/power9/nest_metrics.json @@ -29,25 +29,25 @@ "MetricExpr" : "nest_mcs01_imc@PM_MCS01_128B_RD_DISP_PORT01@ + nest_mcs01_imc@PM_MCS01_128B_RD_DISP_PORT23@", "MetricName" : "mcs01-read", "MetricGroup" : "memory-bandwidth", - "ScaleUnit": "6.1e-5MB" + "ScaleUnit": "6.1e-5MiB" }, { "MetricExpr" : "nest_mcs23_imc@PM_MCS23_128B_RD_DISP_PORT01@ + nest_mcs23_imc@PM_MCS23_128B_RD_DISP_PORT23@", "MetricName" : "mcs23-read", "MetricGroup" : "memory-bandwidth", - "ScaleUnit": "6.1e-5MB" + "ScaleUnit": "6.1e-5MiB" }, { "MetricExpr" : "nest_mcs01_imc@PM_MCS01_128B_WR_DISP_PORT01@ + nest_mcs01_imc@PM_MCS01_128B_WR_DISP_PORT23@", "MetricName" : "mcs01-write", "MetricGroup" : "memory-bandwidth", - "ScaleUnit": "6.1e-5MB" + "ScaleUnit": "6.1e-5MiB" }, { "MetricExpr" : "nest_mcs23_imc@PM_MCS23_128B_WR_DISP_PORT01@ + nest_mcs23_imc@PM_MCS23_128B_WR_DISP_PORT23@", "MetricName" : "mcs23-write", "MetricGroup" : "memory-bandwidth", - "ScaleUnit": "6.1e-5MB" + "ScaleUnit": "6.1e-5MiB" }, { "MetricExpr" : "nest_powerbus0_imc@PM_PB_CYC@", -- 2.51.1.930.gacf6e81ea2-goog