From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9FBE30E0EA for ; Mon, 10 Nov 2025 16:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762792636; cv=none; b=uclAaaJc5SuCoSRDjSAch8vxbp30n8k2VKuLoae0id2B8CXU+Cw56iuc0v7cIVzWSCDgPgGAJ5Nhfy7dlIWGjH5S0A7yqwx/4q3KVNrsdAR5pC2q5UOGQixT7ooUQEyYVIu88Cws6HFNBWLUdQxdWvI0Ph4pqeih8gv2ofKQR7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762792636; c=relaxed/simple; bh=tFikxSFFwCv1IrH9L1W4062VVacCAi+rgy+45fumM8s=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q0WTHCwHg29dGmXMhK2N+kL1V16FCJtw+5EC2pOpv+mx4D0jkIOnbT8o2KFqsrkMNVWPxRptBzveG2raiti1/KZu2/N9SZm2/hoOz7AN6wDff+mVJLf8wuLUXX/3FljlesvVeICQpbV21ifbFCRlGh+kK6zsUzJCAG9FjZNRj/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JWRYCoeV; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JWRYCoeV" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7a9c64dfa6eso2528059b3a.3 for ; Mon, 10 Nov 2025 08:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762792633; x=1763397433; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=OfQWKEWM8M6Sp/kqVVWTo1Q3rJtTZ9aAiY0lp7l1vgw=; b=JWRYCoeV4eIdOwpESd27XIKf+8iT9XrLIIU2jDVzQjePsiyeqGtpVSajomSGvRHYPr 73xZxrSgsxBIyk8T3RKT2tyUAQFRmn6O7j9G+5TXjJays7s51C5ZhLH2+1ELSnl3FVWx /j/8evvaTnz0ACzy2wBZgwWfMO1O00/UK1m6W4AxHzFzVzwZSFXDMJuQMPgmst2hvNyy YhPPih+OU+A1ZISMUp/YuElrzAzRqBsWJt/GwYFmNitde1cXClk1CVh3wSpkx4TF7f9z jeGYHw+nFoS7uWrJ/w0hmM0zCbf86hhoPxyXFBVxDzqrlL17t6qXgSMYm7isveahbFkq g7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762792633; x=1763397433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OfQWKEWM8M6Sp/kqVVWTo1Q3rJtTZ9aAiY0lp7l1vgw=; b=fc/iBv3mZiEiZb3CZ+W7prlZ1WcsHB40YSAWfYr1agoZYVdl/U2wVxbY3XJVE1x0mn WnVIJdjoWwhs+8NUjtrBzjXariZ/DMTIojMEF3yTksIEuJUPMR6FxyDoCFP7LSRH0oY9 dgwMOJCHbH7hrC176HRDjsTzRKJQG270+b2JLR38+ztW84rKAjojNzr/ScmeYjf3buyM 0KxAdVTDgopXfMxqeZTH+D6Fqj/YjM6wZdxO0FEFccivpRXFTj8CNIqIKvMcm29HFQP6 VkSRBfZZ/yYSCuw/8FOUmv+dLIFNvprw8vuZ39qwdtc6fdSsEgGd0ihlv04NDh6OLS4f Guww== X-Forwarded-Encrypted: i=1; AJvYcCXCAu2R1NIaQTLiFkCjh3/I07rC7UfL2iXWHyW/EsbGIj6qi3FdBJLCt1jr0rx2uLy317UWaGHqQ2IN4PpaCpaA@vger.kernel.org X-Gm-Message-State: AOJu0YzGJez86aBVciL/QDX/ALJXc2S8yEnaezW2yGfWCPFqOOYktrAw ARl51X0EfBIN88ZVtKZHpqahLIMyI8pkGVqQL1Okkkxhcip1/q9+wAou X-Gm-Gg: ASbGncsqEPKYTeh4u1zhzFhe1qvcjzOxfgzFlE2jTYPbAMMIzY3WcpEt0kDC2ER/S4f OlptAhjztQIvGNyGFr3l6gwOnfZjDAdowRZ02m/FUlehVp6adRoDjv4cyYCaE0moDc+MkRXNu/H PNcQSOK2Ii7KrzaMXZfzfQ+gD3afNDSaQUuiUeFjLBJpPlqJRPsRi3YG7nRZctePssqlEm6sCJV gEQ6wk5pP0QCrWAuPuhJQVMGeLXhy0o4KRKo4QaR07HebBZr3aHcnk2d4SMJFuRxubSW6bk1os0 leublrU66ZtBymV2xeUa438YbPfBWrfBe50+UCyD6Co9TZhjVpHuxW6djtPKMJXEc5CV3wxazUH 8FQP8d1qWIr1vTQ6BTCN/CKT2L2iaVbcLXdG4HN37jc8o4WkpD814fwynbY1Yn9PK1xEoaVGvoP GVhzTnd5uhGzsIJmI/q12djw== X-Google-Smtp-Source: AGHT+IHERHOBNDq56+F7J5rW3t9aw2ypcpu6OwOvG+DJGpa6Vz1ez0X0Vnm2nUUH/tERSMimjoOmZw== X-Received: by 2002:a05:6a20:5483:b0:342:873d:7e62 with SMTP id adf61e73a8af0-353a2d42046mr10346355637.29.1762792632699; Mon, 10 Nov 2025 08:37:12 -0800 (PST) Received: from localhost ([103.88.46.62]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b0cc17784bsm12559855b3a.47.2025.11.10.08.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 08:37:12 -0800 (PST) From: Jinchao Wang To: Andrew Morton , "Masami Hiramatsu (Google)" , Peter Zijlstra , Randy Dunlap , Marco Elver , Mike Rapoport , Alexander Potapenko , Adrian Hunter , Alexander Shishkin , Alice Ryhl , Andrey Konovalov , Andrey Ryabinin , Andrii Nakryiko , Ard Biesheuvel , Arnaldo Carvalho de Melo , Ben Segall , Bill Wendling , Borislav Petkov , Catalin Marinas , Dave Hansen , David Hildenbrand , David Kaplan , "David S. Miller" , Dietmar Eggemann , Dmitry Vyukov , "H. Peter Anvin" , Ian Rogers , Ingo Molnar , James Clark , Jinchao Wang , Jinjie Ruan , Jiri Olsa , Jonathan Corbet , Juri Lelli , Justin Stitt , kasan-dev@googlegroups.com, Kees Cook , "Liam R. Howlett" , "Liang Kan" , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, llvm@lists.linux.dev, Lorenzo Stoakes , Mark Rutland , Masahiro Yamada , Mathieu Desnoyers , Mel Gorman , Michal Hocko , Miguel Ojeda , Nam Cao , Namhyung Kim , Nathan Chancellor , Naveen N Rao , Nick Desaulniers , Rong Xu , Sami Tolvanen , Steven Rostedt , Suren Baghdasaryan , Thomas Gleixner , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Valentin Schneider , Vincent Guittot , Vincenzo Frascino , Vlastimil Babka , Will Deacon , workflows@vger.kernel.org, x86@kernel.org Subject: [PATCH v8 07/27] mm/ksw: add HWBP pre-allocation Date: Tue, 11 Nov 2025 00:36:02 +0800 Message-ID: <20251110163634.3686676-8-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110163634.3686676-1-wangjinchao600@gmail.com> References: <20251110163634.3686676-1-wangjinchao600@gmail.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pre-allocate per-CPU hardware breakpoints at init with a place holder address, which will be retargeted dynamically in kprobe handler. This avoids allocation in atomic context. At most max_watch breakpoints are allocated (0 means no limit). Signed-off-by: Jinchao Wang --- include/linux/kstackwatch.h | 13 ++++++ mm/kstackwatch/watch.c | 93 +++++++++++++++++++++++++++++++++++++ 2 files changed, 106 insertions(+) diff --git a/include/linux/kstackwatch.h b/include/linux/kstackwatch.h index ada5ac64190c..eb9f2b4f2109 100644 --- a/include/linux/kstackwatch.h +++ b/include/linux/kstackwatch.h @@ -2,6 +2,9 @@ #ifndef _KSTACKWATCH_H #define _KSTACKWATCH_H +#include +#include +#include #include #define MAX_CONFIG_STR_LEN 128 @@ -38,4 +41,14 @@ struct ksw_config { // singleton, only modified in kernel.c const struct ksw_config *ksw_get_config(void); +/* watch management */ +struct ksw_watchpoint { + struct perf_event *__percpu *event; + struct perf_event_attr attr; + struct llist_node node; // for atomic watch_on and off + struct list_head list; // for cpu online and offline +}; +int ksw_watch_init(void); +void ksw_watch_exit(void); + #endif /* _KSTACKWATCH_H */ diff --git a/mm/kstackwatch/watch.c b/mm/kstackwatch/watch.c index cec594032515..4947eac32c61 100644 --- a/mm/kstackwatch/watch.c +++ b/mm/kstackwatch/watch.c @@ -1 +1,94 @@ // SPDX-License-Identifier: GPL-2.0 +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include +#include +#include +#include +#include +#include + +static LLIST_HEAD(free_wp_list); +static LIST_HEAD(all_wp_list); +static DEFINE_MUTEX(all_wp_mutex); + +static ulong holder; + +static void ksw_watch_handler(struct perf_event *bp, + struct perf_sample_data *data, + struct pt_regs *regs) +{ + pr_err("========== KStackWatch: Caught stack corruption =======\n"); + pr_err("config %s\n", ksw_get_config()->user_input); + dump_stack(); + pr_err("=================== KStackWatch End ===================\n"); + + if (ksw_get_config()->panic_hit) + panic("Stack corruption detected"); +} + +static int ksw_watch_alloc(void) +{ + int max_watch = ksw_get_config()->max_watch; + struct ksw_watchpoint *wp; + int success = 0; + int ret; + + init_llist_head(&free_wp_list); + + //max_watch=0 means at most + while (!max_watch || success < max_watch) { + wp = kzalloc(sizeof(*wp), GFP_KERNEL); + if (!wp) + return success > 0 ? success : -EINVAL; + + hw_breakpoint_init(&wp->attr); + wp->attr.bp_addr = (ulong)&holder; + wp->attr.bp_len = sizeof(ulong); + wp->attr.bp_type = HW_BREAKPOINT_W; + wp->event = register_wide_hw_breakpoint(&wp->attr, + ksw_watch_handler, wp); + if (IS_ERR((void *)wp->event)) { + ret = PTR_ERR((void *)wp->event); + kfree(wp); + return success > 0 ? success : ret; + } + llist_add(&wp->node, &free_wp_list); + mutex_lock(&all_wp_mutex); + list_add(&wp->list, &all_wp_list); + mutex_unlock(&all_wp_mutex); + success++; + } + + return success; +} + +static void ksw_watch_free(void) +{ + struct ksw_watchpoint *wp, *tmp; + + mutex_lock(&all_wp_mutex); + list_for_each_entry_safe(wp, tmp, &all_wp_list, list) { + list_del(&wp->list); + unregister_wide_hw_breakpoint(wp->event); + kfree(wp); + } + mutex_unlock(&all_wp_mutex); +} + +int ksw_watch_init(void) +{ + int ret; + + ret = ksw_watch_alloc(); + if (ret <= 0) + return -EBUSY; + + + return 0; +} + +void ksw_watch_exit(void) +{ + ksw_watch_free(); +} -- 2.43.0