From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>, Chun-Tse Shao <ctshao@google.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
Collin Funk <collin.funk1@gmail.com>,
Thomas Falcon <thomas.falcon@intel.com>,
Howard Chu <howardchu95@gmail.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Levi Yun <yeoreum.yun@arm.com>,
Yang Li <yang.lee@linux.alibaba.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>
Subject: [PATCH v3 16/18] perf test stat: Update test expectations and events
Date: Mon, 10 Nov 2025 20:04:15 -0800 [thread overview]
Message-ID: <20251111040417.270945-17-irogers@google.com> (raw)
In-Reply-To: <20251111040417.270945-1-irogers@google.com>
test_stat_record_report and test_stat_record_script used default
output which triggers a bug when sending metrics. As this isn't
relevant to the test switch to using named software events.
Update the match in test_hybrid as the cycles event is now cpu-cycles
to workaround potential ARM issues.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/stat.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/tests/shell/stat.sh b/tools/perf/tests/shell/stat.sh
index 8a100a7f2dc1..985adc02749e 100755
--- a/tools/perf/tests/shell/stat.sh
+++ b/tools/perf/tests/shell/stat.sh
@@ -18,7 +18,7 @@ test_default_stat() {
test_stat_record_report() {
echo "stat record and report test"
- if ! perf stat record -o - true | perf stat report -i - 2>&1 | \
+ if ! perf stat record -e task-clock -o - true | perf stat report -i - 2>&1 | \
grep -E -q "Performance counter stats for 'pipe':"
then
echo "stat record and report test [Failed]"
@@ -30,7 +30,7 @@ test_stat_record_report() {
test_stat_record_script() {
echo "stat record and script test"
- if ! perf stat record -o - true | perf script -i - 2>&1 | \
+ if ! perf stat record -e task-clock -o - true | perf script -i - 2>&1 | \
grep -E -q "CPU[[:space:]]+THREAD[[:space:]]+VAL[[:space:]]+ENA[[:space:]]+RUN[[:space:]]+TIME[[:space:]]+EVENT"
then
echo "stat record and script test [Failed]"
@@ -196,7 +196,7 @@ test_hybrid() {
fi
# Run default Perf stat
- cycles_events=$(perf stat -- true 2>&1 | grep -E "/cycles/[uH]*| cycles[:uH]* " -c)
+ cycles_events=$(perf stat -a -- sleep 0.1 2>&1 | grep -E "/cpu-cycles/[uH]*| cpu-cycles[:uH]* " -c)
# The expectation is that default output will have a cycles events on each
# hybrid PMU. In situations with no cycles PMU events, like virtualized, this
--
2.51.2.1041.gc1ab5b90ca-goog
next prev parent reply other threads:[~2025-11-11 4:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 4:03 [PATCH v3 00/18] Switch the default perf stat metrics to json Ian Rogers
2025-11-11 4:04 ` [PATCH v3 01/18] perf metricgroup: Add care to picking the evsel for displaying a metric Ian Rogers
2025-11-11 8:15 ` Mi, Dapeng
2025-11-11 17:20 ` Ian Rogers
2025-11-11 19:05 ` Namhyung Kim
2025-11-12 8:14 ` Mi, Dapeng
2025-11-11 4:04 ` [PATCH v3 02/18] perf expr: Add #target_cpu literal Ian Rogers
2025-11-11 4:04 ` [PATCH v3 03/18] perf jevents: Add set of common metrics based on default ones Ian Rogers
2025-11-11 6:37 ` Namhyung Kim
2025-11-11 18:38 ` Ian Rogers
2025-11-11 4:04 ` [PATCH v3 04/18] perf jevents: Add metric DefaultShowEvents Ian Rogers
2025-11-11 4:04 ` [PATCH v3 05/18] perf stat: Add detail -d,-dd,-ddd metrics Ian Rogers
2025-11-11 4:04 ` [PATCH v3 06/18] perf script: Change metric format to use json metrics Ian Rogers
2025-11-11 6:59 ` Namhyung Kim
2025-11-11 20:52 ` Ian Rogers
2025-11-11 4:04 ` [PATCH v3 07/18] perf stat: Remove hard coded shadow metrics Ian Rogers
2025-11-11 7:02 ` Namhyung Kim
2025-11-11 17:23 ` Ian Rogers
2025-11-11 19:03 ` Namhyung Kim
2025-11-11 4:04 ` [PATCH v3 08/18] perf stat: Fix default metricgroup display on hybrid Ian Rogers
2025-11-11 4:04 ` [PATCH v3 09/18] perf stat: Sort default events/metrics Ian Rogers
2025-11-11 4:04 ` [PATCH v3 10/18] perf stat: Remove "unit" workarounds for metric-only Ian Rogers
2025-11-11 4:04 ` [PATCH v3 11/18] perf test stat+json: Improve metric-only testing Ian Rogers
2025-11-11 4:04 ` [PATCH v3 12/18] perf test stat: Ignore failures in Default[234] metricgroups Ian Rogers
2025-11-11 4:04 ` [PATCH v3 13/18] perf test stat: Update std_output testing metric expectations Ian Rogers
2025-11-11 4:04 ` [PATCH v3 14/18] perf test metrics: Update all metrics for possibly failing default metrics Ian Rogers
2025-11-11 4:04 ` [PATCH v3 15/18] perf test stat: Update shadow test to use metrics Ian Rogers
2025-11-11 4:04 ` Ian Rogers [this message]
2025-11-11 4:04 ` [PATCH v3 17/18] perf test stat csv: Update test expectations and events Ian Rogers
2025-11-11 4:04 ` [PATCH v3 18/18] perf tool_pmu: Make core_wide and target_cpu json events Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111040417.270945-17-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=collin.funk1@gmail.com \
--cc=ctshao@google.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=thomas.falcon@intel.com \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).