linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	Xu Yang <xu.yang_2@nxp.com>,  Chun-Tse Shao <ctshao@google.com>,
	Thomas Richter <tmricht@linux.ibm.com>,
	 Sumanth Korikkar <sumanthk@linux.ibm.com>,
	Collin Funk <collin.funk1@gmail.com>,
	 Thomas Falcon <thomas.falcon@intel.com>,
	Howard Chu <howardchu95@gmail.com>,
	 Dapeng Mi <dapeng1.mi@linux.intel.com>,
	Levi Yun <yeoreum.yun@arm.com>,
	 Yang Li <yang.lee@linux.alibaba.com>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>,
	 Weilin Wang <weilin.wang@intel.com>
Subject: [PATCH v3 08/18] perf stat: Fix default metricgroup display on hybrid
Date: Mon, 10 Nov 2025 20:04:07 -0800	[thread overview]
Message-ID: <20251111040417.270945-9-irogers@google.com> (raw)
In-Reply-To: <20251111040417.270945-1-irogers@google.com>

The logic to skip output of a default metric line was firing on
Alderlake and not displaying 'TopdownL1 (cpu_atom)'. Remove the
need_full_name check as it is equivalent to the different PMU test in
the cases we care about, merge the 'if's and flip the evsel of the PMU
test. The 'if' is now basically saying, if the output matches the last
printed output then skip the output.

Before:
```
             TopdownL1 (cpu_core)                 #     11.3 %  tma_bad_speculation
                                                  #     24.3 %  tma_frontend_bound
             TopdownL1 (cpu_core)                 #     33.9 %  tma_backend_bound
                                                  #     30.6 %  tma_retiring
                                                  #     42.2 %  tma_backend_bound
                                                  #     25.0 %  tma_frontend_bound       (49.81%)
                                                  #     12.8 %  tma_bad_speculation
                                                  #     20.0 %  tma_retiring             (59.46%)
```
After:
```
             TopdownL1 (cpu_core)                 #      8.3 %  tma_bad_speculation
                                                  #     43.7 %  tma_frontend_bound
                                                  #     30.7 %  tma_backend_bound
                                                  #     17.2 %  tma_retiring
             TopdownL1 (cpu_atom)                 #     31.9 %  tma_backend_bound
                                                  #     37.6 %  tma_frontend_bound       (49.66%)
                                                  #     18.0 %  tma_bad_speculation
                                                  #     12.6 %  tma_retiring             (59.58%)
```

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/stat-shadow.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index afbc49e8cb31..c1547128c396 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -256,11 +256,9 @@ static void perf_stat__print_metricgroup_header(struct perf_stat_config *config,
 	 * event. Only align with other metics from
 	 * different metric events.
 	 */
-	if (last_name && !strcmp(last_name, name)) {
-		if (!need_full_name || last_pmu != evsel->pmu) {
-			out->print_metricgroup_header(config, ctxp, NULL);
-			return;
-		}
+	if (last_name && !strcmp(last_name, name) && last_pmu == evsel->pmu) {
+		out->print_metricgroup_header(config, ctxp, NULL);
+		return;
 	}
 
 	if (need_full_name && evsel->pmu)
-- 
2.51.2.1041.gc1ab5b90ca-goog


  parent reply	other threads:[~2025-11-11  4:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11  4:03 [PATCH v3 00/18] Switch the default perf stat metrics to json Ian Rogers
2025-11-11  4:04 ` [PATCH v3 01/18] perf metricgroup: Add care to picking the evsel for displaying a metric Ian Rogers
2025-11-11  8:15   ` Mi, Dapeng
2025-11-11 17:20     ` Ian Rogers
2025-11-11 19:05       ` Namhyung Kim
2025-11-12  8:14         ` Mi, Dapeng
2025-11-11  4:04 ` [PATCH v3 02/18] perf expr: Add #target_cpu literal Ian Rogers
2025-11-11  4:04 ` [PATCH v3 03/18] perf jevents: Add set of common metrics based on default ones Ian Rogers
2025-11-11  6:37   ` Namhyung Kim
2025-11-11 18:38     ` Ian Rogers
2025-11-11  4:04 ` [PATCH v3 04/18] perf jevents: Add metric DefaultShowEvents Ian Rogers
2025-11-11  4:04 ` [PATCH v3 05/18] perf stat: Add detail -d,-dd,-ddd metrics Ian Rogers
2025-11-11  4:04 ` [PATCH v3 06/18] perf script: Change metric format to use json metrics Ian Rogers
2025-11-11  6:59   ` Namhyung Kim
2025-11-11 20:52     ` Ian Rogers
2025-11-11  4:04 ` [PATCH v3 07/18] perf stat: Remove hard coded shadow metrics Ian Rogers
2025-11-11  7:02   ` Namhyung Kim
2025-11-11 17:23     ` Ian Rogers
2025-11-11 19:03       ` Namhyung Kim
2025-11-11  4:04 ` Ian Rogers [this message]
2025-11-11  4:04 ` [PATCH v3 09/18] perf stat: Sort default events/metrics Ian Rogers
2025-11-11  4:04 ` [PATCH v3 10/18] perf stat: Remove "unit" workarounds for metric-only Ian Rogers
2025-11-11  4:04 ` [PATCH v3 11/18] perf test stat+json: Improve metric-only testing Ian Rogers
2025-11-11  4:04 ` [PATCH v3 12/18] perf test stat: Ignore failures in Default[234] metricgroups Ian Rogers
2025-11-11  4:04 ` [PATCH v3 13/18] perf test stat: Update std_output testing metric expectations Ian Rogers
2025-11-11  4:04 ` [PATCH v3 14/18] perf test metrics: Update all metrics for possibly failing default metrics Ian Rogers
2025-11-11  4:04 ` [PATCH v3 15/18] perf test stat: Update shadow test to use metrics Ian Rogers
2025-11-11  4:04 ` [PATCH v3 16/18] perf test stat: Update test expectations and events Ian Rogers
2025-11-11  4:04 ` [PATCH v3 17/18] perf test stat csv: " Ian Rogers
2025-11-11  4:04 ` [PATCH v3 18/18] perf tool_pmu: Make core_wide and target_cpu json events Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111040417.270945-9-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=collin.funk1@gmail.com \
    --cc=ctshao@google.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=howardchu95@gmail.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=thomas.falcon@intel.com \
    --cc=tmricht@linux.ibm.com \
    --cc=weilin.wang@intel.com \
    --cc=xu.yang_2@nxp.com \
    --cc=yang.lee@linux.alibaba.com \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).