linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-perf-users@vger.kernel.org, acme@kernel.org,
	agordeev@linux.ibm.com, gor@linux.ibm.com,
	sumanthk@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com
Subject: Re: [PATCH Linux-next] perf test: Fix test case perf trace BTF general tests
Date: Tue, 18 Nov 2025 13:24:51 -0500	[thread overview]
Message-ID: <20251118132451.29a35127@gandalf.local.home> (raw)
In-Reply-To: <aRwVifZ_-7puFUVC@google.com>

On Mon, 17 Nov 2025 22:43:21 -0800
Namhyung Kim <namhyung@kernel.org> wrote:

> > bash-5.3# uname -a
> > Linux f43 6.18.0-rc5-next-20251114tmr-n #1 SMP PREEMPT_DYNAMIC Mon Nov 17 11:24:02 CET 2025 x86_64 GNU/Linux
> > bash-5.3# cat /sys/kernel/tracing/events/syscalls/sys_enter_write/format
> > name: sys_enter_write
> > ID: 758
> > format:
> > 	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
> > 	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
> > 	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
> > 	field:int common_pid;	offset:4;	size:4;	signed:1;
> > 
> > 	field:int __syscall_nr;	offset:8;	size:4;	signed:1;
> > 	field:unsigned int fd;	offset:16;	size:8;	signed:0;
> > 	field:const char * buf;	offset:24;	size:8;	signed:0;
> > 	field:size_t count;	offset:32;	size:8;	signed:0;
> > 	field:__data_loc char[] __buf_val;	offset:40;	size:4;	signed:0;  
> 
> Indeed, I see this new field __buf_val.
> 
> Steve, is this what you added recently for taking user contents?

Yes.

> Hmm.. this makes perf trace confused wrt the syscall parameters.
> Is it always __buf_val or has any patterns?

Really? It still uses libtraceevent right? I made sure that this didn't
break trace-cmd and thought that perf would work too.

-- Steve

  reply	other threads:[~2025-11-18 18:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 12:43 [PATCH Linux-next] perf test: Fix test case perf trace BTF general tests Thomas Richter
2025-11-18  1:58 ` Namhyung Kim
2025-11-18  6:15   ` Thomas Richter
2025-11-18  6:43     ` Namhyung Kim
2025-11-18 18:24       ` Steven Rostedt [this message]
2025-11-19  4:36         ` Namhyung Kim
2025-11-19 17:59           ` Steven Rostedt
2025-11-20  0:52             ` Namhyung Kim
2025-11-26  7:13               ` Thomas Richter
2025-11-26 15:24                 ` Steven Rostedt
2025-11-26 17:12                   ` Steven Rostedt
2025-11-26 17:37                     ` Steven Rostedt
2025-11-26 18:57                     ` Namhyung Kim
2025-11-26 19:01                       ` Howard Chu
2025-11-27  6:28                   ` Thomas Richter
2025-11-18 18:30 ` Jan Polensky
2025-11-19  7:55   ` Thomas Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118132451.29a35127@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=acme@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=japo@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=sumanthk@linux.ibm.com \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).