linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	Collin Funk <collin.funk1@gmail.com>,
	 Dmitry Vyukov <dvyukov@google.com>,
	Andi Kleen <ak@linux.intel.com>,
	 Thomas Falcon <thomas.falcon@intel.com>,
	Leo Yan <leo.yan@arm.com>,
	 Yicong Yang <yangyicong@hisilicon.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	Stephen Brennan <stephen.s.brennan@oracle.com>,
	 Haibo Xu <haibo1.xu@intel.com>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org
Subject: [PATCH v1 13/17] perf tests timechart: Add a perf timechart test
Date: Sat, 22 Nov 2025 00:19:25 -0800	[thread overview]
Message-ID: <20251122081929.7588-14-irogers@google.com> (raw)
In-Reply-To: <20251122081929.7588-1-irogers@google.com>

Basic coverage for `perf timechart` doing a record and then a basic
sanity test of the generated SVG file.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/timechart.sh | 67 +++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100755 tools/perf/tests/shell/timechart.sh

diff --git a/tools/perf/tests/shell/timechart.sh b/tools/perf/tests/shell/timechart.sh
new file mode 100755
index 000000000000..b14b3472c284
--- /dev/null
+++ b/tools/perf/tests/shell/timechart.sh
@@ -0,0 +1,67 @@
+#!/bin/bash
+# perf timechart tests
+# SPDX-License-Identifier: GPL-2.0
+
+set -e
+
+err=0
+perfdata=$(mktemp /tmp/__perf_timechart_test.perf.data.XXXXX)
+output=$(mktemp /tmp/__perf_timechart_test.output.XXXXX.svg)
+
+cleanup() {
+	rm -f "${perfdata}"
+	rm -f "${output}"
+	trap - EXIT TERM INT
+}
+
+trap_cleanup() {
+	echo "Unexpected signal in ${FUNCNAME[1]}"
+	cleanup
+	exit 1
+}
+trap trap_cleanup EXIT TERM INT
+
+test_timechart() {
+	echo "Basic perf timechart test"
+
+	# Try to record timechart data.
+	# perf timechart record uses system-wide recording and specific tracepoints.
+	# If it fails (e.g. permissions, missing tracepoints), skip the test.
+	if ! perf timechart record -o "${perfdata}" true > /dev/null 2>&1; then
+		echo "Basic perf timechart test [Skipped: perf timechart record failed (permissions/events?)]"
+		return
+	fi
+
+	# Generate the timechart
+	if ! perf timechart -i "${perfdata}" -o "${output}" > /dev/null 2>&1; then
+		echo "Basic perf timechart test [Failed: perf timechart command failed]"
+		err=1
+		return
+	fi
+
+	# Check if output file exists and is not empty
+	if [ ! -s "${output}" ]; then
+		echo "Basic perf timechart test [Failed: output file is empty or missing]"
+		err=1
+		return
+	fi
+
+	# Check if it looks like an SVG
+	if ! grep -q "svg" "${output}"; then
+		echo "Basic perf timechart test [Failed: output doesn't look like SVG]"
+		err=1
+		return
+	fi
+
+	echo "Basic perf timechart test [Success]"
+}
+
+if ! perf check feature -q libtraceevent ; then
+	echo "perf timechart is not supported. Skip."
+        cleanup
+	exit 2
+fi
+
+test_timechart
+cleanup
+exit $err
-- 
2.52.0.rc2.455.g230fcf2819-goog


  parent reply	other threads:[~2025-11-22  8:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22  8:19 [PATCH v1 00/17] perf: Small fixes and new tests Ian Rogers
2025-11-22  8:19 ` [PATCH v1 01/17] perf kvm: Fix debug assertion Ian Rogers
2025-11-26  6:33   ` Namhyung Kim
2025-11-22  8:19 ` [PATCH v1 02/17] perf timechart: Add record support for output perf.data path Ian Rogers
2025-11-26  6:38   ` Namhyung Kim
2025-11-22  8:19 ` [PATCH v1 03/17] perf symbol-elf: Add missing puts on error path Ian Rogers
2025-12-01 18:04   ` Arnaldo Carvalho de Melo
2025-11-22  8:19 ` [PATCH v1 04/17] perf symbol: Add missed dso__put Ian Rogers
2025-11-22  8:19 ` [PATCH v1 05/17] perf probe-event: Ensure probe event nsinfo is always cleared Ian Rogers
2025-11-26  6:58   ` Namhyung Kim
2025-11-22  8:19 ` [PATCH v1 06/17] perf hist: In init, ensure mem_info is put on error paths Ian Rogers
2025-12-01 17:05   ` Arnaldo Carvalho de Melo
2025-12-01 17:14   ` Arnaldo Carvalho de Melo
2025-12-01 17:52     ` Ian Rogers
2025-11-22  8:19 ` [PATCH v1 07/17] perf mem-events: Don't leak online CPU map Ian Rogers
2025-12-01 17:01   ` Arnaldo Carvalho de Melo
2025-11-22  8:19 ` [PATCH v1 08/17] perf jitdump: Fix missed dso__put Ian Rogers
2025-12-01 17:00   ` Arnaldo Carvalho de Melo
2025-11-22  8:19 ` [PATCH v1 09/17] perf c2c: Clean up some defensive gets and make asan clean Ian Rogers
2025-12-01 17:45   ` Arnaldo Carvalho de Melo
2025-11-22  8:19 ` [PATCH v1 10/17] perf tests c2c: Add a basic c2c Ian Rogers
2025-11-22  8:19 ` [PATCH v1 11/17] perf tests buildid: Add purge and remove testing Ian Rogers
2025-11-22  8:19 ` [PATCH v1 12/17] perf tests top: Add basic perf top coverage test Ian Rogers
2025-11-22  8:19 ` Ian Rogers [this message]
2025-11-22  8:19 ` [PATCH v1 14/17] perf tests kallsyms: Add basic kallsyms test Ian Rogers
2025-11-22  8:19 ` [PATCH v1 15/17] perf tests script dlfilter: Add a dlfilter test Ian Rogers
2025-11-22  8:19 ` [PATCH v1 16/17] perf tests evlist: Add basic evlist test Ian Rogers
2025-11-26  7:19   ` Namhyung Kim
2025-11-22  8:19 ` [PATCH v1 17/17] perf test kvm: Add some basic perf kvm test coverage Ian Rogers
2025-11-26  7:21   ` Namhyung Kim
2025-11-27 11:53     ` Ian Rogers
2025-11-27 20:55       ` Namhyung Kim
2025-11-28  9:06         ` Ian Rogers
2025-12-03 19:03           ` Namhyung Kim
2025-12-04 19:10 ` [PATCH v1 00/17] perf: Small fixes and new tests Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251122081929.7588-14-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=collin.funk1@gmail.com \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haibo1.xu@intel.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=thomas.falcon@intel.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).