linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	 Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	 Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	 Suzuki K Poulose <suzuki.poulose@arm.com>,
	 Mike Leach <mike.leach@linaro.org>,
	John Garry <john.g.garry@oracle.com>,
	 Will Deacon <will@kernel.org>, Leo Yan <leo.yan@linux.dev>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	 coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org,
	 James Clark <james.clark@linaro.org>
Subject: [PATCH 0/7] perf cs-etm/arm-spe: Remove hard coded config fields
Date: Mon, 01 Dec 2025 16:41:03 +0000	[thread overview]
Message-ID: <20251201-james-perf-config-bits-v1-0-22ecbbf8007c@linaro.org> (raw)

The specific config field that an event format attribute is in is
consistently hard coded, even though the API is supposed to be that the
driver publishes the config field name. To stop this pattern from being
copy pasted and causing problems in the future, replace them all with
calls to a new helper that returns the value that a user set.

The existing evsel__set_config_if_unset() also has a similar problem
that it hard codes attr.config, so fix that too.

There are no functional changes here because all the fields touched are
in attr.config and not config1 or config2 etc. Although this may not be
the case for new fields.

Signed-off-by: James Clark <james.clark@linaro.org>
---
James Clark (7):
      perf tools: Track all user changed config bits
      perf tools: apply evsel__set_config_if_unset() to all config fields
      perf cs-etm: Make a helper to find the Coresight evsel
      perf cs-etm: Don't use hard coded config bits when setting up ETMCR
      perf cs-etm: Don't use hard coded config bits when setting up TRCCONFIGR
      perf cs-etm: Don't hard code config attribute when configuring the event
      perf arm-spe: Don't hard code config attribute

 tools/perf/arch/arm/util/cs-etm.c    | 202 ++++++++++++++++++++---------------
 tools/perf/arch/arm64/util/arm-spe.c |  15 +--
 tools/perf/util/evsel.c              |   6 +-
 tools/perf/util/evsel.h              |   2 +
 tools/perf/util/evsel_config.h       |   6 +-
 tools/perf/util/parse-events.c       |  89 +++++++--------
 tools/perf/util/pmu.c                |  93 +++++++++++++---
 7 files changed, 251 insertions(+), 162 deletions(-)
---
base-commit: 834ebb5678d75d844f5d4f44ede78724d8c96630
change-id: 20251112-james-perf-config-bits-bee7106f0f00

Best regards,
-- 
James Clark <james.clark@linaro.org>


             reply	other threads:[~2025-12-01 16:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01 16:41 James Clark [this message]
2025-12-01 16:41 ` [PATCH 1/7] perf tools: Track all user changed config bits James Clark
2025-12-02 10:15   ` Leo Yan
2025-12-02 10:40     ` James Clark
2025-12-02 11:21       ` Leo Yan
2025-12-02 12:36         ` Leo Yan
2025-12-01 16:41 ` [PATCH 2/7] perf tools: apply evsel__set_config_if_unset() to all config fields James Clark
2025-12-02 11:14   ` Leo Yan
2025-12-04 10:55     ` James Clark
2025-12-01 16:41 ` [PATCH 3/7] perf cs-etm: Make a helper to find the Coresight evsel James Clark
2025-12-02 11:24   ` Leo Yan
2025-12-01 16:41 ` [PATCH 4/7] perf cs-etm: Don't use hard coded config bits when setting up ETMCR James Clark
2025-12-02 11:43   ` Leo Yan
2025-12-02 11:53     ` James Clark
2025-12-04 10:55       ` James Clark
2025-12-04 13:45         ` Mike Leach
2025-12-04 13:48           ` James Clark
2025-12-01 16:41 ` [PATCH 5/7] perf cs-etm: Don't use hard coded config bits when setting up TRCCONFIGR James Clark
2025-12-02 12:01   ` Leo Yan
2025-12-01 16:41 ` [PATCH 6/7] perf cs-etm: Don't hard code config attribute when configuring the event James Clark
2025-12-02 12:15   ` Leo Yan
2025-12-04 14:08     ` James Clark
2025-12-04 14:43       ` Leo Yan
2025-12-01 16:41 ` [PATCH 7/7] perf arm-spe: Don't hard code config attribute James Clark
2025-12-02 12:28   ` Leo Yan
2025-12-02 12:42     ` Leo Yan
2025-12-02 12:59       ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251201-james-perf-config-bits-v1-0-22ecbbf8007c@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=irogers@google.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).