From: James Clark <james.clark@linaro.org>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Leo Yan <leo.yan@linux.dev>,
leo.yan@arm.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
James Clark <james.clark@linaro.org>
Subject: [PATCH v2 00/12] perf cs-etm/arm-spe: Remove hard coded config fields
Date: Mon, 08 Dec 2025 14:22:03 +0000 [thread overview]
Message-ID: <20251208-james-perf-config-bits-v2-0-4ac0281993b0@linaro.org> (raw)
The specific config field that an event format attribute is in is
consistently hard coded, even though the API is supposed to be that the
driver publishes the config field name. To stop this pattern from being
copy pasted and causing problems in the future, replace them all with
calls to a new helper that returns the value that a user set.
This reveals some issues in evsel__set_config_if_unset(). It doesn't
work with sparse bitfields, which are an unused but documented feature.
And it also only writes to the attr.config field. To fix it we need to
start tracking user changes for all config fields and then use existing
helper functions that support sparse bitfields. Some other refactoring
was also required and a test was added.
Signed-off-by: James Clark <james.clark@linaro.org>
---
Changes in v2:
- Remove macros in get_config_chgs() and some other refactoring.
- Support sparse bitfields in evsel__set_config_if_unset().
- Always track user changes instead of only when
'pmu->perf_event_attr_init_default' is set.
- Add a test.
- Don't bail out in cs-etm.c if any format fields are missing (Leo).
- Rename 'guess' to 'synth' (Mike).
- Link to v1: https://lore.kernel.org/r/20251201-james-perf-config-bits-v1-0-22ecbbf8007c@linaro.org
---
James Clark (12):
perf parse-events: Refactor get_config_terms() to remove macros
perf evsel: Support sparse fields in evsel__set_config_if_unset()
perf parse-events: Track all user changed config bits
perf evsel: apply evsel__set_config_if_unset() to all config fields
perf evsel: Add a helper to get the value of a config field
perf parse-events: Always track user config changes
perf tests: Test evsel__set_config_if_unset() and config change tracking
perf cs-etm: Make a helper to find the Coresight evsel
perf cs-etm: Don't use hard coded config bits when setting up ETMCR
perf cs-etm: Don't use hard coded config bits when setting up TRCCONFIGR
perf cs-etm: Don't hard code config attribute when configuring the event
perf arm-spe: Don't hard code config attribute
tools/perf/arch/arm/util/cs-etm.c | 193 +++++++++++++++------------
tools/perf/arch/arm64/util/arm-spe.c | 15 ++-
tools/perf/tests/pmu.c | 90 +++++++++++++
tools/perf/util/evsel.c | 6 +-
tools/perf/util/evsel.h | 2 +
tools/perf/util/evsel_config.h | 7 +-
tools/perf/util/parse-events.c | 248 ++++++++++++++++++++---------------
tools/perf/util/pmu.c | 112 ++++++++++++++--
8 files changed, 459 insertions(+), 214 deletions(-)
---
base-commit: 2eeb09fe1c5173b659929f92fee4461796ca8c14
change-id: 20251112-james-perf-config-bits-bee7106f0f00
Best regards,
--
James Clark <james.clark@linaro.org>
next reply other threads:[~2025-12-08 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 14:22 James Clark [this message]
2025-12-08 14:22 ` [PATCH v2 01/12] perf parse-events: Refactor get_config_terms() to remove macros James Clark
2025-12-09 12:48 ` James Clark
2025-12-09 15:58 ` Ian Rogers
2025-12-09 17:55 ` James Clark
2025-12-09 18:09 ` Ian Rogers
2025-12-12 14:43 ` James Clark
2025-12-08 14:22 ` [PATCH v2 02/12] perf evsel: Support sparse fields in evsel__set_config_if_unset() James Clark
2025-12-08 14:22 ` [PATCH v2 03/12] perf parse-events: Track all user changed config bits James Clark
2025-12-08 14:22 ` [PATCH v2 04/12] perf evsel: apply evsel__set_config_if_unset() to all config fields James Clark
2025-12-08 14:22 ` [PATCH v2 05/12] perf evsel: Add a helper to get the value of a config field James Clark
2025-12-08 14:22 ` [PATCH v2 06/12] perf parse-events: Always track user config changes James Clark
2025-12-08 14:22 ` [PATCH v2 07/12] perf tests: Test evsel__set_config_if_unset() and config change tracking James Clark
2025-12-08 14:22 ` [PATCH v2 08/12] perf cs-etm: Make a helper to find the Coresight evsel James Clark
2025-12-08 14:22 ` [PATCH v2 09/12] perf cs-etm: Don't use hard coded config bits when setting up ETMCR James Clark
2025-12-08 14:22 ` [PATCH v2 10/12] perf cs-etm: Don't use hard coded config bits when setting up TRCCONFIGR James Clark
2025-12-08 14:22 ` [PATCH v2 11/12] perf cs-etm: Don't hard code config attribute when configuring the event James Clark
2025-12-08 14:22 ` [PATCH v2 12/12] perf arm-spe: Don't hard code config attribute James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251208-james-perf-config-bits-v2-0-4ac0281993b0@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=irogers@google.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@arm.com \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).