public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: namhyung@kernel.org, acme@kernel.org
Cc: adrian.hunter@intel.com, ak@linux.intel.com,
	 alexander.shishkin@linux.intel.com, andres@anarazel.de,
	 dapeng1.mi@linux.intel.com, irogers@google.com,
	james.clark@linaro.org,  jolsa@kernel.org,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	linux@treblig.org, mingo@redhat.com,  peterz@infradead.org,
	thomas.falcon@intel.com, tmricht@linux.ibm.com,
	 yang.lee@linux.alibaba.com
Subject: [PATCH v9 4/6] perf evlist: Missing TPEBS close in evlist__close
Date: Mon,  9 Feb 2026 22:03:57 -0800	[thread overview]
Message-ID: <20260210060359.2233425-5-irogers@google.com> (raw)
In-Reply-To: <20260210060359.2233425-1-irogers@google.com>

The libperf evsel close won't close TPEBS events properly. Add a test
to do this. The libperf close routine is used in evlist__close for
affinity reasons.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/evlist.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 3b0d837e3046..3abc2215e790 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1356,6 +1356,8 @@ void evlist__close(struct evlist *evlist)
 		return;
 
 	evlist__for_each_cpu(evlist_cpu_itr, evlist, &affinity) {
+		if (evlist_cpu_itr.cpu_map_idx == 0 && evsel__is_retire_lat(evlist_cpu_itr.evsel))
+			evsel__tpebs_close(evlist_cpu_itr.evsel);
 		perf_evsel__close_cpu(&evlist_cpu_itr.evsel->core,
 				      evlist_cpu_itr.cpu_map_idx);
 	}
-- 
2.53.0.rc2.204.g2597b5adb4-goog


  parent reply	other threads:[~2026-02-10  6:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 22:51 [PATCH v7 0/6] perf stat affinity changes Ian Rogers
2026-02-03 22:51 ` [PATCH v7 1/6] Revert "perf tool_pmu: More accurately set the cpus for tool events" Ian Rogers
2026-02-03 22:51 ` [PATCH v7 2/6] perf stat-shadow: In prepare_metric fix guard on reading NULL perf_stat_evsel Ian Rogers
2026-02-03 22:51 ` [PATCH v7 3/6] perf evlist: Special map propagation for tool events that read on 1 CPU Ian Rogers
2026-02-03 22:51 ` [PATCH v7 4/6] perf evlist: Missing TPEBS close in evlist__close Ian Rogers
2026-02-03 22:51 ` [PATCH v7 5/6] perf evlist: Reduce affinity use and move into iterator, fix no affinity Ian Rogers
2026-02-03 22:51 ` [PATCH v7 6/6] perf stat: Add no-affinity flag Ian Rogers
2026-02-06 21:35 ` [PATCH v7 0/6] perf stat affinity changes Arnaldo Carvalho de Melo
2026-02-06 22:01   ` Ian Rogers
2026-02-06 22:13     ` Arnaldo Carvalho de Melo
2026-02-06 22:25       ` [PATCH v8 " Ian Rogers
2026-02-06 22:25         ` [PATCH v8 1/6] Revert "perf tool_pmu: More accurately set the cpus for tool events" Ian Rogers
2026-02-09 23:10           ` Ian Rogers
2026-02-06 22:25         ` [PATCH v8 2/6] perf stat-shadow: In prepare_metric fix guard on reading NULL perf_stat_evsel Ian Rogers
2026-02-06 22:25         ` [PATCH v8 3/6] perf evlist: Special map propagation for tool events that read on 1 CPU Ian Rogers
2026-02-06 22:25         ` [PATCH v8 4/6] perf evlist: Missing TPEBS close in evlist__close Ian Rogers
2026-02-06 22:25         ` [PATCH v8 5/6] perf evlist: Reduce affinity use and move into iterator, fix no affinity Ian Rogers
2026-02-06 22:25         ` [PATCH v8 6/6] perf stat: Add no-affinity flag Ian Rogers
2026-02-07 12:51           ` Arnaldo Carvalho de Melo
2026-02-07 15:54             ` Ian Rogers
2026-02-10  1:18               ` Namhyung Kim
2026-02-10  6:03                 ` [PATCH v9 0/6] perf stat affinity changes Ian Rogers
2026-02-10  6:03                 ` Ian Rogers
2026-02-10  6:03                   ` [PATCH v9 1/6] Revert "perf tool_pmu: More accurately set the cpus for tool events" Ian Rogers
2026-02-10  6:03                   ` [PATCH v9 2/6] perf stat-shadow: In prepare_metric fix guard on reading NULL perf_stat_evsel Ian Rogers
2026-02-10  6:03                   ` [PATCH v9 3/6] perf evlist: Special map propagation for tool events that read on 1 CPU Ian Rogers
2026-02-10  6:03                   ` Ian Rogers [this message]
2026-02-10  6:03                   ` [PATCH v9 5/6] perf evlist: Reduce affinity use and move into iterator, fix no affinity Ian Rogers
2026-02-10  6:03                   ` [PATCH v9 6/6] perf stat: Add no-affinity flag Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210060359.2233425-5-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andres@anarazel.de \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=tmricht@linux.ibm.com \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox