Re: [PATCH v5 4/8] dt-bindings: iommu: Add spacemit/t100 features

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3198 bytes --]

On Mon, Mar 02, 2026 at 09:41:55AM +0800, Lv Zheng wrote:
> On 3/1/2026 10:01 PM, Conor Dooley wrote:
> > On Sun, Mar 01, 2026 at 11:48:37AM +0800, Lv Zheng wrote:
> > > On 3/1/2026 5:58 AM, Conor Dooley wrote:
> > > > On Sat, 28 Feb 2026 22:44:49 +0800, Lv Zheng <lv.zheng@linux.spacemit.com> wrote:
> > > > > Adds device tree bindings for SpacemiT T100 specific features by
> > > > > introducing spacemit,t100 compatible. T100 contains distributed IOATCs,
> > > > > each of which exposes pmiv interrupt.
> > > > > 
> > > > > Signed-off-by: Lv Zheng <lv.zheng@linux.spacemit.com>
> > > > > Signed-off-by: Jingyu Li <joey.li@spacemit.com>
> > > > 
> > > > Patch content here is fine, but the signoff chain on this patch is not
> > > > right. What did Jingyu do? You're author and submitter so either Jingyu
> > > > did nothing and should be removed, or is a co-developer which requires
> > > > attribution via the co-developed-by tag. If the latter, their signoff
> > > > should be before yours (the submitter is always last).
> > > > 
> > > > pw-bot: changes-requested
> > > 
> > > She is responsible for the common HPM part, and I just gave my comments to
> > > help to improve the quality of that implementation.
> > > I was just focusing on enabling and maintaining the T100 specific features.
> > > 
> > > Our patches will go each other's local repository, leaving such tracks. That
> > > means the patch from me is Reviewed-and-tested-by her.
> > > And I'm responsible for sending the whole patchset for upstreaming.
> > 
> > Then you need to either fix your email setup (because it's not inserting
> > From: Jingyu Li <joey.li@spacemit.com>) so that she is marked as the
> > author or actually set her to the author in git if you haven't.
> > Currently it looks like this when applied:
> > commit 872978c875731be43e84bec38798cb8ecd42b7a0
> > Author: Lv Zheng <lv.zheng@linux.spacemit.com>
> > Date:   Sat Feb 28 22:44:49 2026 +0800
> > 
> >      dt-bindings: iommu: Add spacemit/t100 features
> >      Adds device tree bindings for SpacemiT T100 specific features by
> >      introducing spacemit,t100 compatible. T100 contains distributed IOATCs,
> >      each of which exposes pmiv interrupt.
> >      Signed-off-by: Lv Zheng <lv.zheng@linux.spacemit.com>
> >      Signed-off-by: Jingyu Li <joey.li@spacemit.com>
> > 
> > In both cases, you need to change the order of signoffs so that yours is
> > last as the submitter.
> 
> BTW, since this version of this patch has been worked out all due your
> constructive feedback and suggestions. Now that it has functionally
> converged to what the community requested, can I add "Reviewed-by: Conor
> Dooley <conor@kernel.org>" for its next version?

No, as I said the previous time you asked, I will provide one when I am
happy with the patch. I have not yet reached a point with you were I am
comfortable providing tags with the assumption that you will make the
correct changes. There's no need to hassle me for one at this point
anyway, because you have to send a v6 anyway. If v6 is satisfactory to
the maintainers, they'll grab my tag when they apply the series.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]