public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	 Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: [PATCH v1] perf ftrace: Proper error clean up in print_profile_result
Date: Fri,  6 Mar 2026 10:50:22 -0800	[thread overview]
Message-ID: <20260306185022.2016541-1-irogers@google.com> (raw)

The ftrace profile_hash is cleaned up on success but not on memory
allocation and empty paths. Fix by running the clean up for all. Free
the profile too, so make it NULL, just for clarity that this is all
clean up code.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/builtin-ftrace.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 6b6eec65f93f..19e796e58fb0 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -18,6 +18,7 @@
 #include <poll.h>
 #include <ctype.h>
 #include <linux/capability.h>
+#include <linux/err.h>
 #include <linux/string.h>
 #include <sys/stat.h>
 
@@ -1369,17 +1370,17 @@ static int cmp_profile_data(const void *a, const void *b)
 
 static void print_profile_result(struct perf_ftrace *ftrace)
 {
-	struct hashmap_entry *entry, **profile;
+	struct hashmap_entry *entry, **profile = NULL;
 	size_t i, nr, bkt;
 
 	nr = hashmap__size(ftrace->profile_hash);
 	if (nr == 0)
-		return;
+		goto out;
 
 	profile = calloc(nr, sizeof(*profile));
 	if (profile == NULL) {
 		pr_err("failed to allocate memory for the result\n");
-		return;
+		goto out;
 	}
 
 	i = 0;
@@ -1403,6 +1404,7 @@ static void print_profile_result(struct perf_ftrace *ftrace)
 		       p->st.max / 1000, p->st.max % 1000, p->st.n, name);
 	}
 
+out:
 	free(profile);
 
 	hashmap__for_each_entry(ftrace->profile_hash, entry, bkt) {
-- 
2.53.0.473.g4a7958ca14-goog


             reply	other threads:[~2026-03-06 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 18:50 Ian Rogers [this message]
2026-03-21  2:50 ` [PATCH v1] perf ftrace: Proper error clean up in print_profile_result Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306185022.2016541-1-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox