public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Ian Rogers" <irogers@google.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	"James Clark" <james.clark@linaro.org>,
	"Kees Cook" <kees@kernel.org>, "Quentin Monnet" <qmo@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Song Liu" <song@kernel.org>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"William Breathitt Gray" <wbg@kernel.org>,
	"Barry Song" <baohua@kernel.org>,
	"Qinxin Xia" <xiaqinxin@huawei.com>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Kent Gibson" <warthog618@gmail.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>,
	"Dexuan Cui" <decui@microsoft.com>,
	"Long Li" <longli@microsoft.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Willy Tarreau" <w@1wt.eu>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Josh Poimboeuf" <jpoimboe@kernel.org>,
	"Robert Moore" <robert.moore@intel.com>,
	"Len Brown" <lenb@kernel.org>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Tejun Heo" <tj@kernel.org>, "David Vernet" <void@manifault.com>,
	"Andrea Righi" <arighi@nvidia.com>,
	"Changwoo Min" <changwoo@igalia.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Gabriele Monaco" <gmonaco@redhat.com>,
	"Shuah Khan" <shuah@kernel.org>, "Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <bentiss@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	 llvm@lists.linux.dev, bpf@vger.kernel.org,
	linux-perf-users@vger.kernel.org,  Leo Yan <leo.yan@arm.com>
Subject: [PATCH v3 02/30] libbpf: Initialize CFLAGS before including Makefile.include
Date: Sun, 08 Mar 2026 16:46:07 +0000	[thread overview]
Message-ID: <20260308-tools_build_fix_zero_init-v3-2-6477808123b7@arm.com> (raw)
In-Reply-To: <20260308-tools_build_fix_zero_init-v3-0-6477808123b7@arm.com>

Initialize CFLAGS to the default value before including
tools/scripts/Makefile.include.

Defer appending EXTRA_CFLAGS to CFLAGS until after including
Makefile.include, as it may extend EXTRA_CFLAGS in the future.

Signed-off-by: Leo Yan <leo.yan@arm.com>
---
 tools/lib/bpf/Makefile | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index 168140f8e6461bd06db40e23d21a3fb8847ccbf4..76cc802375f67b9d8f589904bd9764040947e5dd 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -49,6 +49,14 @@ man_dir_SQ = '$(subst ','\'',$(man_dir))'
 export man_dir man_dir_SQ INSTALL
 export DESTDIR DESTDIR_SQ
 
+# Defer assigning EXTRA_CFLAGS to CFLAGS until after including
+# tools/scripts/Makefile.include, as it may add flags to EXTRA_CFLAGS.
+ifdef EXTRA_CFLAGS
+  CFLAGS :=
+else
+  CFLAGS := -g -O2
+endif
+
 include $(srctree)/tools/scripts/Makefile.include
 
 # copy a bit from Linux kbuild
@@ -70,14 +78,8 @@ LIB_TARGET	= libbpf.a libbpf.so.$(LIBBPF_VERSION)
 LIB_FILE	= libbpf.a libbpf.so*
 PC_FILE		= libbpf.pc
 
-# Set compile option CFLAGS
-ifdef EXTRA_CFLAGS
-  CFLAGS := $(EXTRA_CFLAGS)
-else
-  CFLAGS := -g -O2
-endif
-
 # Append required CFLAGS
+override CFLAGS += $(EXTRA_CFLAGS)
 override CFLAGS += -std=gnu89
 override CFLAGS += $(EXTRA_WARNINGS) -Wno-switch-enum
 override CFLAGS += -Werror -Wall

-- 
2.34.1


  parent reply	other threads:[~2026-03-08 16:46 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 16:46 [PATCH v3 00/30] tools build: Append -fzero-init-padding-bits=all option Leo Yan
2026-03-08 16:46 ` [PATCH v3 01/30] bpftool: Avoid adding EXTRA_CFLAGS to HOST_CFLAGS Leo Yan
2026-03-09 10:17   ` Quentin Monnet
2026-03-09 17:40   ` Ian Rogers
2026-03-09 17:51     ` Quentin Monnet
2026-03-08 16:46 ` Leo Yan [this message]
2026-03-09 17:03   ` [PATCH v3 02/30] libbpf: Initialize CFLAGS before including Makefile.include Ian Rogers
2026-03-08 16:46 ` [PATCH v3 03/30] tools: lib: thermal: " Leo Yan
2026-03-09 15:10   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 04/30] tools/thermal: " Leo Yan
2026-03-09  8:41   ` Daniel Lezcano
2026-03-09 10:07     ` Leo Yan
2026-03-10 12:00       ` Daniel Lezcano
2026-03-08 16:46 ` [PATCH v3 05/30] tools build: Append -fzero-init-padding-bits=all to extra cflags Leo Yan
2026-03-09 10:17   ` Quentin Monnet
2026-03-09 17:17   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 06/30] bpftool: Append extra host flags Leo Yan
2026-03-09 10:17   ` Quentin Monnet
2026-03-08 16:46 ` [PATCH v3 07/30] perf build: " Leo Yan
2026-03-08 16:46 ` [PATCH v3 08/30] tools/bpf: build: Append extra cflags Leo Yan
2026-03-09 17:42   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 09/30] tools build: Append extra host cflags Leo Yan
2026-03-08 16:46 ` [PATCH v3 10/30] tools build: Append extra cflags for feature Leo Yan
2026-03-09 17:51   ` Ian Rogers
2026-03-10 14:25     ` Leo Yan
2026-03-08 16:46 ` [PATCH v3 11/30] tools: bootconfig: Append extra cflags Leo Yan
2026-03-09 12:22   ` Masami Hiramatsu
2026-03-09 17:53   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 12/30] tools: counter: " Leo Yan
2026-03-09 17:55   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 13/30] tools: dma: " Leo Yan
2026-03-09 12:08   ` Qinxin Xia
2026-03-09 17:56   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 14/30] tools: gpio: " Leo Yan
2026-03-09  8:54   ` Bartosz Golaszewski
2026-03-09 17:57   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 15/30] tools: hv: " Leo Yan
2026-03-08 20:28   ` [EXTERNAL] " Haiyang Zhang
2026-03-09 17:58   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 16/30] tools: iio: " Leo Yan
2026-03-09 17:58   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 17/30] tools: mm: " Leo Yan
2026-03-09 17:59   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 18/30] tools: nolibc: " Leo Yan
2026-03-09 22:20   ` Thomas Weißschuh
2026-03-08 16:46 ` [PATCH v3 19/30] tools: objtool: Append extra host cflags Leo Yan
2026-03-09 20:19   ` Josh Poimboeuf
2026-03-08 16:46 ` [PATCH v3 20/30] tools: power: acpi: Append extra cflags Leo Yan
2026-03-09 18:01   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 21/30] tools: power: x86/intel-speed-select: " Leo Yan
2026-03-09 15:59   ` srinivas pandruvada
2026-03-09 18:02   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 22/30] tools: sched_ext: " Leo Yan
2026-03-09 18:07   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 23/30] tools: spi: " Leo Yan
2026-03-08 23:21   ` Mark Brown
2026-03-09 18:03   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 24/30] tools: tracing: " Leo Yan
2026-03-09 15:44   ` Steven Rostedt
2026-03-09 16:37     ` Ian Rogers
2026-03-10 11:48       ` Leo Yan
2026-03-08 16:46 ` [PATCH v3 25/30] tools: usb: " Leo Yan
2026-03-09 18:04   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 26/30] tools: verification: " Leo Yan
2026-03-09  6:26   ` Gabriele Monaco
2026-03-10 15:58     ` Leo Yan
2026-03-08 16:46 ` [PATCH v3 27/30] selftests/bpf: " Leo Yan
2026-03-09 18:05   ` Ian Rogers
2026-03-10 17:50   ` Leo Yan
2026-03-08 16:46 ` [PATCH v3 28/30] selftests/hid: " Leo Yan
2026-03-09 18:06   ` Ian Rogers
2026-03-08 16:46 ` [PATCH v3 29/30] selftests/nolibc: " Leo Yan
2026-03-09 22:24   ` Thomas Weißschuh
2026-03-10 16:06     ` Leo Yan
2026-03-08 16:46 ` [PATCH v3 30/30] selftests/sched_ext: " Leo Yan
2026-03-09 12:45   ` Andrea Righi
2026-03-09 18:02   ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260308-tools_build_fix_zero_init-v3-2-6477808123b7@arm.com \
    --to=leo.yan@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andrii@kernel.org \
    --cc=andy@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=ast@kernel.org \
    --cc=baohua@kernel.org \
    --cc=bentiss@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=changwoo@igalia.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=decui@microsoft.com \
    --cc=dlechner@baylibre.com \
    --cc=eddyz87@gmail.com \
    --cc=gmonaco@redhat.com \
    --cc=haiyangz@microsoft.com \
    --cc=haoluo@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=justinstitt@google.com \
    --cc=kees@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kys@microsoft.com \
    --cc=lenb@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=llvm@lists.linux.dev \
    --cc=longli@microsoft.com \
    --cc=lukasz.luba@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=martin.lau@linux.dev \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=namhyung@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=nsc@kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=peterz@infradead.org \
    --cc=qmo@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    --cc=w@1wt.eu \
    --cc=warthog618@gmail.com \
    --cc=wbg@kernel.org \
    --cc=wei.liu@kernel.org \
    --cc=xiaqinxin@huawei.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox