From: Ian Rogers <irogers@google.com>
To: irogers@google.com
Cc: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org,
jolsa@kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, mingo@kernel.org,
namhyung@kernel.org, peterz@infradead.org
Subject: [RFC PATCH v1] perf test: Fix perf stat --bpf-counters on hybrid machines
Date: Mon, 23 Mar 2026 13:24:09 -0700 [thread overview]
Message-ID: <20260323202409.194123-1-irogers@google.com> (raw)
In-Reply-To: <CAP-5=fW5Cx-a0hm_PKNLDSmo=L0xu=LizKiAPyJF1YtH-coFdg@mail.gmail.com>
Events on hardware PMUs may open on >1 hardware PMU on hybrid
machines. Unfortunately multiplexing introduces a scaling issue as
reported in:
https://lore.kernel.org/lkml/20250716223924.825772-1-irogers@google.com/
Switch to using task-clock which as a software event runs on all CPUs
and has a single PMU.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/stat_bpf_counters.sh | 35 +++++++++++----------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/tools/perf/tests/shell/stat_bpf_counters.sh b/tools/perf/tests/shell/stat_bpf_counters.sh
index f43e28a136d3..58f7dc9692ac 100755
--- a/tools/perf/tests/shell/stat_bpf_counters.sh
+++ b/tools/perf/tests/shell/stat_bpf_counters.sh
@@ -5,6 +5,7 @@
set -e
workload="perf test -w sqrtloop"
+event=task-clock
# check whether $2 is within +/- 20% of $1
compare_number()
@@ -25,15 +26,15 @@ compare_number()
check_counts()
{
- base_instructions=$1
- bpf_instructions=$2
+ base_count=$(echo "$1"|sed -e 's/[^0-9]*\([0-9]*\).*/\1/')
+ bpf_count=$(echo "$2"|sed -e 's/[^0-9]*\([0-9]*\).*/\1/')
- if [ "$base_instructions" = "<not" ]; then
- echo "Skipping: instructions event not counted"
+ if [ "$base_count" = "<not" ]; then
+ echo "Skipping: $event event not counted"
exit 2
fi
- if [ "$bpf_instructions" = "<not" ]; then
- echo "Failed: instructions not counted with --bpf-counters"
+ if [ "$bpf_count" = "<not" ]; then
+ echo "Failed: $event not counted with --bpf-counters"
exit 1
fi
}
@@ -41,29 +42,29 @@ check_counts()
test_bpf_counters()
{
printf "Testing --bpf-counters "
- base_instructions=$(perf stat --no-big-num -e instructions -- $workload 2>&1 | awk '/instructions/ {print $1}')
- bpf_instructions=$(perf stat --no-big-num --bpf-counters -e instructions -- $workload 2>&1 | awk '/instructions/ {print $1}')
- check_counts $base_instructions $bpf_instructions
- compare_number $base_instructions $bpf_instructions
+ base_count=$(perf stat --no-big-num -e "$event" -- $workload 2>&1 | awk "/$event/ {print \$1}")
+ bpf_count=$(perf stat --no-big-num --bpf-counters -e "$event" -- $workload 2>&1 | awk "/$event/ {print \$1}")
+ check_counts "$base_count" "$bpf_count"
+ compare_number "$base_count" "$bpf_count"
echo "[Success]"
}
test_bpf_modifier()
{
printf "Testing bpf event modifier "
- stat_output=$(perf stat --no-big-num -e instructions/name=base_instructions/,instructions/name=bpf_instructions/b -- $workload 2>&1)
- base_instructions=$(echo "$stat_output"| awk '/base_instructions/ {print $1}')
- bpf_instructions=$(echo "$stat_output"| awk '/bpf_instructions/ {print $1}')
- check_counts $base_instructions $bpf_instructions
- compare_number $base_instructions $bpf_instructions
+ stat_output=$(perf stat --no-big-num -e "$event/name=base_$event/,$event/name=bpf_$event/b" -- $workload 2>&1)
+ base_count=$(echo "$stat_output"| awk "/base_$event/ {print \$1}")
+ bpf_count=$(echo "$stat_output"| awk "/bpf_$event/ {print \$1}")
+ check_counts "$base_count" "$bpf_count"
+ compare_number "$base_count" "$bpf_count"
echo "[Success]"
}
# skip if --bpf-counters is not supported
-if ! perf stat -e instructions --bpf-counters true > /dev/null 2>&1; then
+if ! perf stat -e $event --bpf-counters true > /dev/null 2>&1; then
if [ "$1" = "-v" ]; then
echo "Skipping: --bpf-counters not supported"
- perf --no-pager stat -e instructions --bpf-counters true || true
+ perf --no-pager stat -e $event --bpf-counters true || true
fi
exit 2
fi
--
2.53.0.1018.g2bb0e51243-goog
next prev parent reply other threads:[~2026-03-23 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 6:45 [PATCH v3] perf test: Fix perf stat --bpf-counters on hybrid machines Namhyung Kim
2026-03-22 22:05 ` Arnaldo Carvalho de Melo
2026-03-23 20:15 ` Ian Rogers
2026-03-23 20:24 ` Ian Rogers [this message]
2026-03-23 20:26 ` [RFC PATCH v1] " Ian Rogers
2026-03-25 7:04 ` Namhyung Kim
2026-03-25 17:16 ` [PATCH v2] " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323202409.194123-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox