* [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include
@ 2026-03-31 21:06 Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-03-31 21:06 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ingo Molnar, Thomas Gleixner, James Clark, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
Since those are not used to build any tool in tools/, move them to the
directory where we just track for changes and use those headers just to
scrape defines and turn them into id->string tables used by 'perf
trace' (or any other tool in the future).
Best Regards,
- Arnaldo
Arnaldo Carvalho de Melo (2):
tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi
perf beauty: Move copy of fadvise.h from tools/include/ to tools/perf/trace/beauty/include/
tools/perf/Makefile.perf | 6 +++---
tools/perf/check-headers.sh | 6 +++---
tools/perf/trace/beauty/drm_ioctl.sh | 2 +-
tools/perf/trace/beauty/fadvise.sh | 2 +-
tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h | 0
tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h | 0
tools/{ => perf/trace/beauty}/include/uapi/linux/fadvise.h | 0
7 files changed, 8 insertions(+), 8 deletions(-)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h (100%)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h (100%)
rename tools/{ => perf/trace/beauty}/include/uapi/linux/fadvise.h (100%)
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi
2026-03-31 21:06 [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Arnaldo Carvalho de Melo
@ 2026-03-31 21:06 ` Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 2/2] perf beauty: Move copy of fadvise.h from tools/include/ to tools/perf/trace/beauty/include/ Arnaldo Carvalho de Melo
2026-04-01 21:52 ` [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Namhyung Kim
2 siblings, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-03-31 21:06 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ingo Molnar, Thomas Gleixner, James Clark, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@redhat.com>
As it is used only to parse ioctl numbers, not to build perf and so far
no other tools/ living tool uses it, so to clean up tools/include/ to be
used just for building tools, to have access to things available in the
kernel and not yet in the system headers, move it to the directory where
just the tools/perf/trace/beauty/ scripts can use to generate tables
used by perf.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 2 +-
| 4 ++--
tools/perf/trace/beauty/drm_ioctl.sh | 2 +-
tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h | 0
tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h | 0
5 files changed, 4 insertions(+), 4 deletions(-)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h (100%)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h (100%)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index f7b936deeaa2cd7c..a560fbc847934fad 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -547,7 +547,7 @@ $(clone_flags_array): $(beauty_uapi_linux_dir)/sched.h $(clone_flags_tbl)
$(Q)$(SHELL) '$(clone_flags_tbl)' $(beauty_uapi_linux_dir) > $@
drm_ioctl_array := $(beauty_ioctl_outdir)/drm_ioctl_array.c
-drm_hdr_dir := $(srctree)/tools/include/uapi/drm
+drm_hdr_dir := $(srctree)/tools/perf/trace/beauty/include/uapi/drm
drm_ioctl_tbl := $(srctree)/tools/perf/trace/beauty/drm_ioctl.sh
$(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_tbl)
--git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index 31826621eebdb003..c6b136fe8d13053d 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -6,8 +6,6 @@ NC='\033[0m' # No Color
declare -a FILES=(
"include/uapi/linux/const.h"
- "include/uapi/drm/drm.h"
- "include/uapi/drm/i915_drm.h"
"include/uapi/linux/bits.h"
"include/uapi/linux/fadvise.h"
"include/uapi/linux/fscrypt.h"
@@ -90,6 +88,8 @@ declare -a SYNC_CHECK_FILES=(
declare -a BEAUTY_FILES=(
"arch/x86/include/asm/irq_vectors.h"
"arch/x86/include/uapi/asm/prctl.h"
+ "include/uapi/drm/drm.h"
+ "include/uapi/drm/i915_drm.h"
"include/linux/socket.h"
"include/uapi/linux/fcntl.h"
"include/uapi/linux/fs.h"
diff --git a/tools/perf/trace/beauty/drm_ioctl.sh b/tools/perf/trace/beauty/drm_ioctl.sh
index 9aa94fd523a9c2dd..f2f1a257bac8b41e 100755
--- a/tools/perf/trace/beauty/drm_ioctl.sh
+++ b/tools/perf/trace/beauty/drm_ioctl.sh
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: LGPL-2.1
-[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/include/uapi/drm/
+[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/perf/trace/beauty/include/uapi/drm/
printf "#ifndef DRM_COMMAND_BASE\n"
grep "#define DRM_COMMAND_BASE" $header_dir/drm.h
diff --git a/tools/include/uapi/drm/drm.h b/tools/perf/trace/beauty/include/uapi/drm/drm.h
similarity index 100%
rename from tools/include/uapi/drm/drm.h
rename to tools/perf/trace/beauty/include/uapi/drm/drm.h
diff --git a/tools/include/uapi/drm/i915_drm.h b/tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
similarity index 100%
rename from tools/include/uapi/drm/i915_drm.h
rename to tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] perf beauty: Move copy of fadvise.h from tools/include/ to tools/perf/trace/beauty/include/
2026-03-31 21:06 [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
@ 2026-03-31 21:06 ` Arnaldo Carvalho de Melo
2026-04-01 21:52 ` [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Namhyung Kim
2 siblings, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-03-31 21:06 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ingo Molnar, Thomas Gleixner, James Clark, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@redhat.com>
As it is not really used when compiling anything, just being parsed to
collect number->string tables for 'perf trace'.
$ git grep fadvise.h tools/
tools/perf/Makefile.perf:$(fadvise_advice_array): $(beauty_uapi_linux_dir)/fadvise.h $(fadvise_advice_tbl)
tools/perf/check-headers.sh: "include/uapi/linux/fadvise.h"
tools/perf/trace/beauty/fadvise.sh:grep -E $regex ${header_dir}/fadvise.h | \
tools/perf/trace/beauty/fadvise.sh:# tools/include/uapi/linux/fadvise.h for details.
$
Link: https://lore.kernel.org/r/CAP-5=fVBNQVF8k3JUQjH1nkP69ZVp8BqP+uwygcx=xO0zC4xrg@mail.gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 4 ++--
| 2 +-
tools/perf/trace/beauty/fadvise.sh | 2 +-
tools/{ => perf/trace/beauty}/include/uapi/linux/fadvise.h | 0
4 files changed, 4 insertions(+), 4 deletions(-)
rename tools/{ => perf/trace/beauty}/include/uapi/linux/fadvise.h (100%)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index a560fbc847934fad..cee19c923c0607d2 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -556,8 +556,8 @@ $(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_t
fadvise_advice_array := $(beauty_outdir)/fadvise_advice_array.c
fadvise_advice_tbl := $(srctree)/tools/perf/trace/beauty/fadvise.sh
-$(fadvise_advice_array): $(linux_uapi_dir)/in.h $(fadvise_advice_tbl)
- $(Q)$(SHELL) '$(fadvise_advice_tbl)' $(linux_uapi_dir) > $@
+$(fadvise_advice_array): $(beauty_uapi_linux_dir)/fadvise.h $(fadvise_advice_tbl)
+ $(Q)$(SHELL) '$(fadvise_advice_tbl)' $(beauty_uapi_linux_dir) > $@
fsmount_arrays := $(beauty_outdir)/fsmount_arrays.c
fsmount_tbls := $(srctree)/tools/perf/trace/beauty/fsmount.sh
--git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index c6b136fe8d13053d..531c0e0e84dfa101 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -7,7 +7,6 @@ NC='\033[0m' # No Color
declare -a FILES=(
"include/uapi/linux/const.h"
"include/uapi/linux/bits.h"
- "include/uapi/linux/fadvise.h"
"include/uapi/linux/fscrypt.h"
"include/uapi/linux/genetlink.h"
"include/uapi/linux/if_addr.h"
@@ -91,6 +90,7 @@ declare -a BEAUTY_FILES=(
"include/uapi/drm/drm.h"
"include/uapi/drm/i915_drm.h"
"include/linux/socket.h"
+ "include/uapi/linux/fadvise.h"
"include/uapi/linux/fcntl.h"
"include/uapi/linux/fs.h"
"include/uapi/linux/mount.h"
diff --git a/tools/perf/trace/beauty/fadvise.sh b/tools/perf/trace/beauty/fadvise.sh
index 4d3dd6e56dedc994..e9857112fa51e8e2 100755
--- a/tools/perf/trace/beauty/fadvise.sh
+++ b/tools/perf/trace/beauty/fadvise.sh
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: LGPL-2.1
-[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/include/uapi/linux/
+[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/perf/trace/beauty/include/uapi/linux/
printf "static const char *fadvise_advices[] = {\n"
regex='^[[:space:]]*#[[:space:]]*define[[:space:]]+POSIX_FADV_(\w+)[[:space:]]+([[:digit:]]+)[[:space:]]+.*'
diff --git a/tools/include/uapi/linux/fadvise.h b/tools/perf/trace/beauty/include/uapi/linux/fadvise.h
similarity index 100%
rename from tools/include/uapi/linux/fadvise.h
rename to tools/perf/trace/beauty/include/uapi/linux/fadvise.h
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi
2026-04-01 21:01 [PATCHES perf-tools-next 0/4] Cleanups and a fix Arnaldo Carvalho de Melo
@ 2026-04-01 21:01 ` Arnaldo Carvalho de Melo
2026-04-01 21:22 ` Ian Rogers
0 siblings, 1 reply; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-04-01 21:01 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ingo Molnar, Thomas Gleixner, James Clark, Jiri Olsa, Ian Rogers,
Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo <acme@redhat.com>
As it is used only to parse ioctl numbers, not to build perf and so far
no other tools/ living tool uses it, so to clean up tools/include/ to be
used just for building tools, to have access to things available in the
kernel and not yet in the system headers, move it to the directory where
just the tools/perf/trace/beauty/ scripts can use to generate tables
used by perf.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.perf | 2 +-
| 4 ++--
tools/perf/trace/beauty/drm_ioctl.sh | 2 +-
tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h | 0
tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h | 0
5 files changed, 4 insertions(+), 4 deletions(-)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h (100%)
rename tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h (100%)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index f7b936deeaa2cd7c..a560fbc847934fad 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -547,7 +547,7 @@ $(clone_flags_array): $(beauty_uapi_linux_dir)/sched.h $(clone_flags_tbl)
$(Q)$(SHELL) '$(clone_flags_tbl)' $(beauty_uapi_linux_dir) > $@
drm_ioctl_array := $(beauty_ioctl_outdir)/drm_ioctl_array.c
-drm_hdr_dir := $(srctree)/tools/include/uapi/drm
+drm_hdr_dir := $(srctree)/tools/perf/trace/beauty/include/uapi/drm
drm_ioctl_tbl := $(srctree)/tools/perf/trace/beauty/drm_ioctl.sh
$(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_tbl)
--git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index 31826621eebdb003..c6b136fe8d13053d 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -6,8 +6,6 @@ NC='\033[0m' # No Color
declare -a FILES=(
"include/uapi/linux/const.h"
- "include/uapi/drm/drm.h"
- "include/uapi/drm/i915_drm.h"
"include/uapi/linux/bits.h"
"include/uapi/linux/fadvise.h"
"include/uapi/linux/fscrypt.h"
@@ -90,6 +88,8 @@ declare -a SYNC_CHECK_FILES=(
declare -a BEAUTY_FILES=(
"arch/x86/include/asm/irq_vectors.h"
"arch/x86/include/uapi/asm/prctl.h"
+ "include/uapi/drm/drm.h"
+ "include/uapi/drm/i915_drm.h"
"include/linux/socket.h"
"include/uapi/linux/fcntl.h"
"include/uapi/linux/fs.h"
diff --git a/tools/perf/trace/beauty/drm_ioctl.sh b/tools/perf/trace/beauty/drm_ioctl.sh
index 9aa94fd523a9c2dd..f2f1a257bac8b41e 100755
--- a/tools/perf/trace/beauty/drm_ioctl.sh
+++ b/tools/perf/trace/beauty/drm_ioctl.sh
@@ -1,7 +1,7 @@
#!/bin/sh
# SPDX-License-Identifier: LGPL-2.1
-[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/include/uapi/drm/
+[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/perf/trace/beauty/include/uapi/drm/
printf "#ifndef DRM_COMMAND_BASE\n"
grep "#define DRM_COMMAND_BASE" $header_dir/drm.h
diff --git a/tools/include/uapi/drm/drm.h b/tools/perf/trace/beauty/include/uapi/drm/drm.h
similarity index 100%
rename from tools/include/uapi/drm/drm.h
rename to tools/perf/trace/beauty/include/uapi/drm/drm.h
diff --git a/tools/include/uapi/drm/i915_drm.h b/tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
similarity index 100%
rename from tools/include/uapi/drm/i915_drm.h
rename to tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi
2026-04-01 21:01 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
@ 2026-04-01 21:22 ` Ian Rogers
2026-04-01 21:49 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 7+ messages in thread
From: Ian Rogers @ 2026-04-01 21:22 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Namhyung Kim, Ingo Molnar, Thomas Gleixner, James Clark,
Jiri Olsa, Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
On Wed, Apr 1, 2026 at 2:02 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> As it is used only to parse ioctl numbers, not to build perf and so far
> no other tools/ living tool uses it, so to clean up tools/include/ to be
> used just for building tools, to have access to things available in the
> kernel and not yet in the system headers, move it to the directory where
> just the tools/perf/trace/beauty/ scripts can use to generate tables
> used by perf.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
The moving headers changes I think have been incorporated into your
clean up series. For the moving headers:
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/Makefile.perf | 2 +-
> tools/perf/check-headers.sh | 4 ++--
> tools/perf/trace/beauty/drm_ioctl.sh | 2 +-
> tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h | 0
> tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h | 0
> 5 files changed, 4 insertions(+), 4 deletions(-)
> rename tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h (100%)
> rename tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h (100%)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index f7b936deeaa2cd7c..a560fbc847934fad 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -547,7 +547,7 @@ $(clone_flags_array): $(beauty_uapi_linux_dir)/sched.h $(clone_flags_tbl)
> $(Q)$(SHELL) '$(clone_flags_tbl)' $(beauty_uapi_linux_dir) > $@
>
> drm_ioctl_array := $(beauty_ioctl_outdir)/drm_ioctl_array.c
> -drm_hdr_dir := $(srctree)/tools/include/uapi/drm
> +drm_hdr_dir := $(srctree)/tools/perf/trace/beauty/include/uapi/drm
> drm_ioctl_tbl := $(srctree)/tools/perf/trace/beauty/drm_ioctl.sh
>
> $(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_tbl)
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index 31826621eebdb003..c6b136fe8d13053d 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -6,8 +6,6 @@ NC='\033[0m' # No Color
>
> declare -a FILES=(
> "include/uapi/linux/const.h"
> - "include/uapi/drm/drm.h"
> - "include/uapi/drm/i915_drm.h"
> "include/uapi/linux/bits.h"
> "include/uapi/linux/fadvise.h"
> "include/uapi/linux/fscrypt.h"
> @@ -90,6 +88,8 @@ declare -a SYNC_CHECK_FILES=(
> declare -a BEAUTY_FILES=(
> "arch/x86/include/asm/irq_vectors.h"
> "arch/x86/include/uapi/asm/prctl.h"
> + "include/uapi/drm/drm.h"
> + "include/uapi/drm/i915_drm.h"
> "include/linux/socket.h"
> "include/uapi/linux/fcntl.h"
> "include/uapi/linux/fs.h"
> diff --git a/tools/perf/trace/beauty/drm_ioctl.sh b/tools/perf/trace/beauty/drm_ioctl.sh
> index 9aa94fd523a9c2dd..f2f1a257bac8b41e 100755
> --- a/tools/perf/trace/beauty/drm_ioctl.sh
> +++ b/tools/perf/trace/beauty/drm_ioctl.sh
> @@ -1,7 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: LGPL-2.1
>
> -[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/include/uapi/drm/
> +[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/perf/trace/beauty/include/uapi/drm/
>
> printf "#ifndef DRM_COMMAND_BASE\n"
> grep "#define DRM_COMMAND_BASE" $header_dir/drm.h
> diff --git a/tools/include/uapi/drm/drm.h b/tools/perf/trace/beauty/include/uapi/drm/drm.h
> similarity index 100%
> rename from tools/include/uapi/drm/drm.h
> rename to tools/perf/trace/beauty/include/uapi/drm/drm.h
> diff --git a/tools/include/uapi/drm/i915_drm.h b/tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
> similarity index 100%
> rename from tools/include/uapi/drm/i915_drm.h
> rename to tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi
2026-04-01 21:22 ` Ian Rogers
@ 2026-04-01 21:49 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-04-01 21:49 UTC (permalink / raw)
To: Ian Rogers
Cc: Namhyung Kim, Ingo Molnar, Thomas Gleixner, James Clark,
Jiri Olsa, Adrian Hunter, Kan Liang, Clark Williams, linux-kernel,
linux-perf-users, Arnaldo Carvalho de Melo
On Wed, Apr 01, 2026 at 02:22:44PM -0700, Ian Rogers wrote:
> On Wed, Apr 1, 2026 at 2:02 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > As it is used only to parse ioctl numbers, not to build perf and so far
> > no other tools/ living tool uses it, so to clean up tools/include/ to be
> > used just for building tools, to have access to things available in the
> > kernel and not yet in the system headers, move it to the directory where
> > just the tools/perf/trace/beauty/ scripts can use to generate tables
> > used by perf.
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> The moving headers changes I think have been incorporated into your
> clean up series. For the moving headers:
>
> Reviewed-by: Ian Rogers <irogers@google.com>
I see, I didn't cleanup the 000*.patch files from a previous pull req
:-\ So ended up resending them.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/Makefile.perf | 2 +-
> > tools/perf/check-headers.sh | 4 ++--
> > tools/perf/trace/beauty/drm_ioctl.sh | 2 +-
> > tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h | 0
> > tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h | 0
> > 5 files changed, 4 insertions(+), 4 deletions(-)
> > rename tools/{ => perf/trace/beauty}/include/uapi/drm/drm.h (100%)
> > rename tools/{ => perf/trace/beauty}/include/uapi/drm/i915_drm.h (100%)
> >
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index f7b936deeaa2cd7c..a560fbc847934fad 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -547,7 +547,7 @@ $(clone_flags_array): $(beauty_uapi_linux_dir)/sched.h $(clone_flags_tbl)
> > $(Q)$(SHELL) '$(clone_flags_tbl)' $(beauty_uapi_linux_dir) > $@
> >
> > drm_ioctl_array := $(beauty_ioctl_outdir)/drm_ioctl_array.c
> > -drm_hdr_dir := $(srctree)/tools/include/uapi/drm
> > +drm_hdr_dir := $(srctree)/tools/perf/trace/beauty/include/uapi/drm
> > drm_ioctl_tbl := $(srctree)/tools/perf/trace/beauty/drm_ioctl.sh
> >
> > $(drm_ioctl_array): $(drm_hdr_dir)/drm.h $(drm_hdr_dir)/i915_drm.h $(drm_ioctl_tbl)
> > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> > index 31826621eebdb003..c6b136fe8d13053d 100755
> > --- a/tools/perf/check-headers.sh
> > +++ b/tools/perf/check-headers.sh
> > @@ -6,8 +6,6 @@ NC='\033[0m' # No Color
> >
> > declare -a FILES=(
> > "include/uapi/linux/const.h"
> > - "include/uapi/drm/drm.h"
> > - "include/uapi/drm/i915_drm.h"
> > "include/uapi/linux/bits.h"
> > "include/uapi/linux/fadvise.h"
> > "include/uapi/linux/fscrypt.h"
> > @@ -90,6 +88,8 @@ declare -a SYNC_CHECK_FILES=(
> > declare -a BEAUTY_FILES=(
> > "arch/x86/include/asm/irq_vectors.h"
> > "arch/x86/include/uapi/asm/prctl.h"
> > + "include/uapi/drm/drm.h"
> > + "include/uapi/drm/i915_drm.h"
> > "include/linux/socket.h"
> > "include/uapi/linux/fcntl.h"
> > "include/uapi/linux/fs.h"
> > diff --git a/tools/perf/trace/beauty/drm_ioctl.sh b/tools/perf/trace/beauty/drm_ioctl.sh
> > index 9aa94fd523a9c2dd..f2f1a257bac8b41e 100755
> > --- a/tools/perf/trace/beauty/drm_ioctl.sh
> > +++ b/tools/perf/trace/beauty/drm_ioctl.sh
> > @@ -1,7 +1,7 @@
> > #!/bin/sh
> > # SPDX-License-Identifier: LGPL-2.1
> >
> > -[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/include/uapi/drm/
> > +[ $# -eq 1 ] && header_dir=$1 || header_dir=tools/perf/trace/beauty/include/uapi/drm/
> >
> > printf "#ifndef DRM_COMMAND_BASE\n"
> > grep "#define DRM_COMMAND_BASE" $header_dir/drm.h
> > diff --git a/tools/include/uapi/drm/drm.h b/tools/perf/trace/beauty/include/uapi/drm/drm.h
> > similarity index 100%
> > rename from tools/include/uapi/drm/drm.h
> > rename to tools/perf/trace/beauty/include/uapi/drm/drm.h
> > diff --git a/tools/include/uapi/drm/i915_drm.h b/tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
> > similarity index 100%
> > rename from tools/include/uapi/drm/i915_drm.h
> > rename to tools/perf/trace/beauty/include/uapi/drm/i915_drm.h
> > --
> > 2.53.0
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include
2026-03-31 21:06 [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 2/2] perf beauty: Move copy of fadvise.h from tools/include/ to tools/perf/trace/beauty/include/ Arnaldo Carvalho de Melo
@ 2026-04-01 21:52 ` Namhyung Kim
2 siblings, 0 replies; 7+ messages in thread
From: Namhyung Kim @ 2026-04-01 21:52 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, James Clark, Jiri Olsa, Ian Rogers, Adrian Hunter,
Kan Liang, Clark Williams, linux-kernel, linux-perf-users,
Thomas Gleixner
On Tue, 31 Mar 2026 18:06:32 -0300, Arnaldo Carvalho de Melo wrote:
> Since those are not used to build any tool in tools/, move them to the
> directory where we just track for changes and use those headers just to
> scrape defines and turn them into id->string tables used by 'perf
> trace' (or any other tool in the future).
>
> Best Regards,
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-04-01 21:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-31 21:06 [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
2026-03-31 21:06 ` [PATCH 2/2] perf beauty: Move copy of fadvise.h from tools/include/ to tools/perf/trace/beauty/include/ Arnaldo Carvalho de Melo
2026-04-01 21:52 ` [PATCHES perf-tools-next 0/2] Move some headers out of tools/include/ to tools/perf/trace/beauty/include Namhyung Kim
-- strict thread matches above, loose matches on Subject: below --
2026-04-01 21:01 [PATCHES perf-tools-next 0/4] Cleanups and a fix Arnaldo Carvalho de Melo
2026-04-01 21:01 ` [PATCH 1/2] tools: Move tools/include/uapi/drm to tools/perf/trace/beauty/include/uapi Arnaldo Carvalho de Melo
2026-04-01 21:22 ` Ian Rogers
2026-04-01 21:49 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox