public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: acme@kernel.org, namhyung@kernel.org
Cc: irogers@google.com, adrian.hunter@intel.com,
	 alexander.shishkin@linux.intel.com, ashelat@redhat.com,
	ctshao@google.com,  derek.foreman@collabora.com,
	howardchu95@gmail.com, hrishikesh123s@gmail.com,
	 james.clark@linaro.org, jolsa@kernel.org,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org,
	mingo@redhat.com, peterz@infradead.org,  swapnil.sapkal@amd.com,
	thomas.falcon@intel.com
Subject: [PATCH v3 0/7] perf data/pipe handling improvements
Date: Tue, 31 Mar 2026 22:51:59 -0700	[thread overview]
Message-ID: <20260401055206.43187-1-irogers@google.com> (raw)
In-Reply-To: <20260228065953.3226283-1-irogers@google.com>

I'm looking at improving the perf data converter with files generated
in pipe mode. In pipe mode I found the feature handling for the last
feature marker was problematic. If a new feature was added then the
old marker looks like the new feature. These changes do some minor
logging and build fixes, but they also change the last feature
handling in pipe mode so that the marker is treated as a marker and
not a feature that is broken.

Two additional fixes are added in v2. The first is making ordered
events handle positive process event return values in a consistent
manner with the reader that ignores positive values. Not handling this
properly breaks with tracing data events in pipe mode. The second set
of fixes are to the perf data converter --to-ctf output where
generating the CTF events is deferred until the event desc feature or
tracing data events occur in pipe mode.

v3: Adjust comment for event setup that in pipe mode the initial one
    does nothing (Namhyung).

v2: Two additional fixes, bring back --header-only early exit
    (Namhyung) and some comment/whitespace nits.
    https://lore.kernel.org/linux-perf-users/20260228065953.3226283-1-irogers@google.com/

v1: https://lore.kernel.org/lkml/20260226013534.2028272-1-irogers@google.com/

Ian Rogers (7):
  perf clockid: Add missing include
  perf header: Add utility to convert feature number to a string
  perf session: Extra logging for failed to process events
  perf header: Refactor pipe mode end marker handling
  perf ordered-events: Event processing consistency with the regular
    reader
  perf evsel: Make unknown event names more unique
  perf data convert ctf: Pipe mode improvements

 tools/perf/builtin-annotate.c       | 11 +----
 tools/perf/builtin-report.c         | 27 +++++-------
 tools/perf/builtin-script.c         | 11 +----
 tools/perf/util/clockid.h           |  3 +-
 tools/perf/util/data-convert-bt.c   | 68 ++++++++++++++++++++++++-----
 tools/perf/util/data-convert-json.c | 12 +----
 tools/perf/util/evsel.c             |  7 +--
 tools/perf/util/header.c            | 66 ++++++++++++++++++++++------
 tools/perf/util/header.h            |  6 ++-
 tools/perf/util/intel-tpebs.c       | 11 +----
 tools/perf/util/ordered-events.c    |  2 +-
 tools/perf/util/session.c           | 28 ++++++++----
 12 files changed, 158 insertions(+), 94 deletions(-)

-- 
2.53.0.1118.gaef5881109-goog


  parent reply	other threads:[~2026-04-01  5:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  6:59 [PATCH v2 0/7] perf data/pipe handling improvements Ian Rogers
2026-02-28  6:59 ` [PATCH v2 1/7] perf clockid: Add missing include Ian Rogers
2026-02-28  6:59 ` [PATCH v2 2/7] perf header: Add utility to convert feature number to a string Ian Rogers
2026-02-28  6:59 ` [PATCH v2 3/7] perf session: Extra logging for failed to process events Ian Rogers
2026-02-28  6:59 ` [PATCH v2 4/7] perf header: Refactor pipe mode end marker handling Ian Rogers
2026-03-05  6:23   ` Namhyung Kim
2026-04-01  5:26     ` Ian Rogers
2026-02-28  6:59 ` [PATCH v2 5/7] perf ordered-events: Event processing consistency with the regular reader Ian Rogers
2026-03-05  6:27   ` Namhyung Kim
2026-04-01  5:29     ` Ian Rogers
2026-02-28  6:59 ` [PATCH v2 6/7] perf evsel: Make unknown event names more unique Ian Rogers
2026-02-28  6:59 ` [PATCH v2 7/7] perf data convert ctf: Pipe mode improvements Ian Rogers
2026-03-05  6:39   ` Namhyung Kim
2026-04-01  5:51 ` Ian Rogers [this message]
2026-04-01  5:52   ` [PATCH v3 1/7] perf clockid: Add missing include Ian Rogers
2026-04-01  5:52   ` [PATCH v3 2/7] perf header: Add utility to convert feature number to a string Ian Rogers
2026-04-01  5:52   ` [PATCH v3 3/7] perf session: Extra logging for failed to process events Ian Rogers
2026-04-01  5:52   ` [PATCH v3 4/7] perf header: Refactor pipe mode end marker handling Ian Rogers
2026-04-01  5:52   ` [PATCH v3 5/7] perf ordered-events: Event processing consistency with the regular reader Ian Rogers
2026-04-01  5:52   ` [PATCH v3 6/7] perf evsel: Make unknown event names more unique Ian Rogers
2026-04-01  5:52   ` [PATCH v3 7/7] perf data convert ctf: Pipe mode improvements Ian Rogers
2026-04-01 16:13   ` [PATCH v4 0/8] perf data/pipe handling improvements Ian Rogers
2026-04-01 16:13     ` [PATCH v4 1/8] perf clockid: Add missing include Ian Rogers
2026-04-01 16:13     ` [PATCH v4 2/8] perf header: Add utility to convert feature number to a string Ian Rogers
2026-04-01 16:13     ` [PATCH v4 3/8] perf header: Properly warn/print when libtraceevent/libbpf support is missing Ian Rogers
2026-04-01 16:13     ` [PATCH v4 4/8] perf session: Extra logging for failed to process events Ian Rogers
2026-04-01 16:13     ` [PATCH v4 5/8] perf header: Refactor pipe mode end marker handling Ian Rogers
2026-04-01 16:13     ` [PATCH v4 6/8] perf ordered-events: Event processing consistency with the regular reader Ian Rogers
2026-04-01 16:13     ` [PATCH v4 7/8] perf evsel: Make unknown event names more unique Ian Rogers
2026-04-01 16:13     ` [PATCH v4 8/8] perf data convert ctf: Pipe mode improvements Ian Rogers
2026-04-04  0:15     ` [PATCH v4 0/8] perf data/pipe handling improvements Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401055206.43187-1-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ashelat@redhat.com \
    --cc=ctshao@google.com \
    --cc=derek.foreman@collabora.com \
    --cc=howardchu95@gmail.com \
    --cc=hrishikesh123s@gmail.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=swapnil.sapkal@amd.com \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox