From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 1/6] perf symbols: Make variable receiving result strrchr() const
Date: Tue, 7 Apr 2026 16:51:40 -0300 [thread overview]
Message-ID: <20260407195145.2372104-2-acme@kernel.org> (raw)
In-Reply-To: <20260407195145.2372104-1-acme@kernel.org>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Fixing:
util/symbol.c: In function ‘symbol__config_symfs’:
util/symbol.c:2499:20: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
2499 | layout_str = strrchr(dir, ',');
|
With recent gcc/glibc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index b4b30675688dbda5..708375d67b85fd1f 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -2492,7 +2492,7 @@ int symbol__config_symfs(const struct option *opt __maybe_unused,
const char *dir, int unset __maybe_unused)
{
char *bf = NULL;
- char *layout_str;
+ const char *layout_str;
char *dir_copy;
int ret;
--
2.53.0
next prev parent reply other threads:[~2026-04-07 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 19:51 [PATCHES perf-tools-next v4 0/6] Cleanups and fixes Arnaldo Carvalho de Melo
2026-04-07 19:51 ` Arnaldo Carvalho de Melo [this message]
2026-04-07 19:51 ` [PATCH 2/6] perf tools: Make more global variables static Arnaldo Carvalho de Melo
2026-04-07 19:51 ` [PATCH 3/6] perf bench: Constify tables Arnaldo Carvalho de Melo
2026-04-07 19:51 ` [PATCH 4/6] perf tools: Use calloc() were applicable Arnaldo Carvalho de Melo
2026-04-07 20:39 ` Arnaldo Carvalho de Melo
2026-04-07 19:51 ` [PATCH 5/6] perf tools: Replace basename() calls with perf_basename() Arnaldo Carvalho de Melo
2026-04-07 19:51 ` [PATCH 6/6] perf util: Kill die() prototype, dead for a long time Arnaldo Carvalho de Melo
2026-04-07 20:15 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407195145.2372104-2-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox