Re: [PATCH 6/6] perf util: Kill die() prototype, dead for a long time

Ian Rogers
2026-04-07T20:16:02Z

On Tue, Apr 7, 2026 at 12:52 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> In fef2a735167a827a ("perf tools: Kill die()") the die() function was
> removed, but not the prototype in util.h, now when building with
> LIBPERL=1, during a 'make -C tools/perf build-test' routine test, it is
> failing as perl likes die() calls and then this clashes with this
> remnant, remove it.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

You could add:
Fixes: fef2a735167a827a ("perf tools: Kill die()")

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/util.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 8d32bc8895c9fe4b..87a0818a8c765c45 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -30,7 +30,6 @@ extern bool perf_guest;
>
> /* General helper functions */
> void usage(const char *err) __noreturn;
> -void die(const char *err, ...) __noreturn __printf(1, 2);
>
> struct dirent;
> struct strlist;
> --
> 2.53.0
>