public inbox for linux-perf-users@vger.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Richter" <tmricht@linux.ibm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf test: Run test 126 exclusive
Date: Wed, 08 Apr 2026 11:14:57 +0000	[thread overview]
Message-ID: <20260408111458.9D6BDC19421@smtp.kernel.org> (raw)
In-Reply-To: <20260408110707.1455185-1-tmricht@linux.ibm.com>

Sashiko AI review found 1 potential issue(s):
- [Medium] The commit message demonstrates flawed validation of the fix. By marking the test as `(exclusive)`, its numerical test ID changed because exclusive tests are deferred and sorted differently in `perf test`. In the 'Output after' section, the author runs `perf test 126 128`, but the output shows this executed entirely different tests ('perf trace exit race' and 'mmap interface tests') rather than the intended 'perf trace BTF general tests'. Thus, the provided proof of the fix is invalid.
--

commit c35ec49c9966f472a5d232107254f8f61709b80f
Author: Thomas Richter <tmricht@linux.ibm.com>

perf test: Run test 126 exclusive

This commit marks the 'perf trace BTF general tests' shell script as
exclusive to prevent it from failing when run concurrently with other
trace tests.

> Output after:
>  # for i in $(seq 3); do perf test 126 128; done
>  126: perf trace exit race                           : Ok
>  128: mmap interface tests                           :
>  128.1: Read samples using the mmap interface        : Ok

Does this validation output demonstrate the correct tests being run?

In the first output block of the commit message, test 126 is 'perf trace
BTF general tests' and 128 is 'perf trace record and replay'. In this later
output block, 126 is 'perf trace exit race' and 128 is 'mmap interface tests'.

Did adding the exclusive tag shift the numeric test IDs, causing the
validation command to run unrelated tests instead of verifying the fix
for the intended BTF general tests?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260408110707.1455185-1-tmricht@linux.ibm.com?part=1

      reply	other threads:[~2026-04-08 11:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 11:07 [PATCH] perf test: Run test 126 exclusive Thomas Richter
2026-04-08 11:14 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408111458.9D6BDC19421@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko@lists.linux.dev \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox