From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E43A3D4134; Wed, 8 Apr 2026 17:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775669559; cv=none; b=CJH8c3Ob1OP0hrw7CkfTMgQIEhJxshWWMlGvx9zP0302lpD0NOxV//+w6I1rGMKujqCWkRQjyxuOoNSMyMofSDaallJwrgO8BEhkQp5Q48gr7+8D41KgIfw2gIV6dZPRTZlNPhFFOSAOw3GDUOij1Wq/PjHEV9rBaCUqsWdOwRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775669559; c=relaxed/simple; bh=zvPbwivfF6emMlDbSDXfWAyZlG8wtviaYd24n/mYMMA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHIsmoYDC8qDU+IUCHOHv9SUzaZPZqDzyiDvVOvQ89s/OkdbAWYsECX5uakuFGCOima+YuZ6sMhWW3aoIiGq2Y6jy7dqLAD4GsDtM9On+aEX/uu7YQl0hqH3cVfUV+AetcLY5WAdYhyL6EH2fJ9ldoj7YWzbyFgZ1vTuZsdrWIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YxZBLv+N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YxZBLv+N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4191BC19421; Wed, 8 Apr 2026 17:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775669559; bh=zvPbwivfF6emMlDbSDXfWAyZlG8wtviaYd24n/mYMMA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YxZBLv+NS0idT44fRE7BEZGvhGHKHuLrF6XHQ2N3jeY/sQYkF7zMLsSo3nMCnGlVZ 8pOH7OXKwy7Six83h6CEMSn1vrOevobSHo+j9qmvGsyH/IZDKzs1GtHJtUGYebW+W3 yT6I/agx8Wirg2tmvX9NxrOEo4u9uyyjPLYg+f8SkUBOYBHXd3zKVKEkQ7/7f7W8X1 ZSpzXz6lBy5CJFX9BwNDp0SjyXsmwri23YRD+70/RZwVEFUDWBDzTjUY3l+PRpsEGV iEr3JFUkEu3CsMdCBNJv801NxOv1+2iMdjRbxIIVBLpBqtM+0dD8T989/pO4JFUVOL z+woro9xz8mlg== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 5/8] perf header: Use a max number of command line args Date: Wed, 8 Apr 2026 14:32:00 -0300 Message-ID: <20260408173203.96700-6-acme@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408173203.96700-1-acme@kernel.org> References: <20260408173203.96700-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo Sashiko suggests we use some reasonable max number of args to avoid overflows when reading perf.data files, do it. Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/header.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index a3b7b796639b42c0..a18f216f77c27430 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -2795,6 +2795,9 @@ process_event_desc(struct feat_fd *ff, void *data __maybe_unused) return 0; } +// Some reasonable arbitrary max for the number of command line arguments +#define MAX_CMDLINE_NR 32768 + static int process_cmdline(struct feat_fd *ff, void *data __maybe_unused) { struct perf_env *env = &ff->ph->env; @@ -2804,6 +2807,9 @@ static int process_cmdline(struct feat_fd *ff, void *data __maybe_unused) if (do_read_u32(ff, &nr)) return -1; + if (nr > MAX_CMDLINE_NR) + return -1; + env->nr_cmdline = nr; cmdline = zalloc(ff->size + nr + 1); -- 2.53.0