Re: [PATCH] perf dso: Fix kallsyms DSO detection with fallback logic

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Low] The macro `DSO__NAME_GUEST_KALLSYMS` is defined with an unbalanced bracket, which is deceptive and prone to misuse.
--

commit bff739892129d9369935f2dfb42b44d83b2f857d
Author: Tanushree Shah <tshah@linux.ibm.com>

perf dso: Fix kallsyms DSO detection with fallback logic

This commit fixes kallsyms DSO detection during build-id injection when
the binary type is not yet explicitly set. It implements a fallback that
matches the long_name against known kallsyms strings to correctly identify
the kernel DSO.

> diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
> index ede691e9a2495..e44071998c499 100644
> --- a/tools/perf/util/dso.h
> +++ b/tools/perf/util/dso.h
[ ... ]
> @@ -20,6 +21,7 @@ struct perf_env;
>  
>  #define DSO__NAME_KALLSYMS	"[kernel.kallsyms]"
>  #define DSO__NAME_KCORE		"[kernel.kcore]"
> +#define DSO__NAME_GUEST_KALLSYMS	"[guest.kernel.kallsyms"

This isn't a bug, but there is a missing closing bracket in this macro
definition.

While it looks like this was done intentionally to allow prefix matching
against dynamic guest kallsyms names (which append a PID) using strncmp
later in the patch, naming it DSO__NAME_GUEST_KALLSYMS implies it represents
a complete, well-formed identifier like DSO__NAME_KALLSYMS.

Could this macro be renamed to something like DSO__PREFIX_GUEST_KALLSYMS
to make its intended use as a prefix clear, preventing it from being
accidentally used in contexts expecting a full name?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260410071225.708005-2-tshah@linux.ibm.com?part=1