From: sashiko-bot@kernel.org
To: "Puranjay Mohan" <puranjay@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 2/4] perf: Use a union to clear branch entry bitfields
Date: Mon, 13 Apr 2026 19:46:37 +0000 [thread overview]
Message-ID: <20260413194638.2086EC2BCAF@smtp.kernel.org> (raw)
In-Reply-To: <20260413185740.3286146-3-puranjay@kernel.org>
Sashiko AI review found 1 potential issue(s):
- [Low] Missing tools/ UAPI header synchronization causing build warnings.
--
Note: The format of this review is altered and does not contain inline patch
quotes due to automated recitation restrictions.
commit 0f3b756dec935106f8ca717cac2777f750f3b8da
Author: Puranjay Mohan <puranjay@kernel.org>
perf: Use a union to clear branch entry bitfields
This commit wraps the bitfields of struct perf_branch_entry in an anonymous
struct inside a union, allowing them to be cleared via a single assignment.
The patch updates include/uapi/linux/perf_event.h to introduce the new
union and struct layout for perf_branch_entry, but it does not appear to
apply the corresponding change to tools/include/uapi/linux/perf_event.h.
Will this discrepancy trigger a build warning in the perf tools? The kernel's
tools/perf/check-headers.sh script explicitly tracks this UAPI header. When
these files drift, it usually results in a warning during the tools build
stating that the Kernel ABI header differs from the latest version.
Should the tools/include/uapi/linux/perf_event.h header be synchronized in
this patch to avoid breaking the header checks?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260413185740.3286146-1-puranjay@kernel.org?part=2
next prev parent reply other threads:[~2026-04-13 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 18:57 [PATCH v3 0/4] arm64: Add BRBE support for bpf_get_branch_snapshot() Puranjay Mohan
2026-04-13 18:57 ` [PATCH v3 1/4] perf/core: Fix NULL pmu_ctx passed to PMU sched_task callback Puranjay Mohan
2026-04-13 19:31 ` sashiko-bot
2026-04-13 18:57 ` [PATCH v3 2/4] perf: Use a union to clear branch entry bitfields Puranjay Mohan
2026-04-13 19:46 ` sashiko-bot [this message]
2026-04-13 18:57 ` [PATCH v3 3/4] perf/arm64: Add BRBE support for bpf_get_branch_snapshot() Puranjay Mohan
2026-04-13 20:31 ` sashiko-bot
2026-04-13 18:57 ` [PATCH v3 4/4] selftests/bpf: Adjust wasted entries threshold for ARM64 BRBE Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413194638.2086EC2BCAF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=puranjay@kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox