From: Chun-Tse Shao <ctshao@google.com>
To: linux-kernel@vger.kernel.org
Cc: Chun-Tse Shao <ctshao@google.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, thomas.falcon@intel.com,
linux-perf-users@vger.kernel.org
Subject: [PATCH] perf stat: Merge CPU maps when merging uncore aliases
Date: Thu, 16 Apr 2026 13:48:04 -0700 [thread overview]
Message-ID: <20260416204828.1303734-1-ctshao@google.com> (raw)
Sockets with event zero counts are hidden in `perf stat --per-socket`
because alias merging aggregates counts but not CPU maps. This causes
the display logic to incorrectly skip sockets not present in the leader
instance's map.
For example, with AMD_UMC:
$ cat /sys/bus/event_source/devices/amd_umc*/cpumask
0
...
128
...
$ perf stat -e amd_umc/config=0xff/ --per-socket -a -- sleep 1
Performance counter stats for 'system wide':
S0 12 0 amd_umc/config=0xff/
1.000777829 seconds time elapsed
Merge CPU maps in `evsel__merge_aggr_counters` to ensure the aggregated
event correctly reflects all underlying PMU instances.
After fix:
$ perf stat -e amd_umc/config=0xff/ --per-socket -a -- sleep 1
Performance counter stats for 'system wide':
S0 12 0 amd_umc/config=0xff/
S1 12 0 amd_umc/config=0xff/
1.000666681 seconds time elapsed
Signed-off-by: Chun-Tse Shao <ctshao@google.com>
---
tools/perf/util/stat.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 14d169e22e8f..d696d217f98d 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -535,6 +535,12 @@ static int evsel__merge_aggr_counters(struct evsel *evsel, struct evsel *alias)
aggr_counts_a->run += aggr_counts_b->run;
}
+ /*
+ * Merge the CPU maps so that the display logic (e.g. should_skip_zero_counter)
+ * knows this merged event covers all CPUs from both aliases.
+ */
+ perf_cpu_map__merge(&evsel->core.cpus, alias->core.cpus);
+
return 0;
}
--
2.54.0.rc1.555.g9c883467ad-goog
next reply other threads:[~2026-04-16 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 20:48 Chun-Tse Shao [this message]
2026-04-16 21:05 ` [PATCH] perf stat: Merge CPU maps when merging uncore aliases Ian Rogers
2026-04-16 21:56 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416204828.1303734-1-ctshao@google.com \
--to=ctshao@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox