Re: [PATCH] perf annotate: Fix NULL pointer dereference in loongarch_call__parse

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Medium] The fix correctly prevents a NULL pointer dereference, but improperly aborts instruction parsing by returning `-1`. This strips the `is_call` attribute and degrades `perf annotate` functionality, whereas it should bypass name extraction and resolve the target using the already extracted address.
--

commit 807b803f1f78132524dc6117283161821fab508a
Author: Jianping Liu <frankljpliu@gmail.com>

perf annotate: Fix NULL pointer dereference in loongarch_call__parse

This commit prevents a segmentation fault in loongarch_call__parse()
by adding a NULL check for the return value of strchr() when parsing
objdump output. It handles cases where a branch-and-link instruction
lacks a symbol name.

> Add a NULL check for the return value of strchr() before dereferencing
> it, consistent with s390_call__parse() which handles the same case
> correctly.

Does s390_call__parse() actually handle this correctly without regressions?

Returning -1 causes disasm_line__init_ins() to receive a negative return
value and set dl->ins.ops = NULL. This makes ins__is_call() evaluate to
false, meaning the instruction completely loses its call semantics in the TUI.

> diff --git a/tools/perf/util/annotate-arch/annotate-loongarch.c b/tools/perf/util/annotate-arch/annotate-loongarch.c
> --- a/tools/perf/util/annotate-arch/annotate-loongarch.c
> +++ b/tools/perf/util/annotate-arch/annotate-loongarch.c
> @@ -29,6 +29,9 @@ static int loongarch_call__parse(const struct arch *arch, struct ins_operands *o
>  	ops->target.addr = strtoull(c, &endptr, 16);
>  
>  	name = strchr(endptr, '<');
> +	if (name == NULL)
> +		return -1;
> +
>  	name++;

Could this code bypass the name extraction and proceed directly to symbol
resolution using the already extracted target address?

Since ops->target.addr is successfully parsed right above this check,
skipping the name parsing and returning 0 instead of aborting with -1 would
preserve the is_call attribute. This would allow the TUI to still draw
branch arrows and navigate the call.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260423053102.3717015-1-frankljpliu@gmail.com?part=1