Re: [PATCH v2 24/58] perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

sashiko-bot
2026-04-23T04:11:41Z

Sashiko AI review found 1 potential issue(s):
- [Medium] Missing installation rules for moved standalone python scripts causes `perf test` regression in installed environments.
--

commit fab2c9b2405a9f1a7e14b977ac6e28f3c18d3bbd
Author: Ian Rogers <irogers@google.com>

perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

This commit moves exported-sql-viewer.py and parallel-perf.py from the
tools/perf/scripts/python/ directory to tools/perf/python/. It also updates
the test scripts to look for parallel-perf.py in its new location.

> diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/script.sh
> index 7007f1cdf761b..2051c6e055695 100755
> --- a/tools/perf/tests/shell/script.sh
> +++ b/tools/perf/tests/shell/script.sh
[ ... ]
> @@ -76,7 +76,7 @@ test_parallel_perf()
> err=2
> return
> fi
> - pp=$(dirname "$0")/../../scripts/python/parallel-perf.py
> + pp=$(dirname "$0")/../../python/parallel-perf.py
> if [ ! -f "${pp}" ] ; then
> echo "SKIP: parallel-perf.py script not found "
> err=2

Does this cause the test to skip unconditionally in installed environments?

Since this commit moves the scripts to tools/perf/python/ but does not update
the installation rules in tools/perf/Makefile.perf, parallel-perf.py is no
longer installed into perfexec_instdir during make install.

When tests are run from an installed perf environment, the file at this new
relative path does not exist, triggering the skip check above.

I see this regression is resolved later in the series by commit 2d6f42d8d1dd7
and commit 615391f35d543, but could the Makefile update be squashed into this
commit to preserve bisectability?

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260423035526.1537178-1-irogers@google.com?part=24