Re: [PATCH v5 24/58] perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

sashiko-bot
2026-04-24T17:15:09Z

Sashiko AI review found 1 potential issue(s):
- [Medium] Moving `exported-sql-viewer.py` and `parallel-perf.py` to `tools/perf/python/` breaks their installation and skips the `parallel-perf` test because `Makefile.perf` is not updated in this commit.
--

commit c423130f6ca40765cfc1d50d745c2cdf9bf08db1
Author: Ian Rogers <irogers@google.com>

perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

This commit moves standalone Python scripts from tools/perf/scripts/python/ to
tools/perf/python/. It updates the test script to reference the new paths.

[ ... ]

> diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/script.sh
> index 7007f1cdf761b4..2051c6e055695b 100755
> --- a/tools/perf/tests/shell/script.sh
> +++ b/tools/perf/tests/shell/script.sh
> @@ -76,7 +76,7 @@ test_parallel_perf()
> err=2
> return
> fi
> - pp=$(dirname "$0")/../../scripts/python/parallel-perf.py
> + pp=$(dirname "$0")/../../python/parallel-perf.py
> if [ ! -f "${pp}" ] ; then
> echo "SKIP: parallel-perf.py script not found "
> err=2

Does moving these scripts without updating tools/perf/Makefile.perf break the
installation step and cause this test to skip?

Prior to this patch, Makefile.perf copied scripts/python/*.py to the
installation directory. Since the Makefile isn't updated in this commit, the
scripts are omitted from make install.

When perf test runs from an installed tree, it expects to find
parallel-perf.py at the installed python/ directory. Since the installation is
missing, the test silently skips.

I see this is fixed in a later commit 00f5f415c2dee0 ("perf Makefile: Update
Python script installation path"), but does leaving the Makefile out of this
commit break bisectability?

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260424164721.2229025-1-irogers@google.com?part=24