Re: [PATCH v7 24/59] perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

sashiko-bot
2026-04-25T23:11:49Z

Sashiko AI review found 1 potential issue(s):
- [Medium] Moving `exported-sql-viewer.py` and `parallel-perf.py` to `tools/perf/python/` drops them from the `make install` target, breaking installed tests and user availability.
--

commit 96b6213f3c26c1df2ecfda1cfe0e88d0ee35dbee
Author: Ian Rogers <irogers@google.com>

perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

This commit moves the standalone scripts exported-sql-viewer.py and
parallel-perf.py from tools/perf/scripts/python/ to tools/perf/python/.
This is done in an effort to deprecate the tools/perf/scripts/python
support.

> diff --git a/tools/perf/scripts/python/parallel-perf.py b/tools/perf/python/parallel-perf.py
> similarity index 100%
> rename from tools/perf/scripts/python/parallel-perf.py
> rename to tools/perf/python/parallel-perf.py

Does this change miss updating the installation rules in
tools/perf/Makefile.perf?

If the makefile relies on a rule like install scripts/python/*.py, moving
these scripts means they will no longer be matched and installed by
make install.

[ ... ]

> diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/script.sh
> index 7007f1cdf761..f983b80e77b7 100755
> --- a/tools/perf/tests/shell/script.sh
> +++ b/tools/perf/tests/shell/script.sh

[ ... ]

> @@ -76,7 +78,7 @@ test_parallel_perf()
> err=2
> return
> fi
> - pp=$(dirname "$0")/../../scripts/python/parallel-perf.py
> + pp=$(dirname "$0")/../../python/parallel-perf.py
> if [ ! -f "${pp}" ] ; then
> echo "SKIP: parallel-perf.py script not found "
> err=2

When the test suite is executed from an installed environment via
make install-tests, will test_parallel_perf silently skip because
parallel-perf.py is not installed to the expected path?

I note that this regression is fixed later in the patch series by the
commit "perf Makefile: Update Python script installation path".

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260425224951.174663-1-irogers@google.com?part=24