Re: [PATCH v1 53/58] perf: Remove libperl support, legacy Perl scripts and tests

sashiko-bot
2026-04-20T00:55:03Z

Sashiko AI review found 2 potential issue(s):
- [Medium] Removal of `#ifndef HAVE_LIBPERL_SUPPORT` in `ui/browsers/scripts.c` causes stale Perl scripts to be listed in the TUI.
- [Low] Leftover `PERL_EMBED_CCOPTS` reference in `tools/perf/Makefile.config`.
--

[Note: The standard inline quoting format has been altered to a free-form
summary due to automated recitation restrictions.]

commit e330ce2fbe1ba45b7d622aaa65d046ff6d7307de
Author: Ian Rogers <irogers@google.com>

perf: Remove libperl support, legacy Perl scripts and tests

This commit removes embedded Perl interpreter support from perf. All legacy
Perl scripts and related tests, as well as the build rules and scripting
engine hooks, have been stripped from the tree.

Looking at the changes in tools/perf/ui/browsers/scripts.c, the find_scripts
function used to skip the perl directory if HAVE_LIBPERL_SUPPORT was not
defined. By removing this conditional check entirely rather than making it an
unconditional skip, does this allow stale Perl scripts left over from
previous installations to appear in the TUI script browser? If a user
attempts to run one of these leftover scripts, might it result in a
confusing error since the execution engine has been removed?

Regarding the build system updates in tools/perf/Makefile.config, the
configuration block that previously defined PERL_EMBED_CCOPTS was removed.
Are there any leftover references to this variable, such as a dangling
detected_var macro call at the end of the file, that might needlessly
export an undefined variable to the configuration?

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260419235911.2186050-1-irogers@google.com?part=53