Re: [PATCH v1 19/58] perf python: Add config file access

sashiko-bot
2026-04-20T00:27:39Z

Sashiko AI review found 1 potential issue(s):
- [Medium] The commit message claims to implement 'lazy address resolution', but the patch only implements `perf.config_get(name)`. The code for lazy address resolution is completely missing from this patch.
--

commit 1e6be9e1aea83e8101ab407cfa623b7a901ede2e
Author: Ian Rogers <irogers@google.com>

perf python: Add config file access

This commit enhances the perf Python module by exposing the configuration
system through a new perf.config_get() function.

> Enhance the perf Python module by adding lazy address resolution and
> Add perf.config_get(name) to expose the perf configuration system.

This isn't a bug, but the commit message mentions adding lazy address
resolution, while the patch only implements perf.config_get(name). Is the
code for lazy address resolution missing from this patch, or should the
commit message be updated to remove this reference?

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260419235911.2186050-1-irogers@google.com?part=19