From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f74.google.com (mail-dl1-f74.google.com [74.125.82.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DA4039A808 for ; Sat, 25 Apr 2026 17:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777139444; cv=none; b=j9iW2IkuOhI4hpm7v86FTx5X5gUumy/uLE/W0Xgj+Jhw4AqnrbzqUS/QCo4Ct09Oy8C5RC92K2XuZhbYBL75iG+uisrwF9HEQKoYz8WICbv1w8/5dzpKkSlUZMDd1i9+FZWJSW/oNgqbna8K/x3DsFlT1WWvcQep6uq4rPGi2wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777139444; c=relaxed/simple; bh=OIxfivDpeuuN830T2/W03ihn1okrUsuSb2nWiRZZk44=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fgRwVsacuD1qsob0+aoa/jdFBzwchPsqBAQuLoNCef5fT1A4pE5ZY+qZbFJdMY+i8AafRRYdP3wsYc1Wl7qgv+5F4YFzLtRYp4B22ZAn9LkgHXHfNyEHPWW/DKojy+8ZOlyY7FlGad+JN2WyiFCHWhN8l9IGHFQilr0qYAToJww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=t3pIq/zb; arc=none smtp.client-ip=74.125.82.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="t3pIq/zb" Received: by mail-dl1-f74.google.com with SMTP id a92af1059eb24-12c726f4055so9076999c88.1 for ; Sat, 25 Apr 2026 10:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777139442; x=1777744242; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zeOgWX73kSMhcsGvtzXC4JAdu5ODROL7Kq4CP+Wwcu4=; b=t3pIq/zbNMrgTApGs5zKNeltVo6bPxCym7YcnjOQvI7P/RHO0yl1BBeZz9IC/rlHuG WF/AbSQwnppPZn5EqoJCNrVCXKJW5cap/2EyNu+ioXYDDS1mjZ6wVb3t3WcEt366Bjjr DII8KPdChSad9PoTVJTiDU6Wx56G5pzstdMC/NSUgsrV7R9i1EPP/UY3u2k3XTU+mWKL IlScAfXgtzNEyCK82wZTspn1QH9p1M6BAYcf/mTZsQH6ybIo+qLwcdhB0xUmXY1s0RlE +HznBHIboXVPuvGf0eiRolSIRw66ofWVys7dUqDYmJ8kcEKhPItcTOZ02N5noqKH0X7U k6TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777139442; x=1777744242; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zeOgWX73kSMhcsGvtzXC4JAdu5ODROL7Kq4CP+Wwcu4=; b=KO2jN/yOsqIRRxO43pqBrTiexUU0qogUAs3rPjxR3IlCbzBDbDZl/NK7ZYlke7bAiK je+bWeUGM11S6pzhptxLcawZ5NiCQZCi3wiNWeN95ZfVViuPKTtfHSg65kduPAMnuVn3 Mnm66zRnHHnXpjZ39HLTupka8KbJoYMOYxe2SLDPPsD3KyZdeBLn8fFKexpc9E5yuzD8 2jKVbMOUuCZubGrlxlF1YRk5ifqThb8ZO8WmXz+jUdlhOcYz8fbfxUYV+ZnjagCOlN4z v3f0MdTwCZzqsA4T/WruvB3iCDowLWXxuYkLm+CDxMnmswBoPMlZR5Nu8WrLWTlQ9E41 0+IA== X-Forwarded-Encrypted: i=1; AFNElJ+xIGHiRXKWMDE2wLGixf82G0GMC79YPJeCTPc1xywhRzvACDZVAJHmmrMLwUWVobbDhxz0DdSGsGxmKO1F5tKn@vger.kernel.org X-Gm-Message-State: AOJu0Ywz35uhfth3bhYqI3KYUSkT8kZgMWlWiGUV42T50WLoYQSDZ5a7 gyMhzQuWwagCvL6ouRQwz8jYiLk4dIxTuIQZ3/qhrJCacdSsZMZPbFFGn//Q7MUiY5gmC6Ogsik Jmv4VpgWanQ== X-Received: from dlbvv17.prod.google.com ([2002:a05:7022:5f11:b0:12a:c3c1:4ace]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:6884:b0:12a:6c4b:9cf0 with SMTP id a92af1059eb24-12c73f643fcmr18964832c88.3.1777139441297; Sat, 25 Apr 2026 10:50:41 -0700 (PDT) Date: Sat, 25 Apr 2026 10:48:48 -0700 In-Reply-To: <20260425174858.3922152-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260424164721.2229025-1-irogers@google.com> <20260425174858.3922152-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260425174858.3922152-51-irogers@google.com> Subject: [PATCH v6 50/59] perf rwtop: Port rwtop to use python module From: Ian Rogers To: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, leo.yan@linux.dev, namhyung@kernel.org, tmricht@linux.ibm.com Cc: alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" Port the legacy Perl script rwtop.pl to a python script using the perf module in tools/perf/python. The new script uses a class-based architecture and leverages the perf.session API for event processing. It periodically displays system-wide r/w call activity, broken down by PID, refreshed every interval. Complications: - Implemented periodic display based on event timestamps (sample.sample_time) instead of relying on SIGALRM, making it robust for file-based processing. - Used ANSI escape codes (\x1b[H\x1b[2J) to clear the terminal. - Fixed unused imports and indentation issues identified by pylint. - pylint warns about the module name not being snake_case, but it is kept for consistency with the original script name. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: - Added Live Session Support: Updated main() to start a LiveSession when the input file does not exist (or is the default "perf.data" and doesn't exist). It traces read and write entry/exit tracepoints. - Fixed Live Mode Comm Resolution: Fixed a bug in process_event() where it would attempt to use self.session to resolve the command name when running in live mode (where self.session is None ). It now falls back to f"PID({pid})" when in live mode or if resolution fails. - Fixed Substring Matching: Replaced loose substring checks like if "sys_enter_read" in event_name: with exact matches against "evsel(syscalls:sys_enter_read)" and "evsel(raw_syscalls:sys_enter_read)" using str(sample.evsel) . This prevents unrelated syscalls with similar names (like readv or readahead ) from being incorrectly aggregated. Similar fixes were applied for exit events and write events. - Inlined Handlers and Tracked Errors: Inlined the _handle_sys_* helper methods into process_event() . Now, if a sample lacks expected fields, it is added to the self.unhandled tracker instead of being silently ignored. - Fixed Write Byte Counting: Updated the write exit handler to use sample.ret to count actual bytes written on success, and tracked requested bytes separately in the enter handler, matching the read behavior. - Added Error Tables to Output: Added tables to display failed reads and writes by PID in print_totals() , which were previously tracked but never displayed. - Fixed Offline Output (Ghosting): Removed the hardcoded ANSI clear-screen escape codes in print_totals() , as they corrupted output when processing offline trace files at CPU speed or when piping the output. - Code Cleanup: Fixed a bug where fd was printed instead of pid in the read counts table, and broke long lines to satisfy pylint. --- tools/perf/python/rwtop.py | 219 +++++++++++++++++++++++++++++++++++++ 1 file changed, 219 insertions(+) create mode 100755 tools/perf/python/rwtop.py diff --git a/tools/perf/python/rwtop.py b/tools/perf/python/rwtop.py new file mode 100755 index 000000000000..895ebab9af10 --- /dev/null +++ b/tools/perf/python/rwtop.py @@ -0,0 +1,219 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0-only +"""Periodically displays system-wide r/w call activity, broken down by pid.""" + +import argparse +from collections import defaultdict +import os +import sys +from typing import Optional, Dict, Any +import perf +from perf_live import LiveSession + +class RwTop: + """Periodically displays system-wide r/w call activity.""" + def __init__(self, interval: int = 3, nlines: int = 20) -> None: + self.interval_ns = interval * 1000000000 + self.nlines = nlines + self.reads: Dict[int, Dict[str, Any]] = defaultdict( + lambda: { + "bytes_requested": 0, + "bytes_read": 0, + "total_reads": 0, + "comm": "", + "errors": defaultdict(int), + } + ) + self.writes: Dict[int, Dict[str, Any]] = defaultdict( + lambda: { + "bytes_requested": 0, + "bytes_written": 0, + "total_writes": 0, + "comm": "", + "errors": defaultdict(int), + } + ) + self.unhandled: Dict[str, int] = defaultdict(int) + self.session: Optional[perf.session] = None + self.last_print_time: int = 0 + + def process_event(self, sample: perf.sample_event) -> None: # pylint: disable=too-many-branches + """Process events.""" + event_name = str(sample.evsel) + pid = sample.sample_pid + sample_time = sample.sample_time + + if self.last_print_time == 0: + self.last_print_time = sample_time + + # Check if interval has passed + if sample_time - self.last_print_time >= self.interval_ns: + self.print_totals() + self.last_print_time = sample_time + + try: + comm = f"PID({pid})" if not self.session else self.session.find_thread(pid).comm() + except Exception: # pylint: disable=broad-except + comm = f"PID({pid})" + + if event_name in ("evsel(syscalls:sys_enter_read)", "evsel(raw_syscalls:sys_enter_read)"): + try: + count = sample.count + self.reads[pid]["bytes_requested"] += count + self.reads[pid]["total_reads"] += 1 + self.reads[pid]["comm"] = comm + except AttributeError: + self.unhandled[event_name] += 1 + elif event_name in ("evsel(syscalls:sys_exit_read)", "evsel(raw_syscalls:sys_exit_read)"): + try: + ret = sample.ret + if ret > 0: + self.reads[pid]["bytes_read"] += ret + else: + self.reads[pid]["errors"][ret] += 1 + except AttributeError: + self.unhandled[event_name] += 1 + elif event_name in ("evsel(syscalls:sys_enter_write)", + "evsel(raw_syscalls:sys_enter_write)"): + try: + count = sample.count + self.writes[pid]["bytes_requested"] += count + self.writes[pid]["total_writes"] += 1 + self.writes[pid]["comm"] = comm + except AttributeError: + self.unhandled[event_name] += 1 + elif event_name in ("evsel(syscalls:sys_exit_write)", "evsel(raw_syscalls:sys_exit_write)"): + try: + ret = sample.ret + if ret > 0: + self.writes[pid]["bytes_written"] += ret + else: + self.writes[pid]["errors"][ret] += 1 + except AttributeError: + self.unhandled[event_name] += 1 + else: + self.unhandled[event_name] += 1 + + def print_totals(self) -> None: + """Print summary tables.""" + print("read counts by pid:\n") + print( + f"{'pid':>6s} {'comm':<20s} {'# reads':>10s} " + f"{'bytes_req':>10s} {'bytes_read':>10s}" + ) + print(f"{'-'*6} {'-'*20} {'-'*10} {'-'*10} {'-'*10}") + + count = 0 + for pid, data in sorted(self.reads.items(), + key=lambda kv: kv[1]["bytes_read"], reverse=True): + print( + f"{pid:6d} {data['comm']:<20s} {data['total_reads']:10d} " + f"{data['bytes_requested']:10d} {data['bytes_read']:10d}" + ) + count += 1 + if count >= self.nlines: + break + + print("\nfailed reads by pid:\n") + print(f"{'pid':>6s} {'comm':<20s} {'error #':>6s} {'# errors':>10s}") + print(f"{'-'*6} {'-'*20} {'-'*6} {'-'*10}") + + errcounts = [] + for pid, data in self.reads.items(): + for error, cnt in data["errors"].items(): + errcounts.append((pid, data["comm"], error, cnt)) + + sorted_errcounts = sorted(errcounts, key=lambda x: x[3], reverse=True) + for pid, comm, error, cnt in sorted_errcounts[:self.nlines]: + print(f"{pid:6d} {comm:<20s} {error:6d} {cnt:10d}") + + print("\nwrite counts by pid:\n") + print( + f"{'pid':>6s} {'comm':<20s} {'# writes':>10s} " + f"{'bytes_req':>10s} {'bytes_written':>13s}" + ) + print(f"{'-'*6} {'-'*20} {'-'*10} {'-'*10} {'-'*13}") + + count = 0 + for pid, data in sorted(self.writes.items(), + key=lambda kv: kv[1]["bytes_written"], reverse=True): + print( + f"{pid:6d} {data['comm']:<20s} {data['total_writes']:10d} " + f"{data['bytes_requested']:10d} {data['bytes_written']:13d}" + ) + count += 1 + if count >= self.nlines: + break + + print("\nfailed writes by pid:\n") + print(f"{'pid':>6s} {'comm':<20s} {'error #':>6s} {'# errors':>10s}") + print(f"{'-'*6} {'-'*20} {'-'*6} {'-'*10}") + + errcounts = [] + for pid, data in self.writes.items(): + for error, cnt in data["errors"].items(): + errcounts.append((pid, data["comm"], error, cnt)) + + sorted_errcounts = sorted(errcounts, key=lambda x: x[3], reverse=True) + for pid, comm, error, cnt in sorted_errcounts[:self.nlines]: + print(f"{pid:6d} {comm:<20s} {error:6d} {cnt:10d}") + + # Reset counts + self.reads.clear() + self.writes.clear() + + def run(self, input_file: str) -> None: + """Run the session.""" + self.session = perf.session(perf.data(input_file), sample=self.process_event) + self.session.process_events() + + # Print final totals if there are any left + if self.reads or self.writes: + self.print_totals() + + if self.unhandled: + print("\nunhandled events:\n") + print(f"{'event':<40s} {'count':>10s}") + print(f"{'-'*40} {'-'*10}") + for event_name, count in self.unhandled.items(): + print(f"{event_name:<40s} {count:10d}") + +def main() -> None: + """Main function.""" + parser = argparse.ArgumentParser(description="Trace r/w activity by PID") + parser.add_argument( + "interval", type=int, nargs="?", default=3, help="Refresh interval in seconds" + ) + parser.add_argument("-i", "--input", default="perf.data", help="Input file") + args = parser.parse_args() + + analyzer = RwTop(args.interval) + try: + if not os.path.exists(args.input) and args.input == "perf.data": + # Live mode + events = ( + "syscalls:sys_enter_read,syscalls:sys_exit_read," + "syscalls:sys_enter_write,syscalls:sys_exit_write" + ) + try: + live_session = LiveSession(events, sample_callback=analyzer.process_event) + except OSError: + events = ( + "raw_syscalls:sys_enter_read,raw_syscalls:sys_exit_read," + "raw_syscalls:sys_enter_write,raw_syscalls:sys_exit_write" + ) + live_session = LiveSession(events, sample_callback=analyzer.process_event) + print("Live mode started. Press Ctrl+C to stop.", file=sys.stderr) + live_session.run() + else: + analyzer.run(args.input) + except IOError as e: + print(e, file=sys.stderr) + sys.exit(1) + except KeyboardInterrupt: + print("\nStopping live mode...", file=sys.stderr) + if analyzer.reads or analyzer.writes: + analyzer.print_totals() + +if __name__ == "__main__": + main() -- 2.54.0.545.g6539524ca2-goog