Re: [PATCH v1 24/58] perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

sashiko-bot
2026-04-20T00:22:01Z

Sashiko AI review found 2 potential issue(s):
- [Medium] Moving parallel-perf.py breaks the parallel-perf test in tools/perf/tests/shell/script.sh.
- [Low] Usage examples in exported-sql-viewer.py reference the old script path.
--

commit 015eb1b3b886beef12696f70686c41ba97d413c0
Author: Ian Rogers <irogers@google.com>

perf python: Move exported-sql-viewer.py and parallel-perf.py to tools/perf/python/

This commit moves the exported-sql-viewer.py and parallel-perf.py scripts
from tools/perf/scripts/python/ to tools/perf/python/ as they are standalone
and do not use the perf script libpython support.

> diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/python/exported-sql-viewer.py
> similarity index 100%
> rename from tools/perf/scripts/python/exported-sql-viewer.py
> rename to tools/perf/python/exported-sql-viewer.py

This isn't a bug, but do the usage examples inside exported-sql-viewer.py
still reference the old script path?

The comments at the top of the script appear to instruct users to run it
using the old path, which might lead to confusion when the examples fail to
execute:

python tools/perf/scripts/python/exported-sql-viewer.py

> diff --git a/tools/perf/scripts/python/parallel-perf.py b/tools/perf/python/parallel-perf.py
> similarity index 100%
> rename from tools/perf/scripts/python/parallel-perf.py
> rename to tools/perf/python/parallel-perf.py

Does this move break the parallel-perf test in
tools/perf/tests/shell/script.sh?

The test_parallel_perf() function seems to hardcode the script path:

tools/perf/tests/shell/script.sh:test_parallel_perf() {
...
pp=$(dirname "$0")/../../scripts/python/parallel-perf.py
if [ ! -f "${pp}" ]; then
...
}

Since the path in the test is not updated in tandem with the script move, will
this cause the check to evaluate to true and silently skip the test?

This appears to result in a permanent loss of test coverage, as subsequent
commits do not seem to resolve the path mismatch.

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260419235911.2186050-1-irogers@google.com?part=24