From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B50B396B9A for ; Sat, 25 Apr 2026 22:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777156945; cv=none; b=jWXjBmiE3kUUQklOskn1F1nLGUfnnwl8yhnKIX0i24oQ6t4v8Ecw8kHQ+u3VLqlJOdzgyj8wS3Urkt2deuFlfR0QPybksTc4ne7EbbRfnCQBsBwtw+Z8w8HzPTmYaUQw+E0a+lJrZY+DccKzRuXjw3XeuFwI+Y0mA9yaFw8jw7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777156945; c=relaxed/simple; bh=eJ9kVepVnSBQCHOyn4G/66b2UzKOBaVMlZphDP73+zk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gkaYoTZ4GFQ561KmOYCtts4l+hvyiW1teT1bwo3SwBsZcGkdZBuTBVxZo9Nf4VVd5M+xrjCUywt1P80z5eHfg3XiMce7MnT0hu+DRc1gR0rj55oTf4xnVxBBgw+pTqYx9NvtXS3lh9TC21uxZjhpqhxsNPRnaRifiw93YGhTnRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eju1T9XO; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eju1T9XO" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2ddd8ef5343so8844135eec.1 for ; Sat, 25 Apr 2026 15:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777156943; x=1777761743; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VNEC1d+XQU6xcwJqo0QpL4AVBd93i989y6KjyJp07QI=; b=eju1T9XOtFxUHhmChcN2xgYowDKafeH2W2jc5laHhvf75H7OhrkJxdbXvuMnq0VZL5 68EygppPLL5fAdZ+cyCYZr6RIPtG8rlhclzBL47B6rMPgFEFKSs/kvKABxs3nnwq41Hx 5+8iHhqLftDCrHkkqt8Ezk/qqmjeevg6Uwo0tnlvlVew4RhaPIp5dhZXic5cDI7KMPwy rVSK7BO7WptjxXBZOVgGWjUlBkjDGuTOwfabcimZCGtNqdHyHR4DHeil+on7XB9ytDf/ UPbf3fcdcFoz2bNrGX4U1EWyvOox7UXaH6B8lG83/D9sPWMHe8hzDAV18/iof5uSfGMc OSxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777156943; x=1777761743; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VNEC1d+XQU6xcwJqo0QpL4AVBd93i989y6KjyJp07QI=; b=oZ4pohLEdtDsH02j2SzHbDo2JB3Cu0iavK3JFEaN1YmNpDj1mLwXaignO+jHXYT4mQ BWlagANq4jIvtRdFw2yrDHaWyVNLTNAApCHJ+FPdwKKNWoUfJ+TDHO5yLL/IxNt7aHBt rI+nmR/YQQ2TBwknldbUuhNw0SxUwXC8LexfoOuvsh9yTlKHMivEB3cOK7gfGm7E605a vzxjqYibm+Jp66Fv1gyzJwDqvqgqC5JZ2egDbOOC36H/U25M+HTW62TX1GPWyJ9zfgLj RgygATKQyloPf1goMryeLzPb8lXA/jq3AIhUfoRM9jJQUM57UIEAuuYu/QtED1MDlw0g sg2Q== X-Forwarded-Encrypted: i=1; AFNElJ89mMRAzrUo1amcWm34HhRz+K2uKNYi0PGTO31SafTT71b6wnNcTtv9y2jAtAHy6gSXvGkyGheiTr84tfL3UUck@vger.kernel.org X-Gm-Message-State: AOJu0YyH1wi6anaIPsIK4XB4LcwyClnZts2DWEt+rCbWY1/MeWWubv40 rB8eGE/JFAuW5F3qc/LxZcUK9LGx0Oaa+VkqilJC6HfUwQuoxiCIvU1QlBGgltvsMRX9HM72PoQ 0/w4t4WnCsg== X-Received: from dycqr6.prod.google.com ([2002:a05:7300:ff46:b0:2dd:67ce:b8c5]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:8005:b0:2dd:144b:6c2 with SMTP id 5a478bee46e88-2e478e28c50mr14956952eec.27.1777156943041; Sat, 25 Apr 2026 15:42:23 -0700 (PDT) Date: Sat, 25 Apr 2026 15:40:50 -0700 In-Reply-To: <20260425224125.160890-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260425174858.3922152-1-irogers@google.com> <20260425224125.160890-1-irogers@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260425224125.160890-26-irogers@google.com> Subject: [PATCH v7 25/59] perf stat-cpi: Port stat-cpi to use python module From: Ian Rogers To: acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, leo.yan@linux.dev, namhyung@kernel.org, tmricht@linux.ibm.com Cc: alice.mei.rogers@gmail.com, dapeng1.mi@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" Port stat-cpi.py from the legacy framework to a standalone script. Support both file processing mode (using perf.session) and live mode (reading counters directly via perf.parse_events and evsel.read). Use argparse for command line options handling. Calculate and display CPI (Cycles Per Instruction) per interval per CPU/thread. Assisted-by: Gemini:gemini-3.1-pro-preview Signed-off-by: Ian Rogers --- v2: 1. Accurate CPI Calculation (Multiplexing Support): - Before: The get() method returned the raw counter value directly, ignoring whether the counter ran for the full interval. - After: The get() method now scales the raw value by the ratio of enabled time to running time ( val * (ena / float(run)) ) when run > 0 . This handles cases where PMU counters are overcommitted and multiplexed. 2. Per-Interval CPI in File Mode: - Before: store() saved absolute counter values as read from PERF_RECORD_STAT . Since these are cumulative from the start of the trace, and data.clear() was called every round, the script computed cumulative CPI rather than per-interval CPI. - After: store() now computes the delta between the current absolute value and the value from the previous interval. It saves this delta in self.data and retains the absolute value in self. prev_data for the next delta computation. 3. Prevention of Dummy Output (Cartesian Product Fix): - Before: self.cpus and self.threads lists accumulated all unique CPUs and threads seen independently. The nested loops in print_interval() then created a Cartesian product of all seen CPUs and threads, querying data for combinations that might never have occurred. - After: Replaced lists with a self.recorded_pairs set that stores (cpu, thread) tuples only when a sample actually records them. The output loop now iterates strictly over these verified pairs. --- tools/perf/python/stat-cpi.py | 151 ++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+) create mode 100755 tools/perf/python/stat-cpi.py diff --git a/tools/perf/python/stat-cpi.py b/tools/perf/python/stat-cpi.py new file mode 100755 index 000000000000..4b1f1f69c94a --- /dev/null +++ b/tools/perf/python/stat-cpi.py @@ -0,0 +1,151 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 +"""Calculate CPI from perf stat data or live.""" + +import argparse +import sys +import time +from typing import Any, Optional +import perf + +class StatCpiAnalyzer: + """Accumulates cycles and instructions and calculates CPI.""" + + def __init__(self, args: argparse.Namespace) -> None: + self.args = args + self.data: dict[str, tuple[int, int, int]] = {} + self.prev_data: dict[str, tuple[int, int, int]] = {} + self.recorded_pairs: set[tuple[int, int]] = set() + + def get_key(self, event: str, cpu: int, thread: int) -> str: + """Get key for data dictionary.""" + return f"{event}-{cpu}-{thread}" + + def store_key(self, cpu: int, thread: int) -> None: + """Store CPU and thread IDs.""" + self.recorded_pairs.add((cpu, thread)) + + def store(self, event: str, cpu: int, thread: int, counts: tuple[int, int, int]) -> None: + """Store counter values, computing difference from previous absolute values.""" + self.store_key(cpu, thread) + key = self.get_key(event, cpu, thread) + + val, ena, run = counts + if key in self.prev_data: + prev_val, prev_ena, prev_run = self.prev_data[key] + cur_val = val - prev_val + cur_ena = ena - prev_ena + cur_run = run - prev_run + else: + cur_val = val + cur_ena = ena + cur_run = run + + self.data[key] = (cur_val, cur_ena, cur_run) + self.prev_data[key] = counts # Store absolute value for next time + + def get(self, event: str, cpu: int, thread: int) -> float: + """Get scaled counter value.""" + key = self.get_key(event, cpu, thread) + if key not in self.data: + return 0.0 + val, ena, run = self.data[key] + if run > 0: + return val * (ena / float(run)) + return float(val) + + def process_stat_event(self, event: Any, name: Optional[str] = None) -> None: + """Process PERF_RECORD_STAT and PERF_RECORD_STAT_ROUND events.""" + if event.type == perf.RECORD_STAT: + if name: + if "cycles" in name: + event_name = "cycles" + elif "instructions" in name: + event_name = "instructions" + else: + return + self.store(event_name, event.cpu, event.thread, (event.val, event.ena, event.run)) + elif event.type == perf.RECORD_STAT_ROUND: + timestamp = getattr(event, "time", 0) + self.print_interval(timestamp) + self.data.clear() + self.recorded_pairs.clear() + + def print_interval(self, timestamp: int) -> None: + """Print CPI for the current interval.""" + for cpu, thread in sorted(self.recorded_pairs): + cyc = self.get("cycles", cpu, thread) + ins = self.get("instructions", cpu, thread) + cpi = 0.0 + if ins != 0: + cpi = cyc / float(ins) + t_sec = timestamp / 1000000000.0 + print(f"{t_sec:15f}: cpu {cpu}, thread {thread} -> cpi {cpi:f} ({cyc:.0f}/{ins:.0f})") + + def read_counters(self, evlist: Any) -> None: + """Read counters live.""" + for evsel in evlist: + name = str(evsel) + if "cycles" in name: + event_name = "cycles" + elif "instructions" in name: + event_name = "instructions" + else: + continue + + for cpu in evsel.cpus(): + for thread in evsel.threads(): + try: + counts = evsel.read(cpu, thread) + self.store(event_name, cpu, thread, + (counts.val, counts.ena, counts.run)) + except OSError: + pass + + def run_file(self) -> None: + """Process events from file.""" + session = perf.session(perf.data(self.args.input), stat=self.process_stat_event) + session.process_events() + + def run_live(self) -> None: + """Read counters live.""" + evlist = perf.parse_events("cycles,instructions") + if not evlist: + print("Failed to parse events", file=sys.stderr) + return + try: + evlist.open() + except OSError as e: + print(f"Failed to open events: {e}", file=sys.stderr) + return + + print("Live mode started. Press Ctrl+C to stop.") + try: + while True: + time.sleep(self.args.interval) + timestamp = time.time_ns() + self.read_counters(evlist) + self.print_interval(timestamp) + self.data.clear() + self.recorded_pairs.clear() + except KeyboardInterrupt: + print("\nStopped.") + finally: + evlist.close() + +def main() -> None: + """Main function.""" + ap = argparse.ArgumentParser(description="Calculate CPI from perf stat data or live") + ap.add_argument("-i", "--input", help="Input file name (enables file mode)") + ap.add_argument("-I", "--interval", type=float, default=1.0, + help="Interval in seconds for live mode") + args = ap.parse_args() + + analyzer = StatCpiAnalyzer(args) + if args.input: + analyzer.run_file() + else: + analyzer.run_live() + +if __name__ == "__main__": + main() -- 2.54.0.545.g6539524ca2-goog