From: sashiko-bot@kernel.org
To: "Martin Kaiser" <martin@kaiser.cx>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/3] perf test: fix "trace summary" test for musl-based systems
Date: Mon, 27 Apr 2026 09:57:44 +0000 [thread overview]
Message-ID: <20260427095745.D6D11C2BCB8@smtp.kernel.org> (raw)
In-Reply-To: <20260427090225.794482-4-martin@kaiser.cx>
Sashiko AI review found 1 potential issue(s):
- [Medium] The `ps --help` test workload is brittle and will continue to fail on many musl-based systems that use BusyBox.
--
commit 41e18297314ee059526c7fb6d14d02d61ba92d64
Author: Martin Kaiser <martin@kaiser.cx>
perf test: fix "trace summary" test for musl-based systems
This commit updates the trace summary test to use ps --help instead
of true. The goal is to ensure the test workload triggers open, read,
and close events from dynamic library loading on musl-based systems.
> diff --git a/tools/perf/tests/shell/trace_summary.sh b/tools/perf/tests/shell/trace_summary.sh
> --- a/tools/perf/tests/shell/trace_summary.sh
> +++ b/tools/perf/tests/shell/trace_summary.sh
> @@ -14,7 +14,7 @@ OUTPUT=$(mktemp /tmp/perf_trace_test.XXXXX)
>
> test_perf_trace() {
> args=$1
> - workload="true"
> + workload="ps --help"
Will this workload still fail on musl-based systems that use BusyBox?
Many musl-based distributions, such as Alpine Linux or OpenWrt, frequently
use BusyBox to provide standard utilities. BusyBox's ps is typically
statically linked or links only to libc, without depending on libprocps.
Furthermore, running ps --help in BusyBox generally prints the usage string
and exits without performing file I/O, which means no open, read, or close
events will be generated.
Would a command that natively performs file I/O, such as cat /dev/null or
dd if=/dev/null of=/dev/null, be more robust here?
> search="^\s*(open|read|close).*[0-9]+%$"
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260427090225.794482-1-martin@kaiser.cx?part=3
prev parent reply other threads:[~2026-04-27 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:01 [PATCH 0/3] perf: fix some tests for musl Martin Kaiser
2026-04-27 9:01 ` [PATCH 1/3] perf test: fix nanosleep check in the ftrace test Martin Kaiser
2026-04-27 9:01 ` [PATCH 2/3] perf test: fix sys_enter_openat event test for musl Martin Kaiser
2026-04-27 9:49 ` sashiko-bot
2026-04-27 9:01 ` [PATCH 3/3] perf test: fix "trace summary" test for musl-based systems Martin Kaiser
2026-04-27 9:57 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427095745.D6D11C2BCB8@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox