From: sashiko-bot@kernel.org
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH][next] perf/x86: Avoid multiple -Wflex-array-member-not-at-end warnings
Date: Wed, 29 Apr 2026 21:32:25 +0000 [thread overview]
Message-ID: <20260429213226.881D8C19425@smtp.kernel.org> (raw)
In-Reply-To: <afJcDg1I5ZU5ZkXf@kspp>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the commit message: 'inmediately' instead of 'immediately'.
--
commit 0317549343d8f9b27dab5b6a63ada8e7200c73f0
Author: Gustavo A. R. Silva <gustavoars@kernel.org>
perf/x86: Avoid multiple -Wflex-array-member-not-at-end warnings
This commit fixes multiple -Wflex-array-member-not-at-end warnings by using
the TRAILING_OVERLAP() helper. It overlays the trailing members onto the
flexible array member while preserving the original memory layout. A static
assertion ensures alignment is not inadvertently changed.
> Lastly, the static_assert() ensures the alignment between the FAM
> and struct perf_branch_entry lbr_entries[MAX_LBR_ENTRIES]; is not
> inadvertently changed, and it's intentionally placed inmediately
> after the related structure (that is, no blank line in between).
This isn't a bug, but there is a typo (inmediately) in the commit message.
--
Sashiko AI review · https://sashiko.dev/#/patchset/afJcDg1I5ZU5ZkXf@kspp?part=1
next prev parent reply other threads:[~2026-04-29 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 19:29 [PATCH][next] perf/x86: Avoid multiple -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2026-04-29 21:32 ` sashiko-bot [this message]
2026-05-04 8:32 ` Peter Zijlstra
2026-05-04 19:50 ` Gustavo A. R. Silva
2026-05-07 8:10 ` Peter Zijlstra
2026-05-07 10:14 ` Peter Zijlstra
2026-05-07 8:46 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429213226.881D8C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gustavoars@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox