From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19A871E32A2 for ; Sat, 2 May 2026 14:33:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777732382; cv=none; b=TmzEkPaksCerfaSVgLz4+m+JO7CFyrm+qEjJj5c2brEUOpeR6Kyto87mif9IcjzD62/9YVEPBAKFLe6TgwbnzoqlQE6UNuEZTRh4ZvyBpVUIzbfROc1j2YJ8FSBQ1UZnLxtlQHI5kxOOz7fV+im/DihYpqsvvlnHMBFJPF0soaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777732382; c=relaxed/simple; bh=9SwrgzkR25O3wa63KgvbU8K+vEGk3UeAZItMHnD4B/s=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kiC6xheb3nkbU4TpCoH2MU6S5q0ZMGfRz/UMwg4GFTNXQYPa4nSjYfDTxysTmPq7x+8vRvZfVThyRouQhDXennWbIxqq4XXaKDuLaRrX4SL71mKa8uG7oCwT4PfvNyIPLCuXImjmJ9NEDoJin/gVaNXZpyuh/FIO8ACnEZWFF00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ZXXY0bci; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ZXXY0bci" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6427NKNt2333320; Sat, 2 May 2026 14:32:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=kuHqVdlej+Yn0HOXIpjPZZdn1xMOEqKbsgmm1UXRw MU=; b=ZXXY0bcimFS7s+UuKIRYE6gYUWW/BXtHAvxgkOyFfZ9XTVuTFlNyV/xSW az3N3Z2JFKiQEgq6vSse/rJqp3Vv22bCDXEp5c8HMFUY5WxMON1KXhce6FR8BW5f i9yzeVVnFUmWQ6YrcN721u0/T7TkmcAIqwyyPSv68HxRphmBl4YDnLNBOfpzXO7j 8z5ZvDWx6WY0+5UKn+CM6HrYQAa2pr3x77bi+NveGCtZaTvKEYEcWGOQw+SaLfEY 8IpXROzu5d8r1/udbTpHxNTUfpWw6EJZMGXAxljuVOUY7vnIELN0lKb4MkuZGVeK Z9HTI/BQe7LatXzOSDkbbf2qZG6qw== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y495cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 02 May 2026 14:32:49 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 642EOmWM009315; Sat, 2 May 2026 14:32:48 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dw9fs9dxd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 02 May 2026 14:32:48 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 642EWjs735782920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 2 May 2026 14:32:45 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 136E320043; Sat, 2 May 2026 14:32:45 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAF2B20040; Sat, 2 May 2026 14:32:39 +0000 (GMT) Received: from localhost.localdomain (unknown [9.124.223.37]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 2 May 2026 14:32:39 +0000 (GMT) From: Athira Rajeev To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com, irogers@google.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, atrajeev@linux.ibm.com, hbathini@linux.vnet.ibm.com, Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, shivani@linux.ibm.com Subject: [PATCH V4 1/2] powerpc tools perf: Initialize error code in auxtrace_record_init function Date: Sat, 2 May 2026 20:02:36 +0530 Message-Id: <20260502143237.23456-1-atrajeev@linux.ibm.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTAyMDE0MSBTYWx0ZWRfX+GjDJc/uByfZ x5pXiEs0i+/wemKBf8qOSBAF900UmW9wZc2CaZiMFnbBkSzA/HKVOpx7w7XCUAEmjIQC4S2OUPB WE2Sptqf+QHGRjvpTWY4UyrFKQnsqpxD4UFCMS0Q+2oStG11OVtLOZUSRE3xwmoNzNhwjJTivfl 3KPpQ6x4ZPT5c5g/b32Q+4mUdhk9JvGSVyEHScsNl8sAlua0NNAHgGD03PIDCMijXAHtJ1a/04k UJCQFgfM+Rvawxqf22UorkgBBJpPMqrXFd31Qb2RFFHHS4l8aH/fNaW38/5SFIybWTC0BdBStie qgkcqFa0fgeebRTdJnGqRqRDMbZArfBviQKquz/vhp8ys70cOnJANaEPNYSduhdPRFJKL5qVt51 VANLUWk/Sw/geQ8Una6eX2XicrmrNnZrOBhRYuvOh0Yfgmy8v7mKwmgTaXSQshNYpqnstuwhE3l 6zQT0B7AeI49opQ+TyA== X-Authority-Analysis: v=2.4 cv=J4GaKgnS c=1 sm=1 tr=0 ts=69f60b11 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=UYfmDeaf6v5XVjAx5qsA:9 X-Proofpoint-GUID: cfOsUC42KIWAZtrn4Zl9Swbig2OcC7po X-Proofpoint-ORIG-GUID: -ZT8zzJPUQgicBy1YPMdRHKy-ouycN71 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-02_03,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605020141 perf trace record fails some cases in powerpc # ./perf test "perf trace record and replay" 128: perf trace record and replay : FAILED! # ./perf trace record sleep 1 # echo $? 32 This is happening because of non-zero err value from auxtrace_record__init() function. static int record__auxtrace_init(struct record *rec) { int err; if ((rec->opts.auxtrace_snapshot_opts || rec->opts.auxtrace_sample_opts) && record__threads_enabled(rec)) { pr_err("AUX area tracing options are not available in parallel streaming mode.\n"); return -EINVAL; } if (!rec->itr) { rec->itr = auxtrace_record__init(rec->evlist, &err); if (err) return err; } Here "int err" is not initialised. The code expects "err" to be set from auxtrace_record__init() function. Update auxtrace_record__init() in arch/powerpc/util/auxtrace.c to clear err value in the beginning. - Clear err value in beginning of function. Any fail later will set appropriate return code to err. - Even if we haven't found any event for auxtrace, perf record should continue for other events. NULL return will indicate that there is no auxtrace record initialized. - Not having "err" set here will affect monitoring of other events also because perf record will fail seeing random value in err. Set err to -EINVAL before invoking auxtrace_record__init() in builtin-record.c With the fix, # ./perf trace record sleep 1 [ perf record: Woken up 2 times to write data ] [ perf record: Captured and wrote 0.033 MB perf.data (228 samples) ] Fixes: 1dbfaf94cf66 ("perf powerpc: Add basic CONFIG_AUXTRACE support for VPA pmu on powerpc") Signed-off-by: Athira Rajeev --- Changelog: v1 -> v2 Addressed review comment from Adrian: - Set err to -EINVAL before invoking auxtrace_record__init() in builtin-record.c - Added kernel-doc to auxtrace_record__init() in tools/perf/util/auxtrace.c Addressed review comment from Namhyung: - Added fixes tag tools/perf/arch/powerpc/util/auxtrace.c | 6 ++++++ tools/perf/builtin-record.c | 1 + 2 files changed, 7 insertions(+) diff --git a/tools/perf/arch/powerpc/util/auxtrace.c b/tools/perf/arch/powerpc/util/auxtrace.c index e39deff6c857..4600a1661b4f 100644 --- a/tools/perf/arch/powerpc/util/auxtrace.c +++ b/tools/perf/arch/powerpc/util/auxtrace.c @@ -71,6 +71,12 @@ struct auxtrace_record *auxtrace_record__init(struct evlist *evlist, struct evsel *pos; int found = 0; + /* + * Set err value to zero here. Any fail later + * will set appropriate return code to err. + */ + *err = 0; + evlist__for_each_entry(evlist, pos) { if (strstarts(pos->name, "vpa_dtl")) { found = 1; diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 4a5eba498c02..708825747af5 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -865,6 +865,7 @@ static int record__auxtrace_init(struct record *rec) } if (!rec->itr) { + err = -EINVAL; rec->itr = auxtrace_record__init(rec->evlist, &err); if (err) return err; -- 2.47.3