Re: [RFT PATCH v2 5/7] perf-iostat: Extend iostat interface to support different iostat PMUs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Cryptic failure during argument parsing on unsupported platforms due to removed error message.
--

commit a592ebf60ec05a2462f9e4e0f181c260df2632a7
Author: Shiju Jose <shiju.jose@huawei.com>

perf-iostat: Extend iostat interface to support different iostat PMUs

This commit extends the common iostat interface to provide support for
different PMUs. It allows each PMU to register itself and receive callbacks
for its specific functions through a unified framework.

> diff --git a/tools/perf/util/iostat.c b/tools/perf/util/iostat.c
> index a68ab100780d5..90607d1cf3fae 100644
> --- a/tools/perf/util/iostat.c
> +++ b/tools/perf/util/iostat.c

[ ... ]

> -__weak int iostat_parse(const struct option *opt __maybe_unused,
> -			 const char *str __maybe_unused,
> -			 int unset __maybe_unused)
> +__weak int iostat_parse(const struct option *opt, const char *str, int unset)
>  {
> -	pr_err("iostat mode is not supported on current platform\n");
> -	return -1;
> +	if (!iostat_pmu)
> +		return -1;

Does removing this error message cause a cryptic failure during argument
parsing on unsupported platforms?

Previously, if iostat was unsupported, it explicitly printed that the mode
was not supported on the current platform. Now, returning -1 from an option
callback without an error message causes the parser to abort and print a
generic error, such as an unknown option.

> +
> +	return iostat_pmu->parse(opt, str, unset);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507063737.3542950-1-wangyushan12@huawei.com?part=5