Re: [PATCH v2 4/7] perf trace: Sync uapi/linux/sched.h with the kernel source

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Build Script Regex Regression
--

commit 95b9a74eb48111bfe1440ab1eb342b9d9108af43
Author: Namhyung Kim <namhyung@kernel.org>

perf trace: Sync uapi/linux/sched.h with the kernel source

Syncs the tools copy of uapi/linux/sched.h with the kernel source to pick up
changes related to clone3 and unshare flags.

> diff --git a/tools/perf/trace/beauty/include/uapi/linux/sched.h b/tools/perf/trace/beauty/include/uapi/linux/sched.h
> index 359a14cc76a40..33a4624285cd4 100644
> --- a/tools/perf/trace/beauty/include/uapi/linux/sched.h
> +++ b/tools/perf/trace/beauty/include/uapi/linux/sched.h
> @@ -34,8 +34,12 @@
>  #define CLONE_IO		0x80000000	/* Clone io context */
>  
>  /* Flags for the clone3() syscall. */
> -#define CLONE_CLEAR_SIGHAND 0x100000000ULL /* Clear any signal handler and reset to SIG_DFL. */
> -#define CLONE_INTO_CGROUP 0x200000000ULL /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_CLEAR_SIGHAND	(1ULL << 32) /* Clear any signal handler and reset to SIG_DFL. */
> +#define CLONE_INTO_CGROUP	(1ULL << 33) /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_AUTOREAP		(1ULL << 34) /* Auto-reap child on exit. */
> +#define CLONE_NNP		(1ULL << 35) /* Set no_new_privs on child. */
> +#define CLONE_PIDFD_AUTOKILL	(1ULL << 36) /* Kill child when clone pidfd closes. */
> +#define CLONE_EMPTY_MNTNS	(1ULL << 37) /* Create an empty mount namespace. */

Does changing these flag definitions from hexadecimal literals to bit-shifts
break the beautifier script?

Looking at tools/perf/trace/beauty/clone.sh, the script relies on matching
hexadecimal literals like (0x[[:xdigit:]]+) to extract these flags. Without
updating the regex in this patch, the script will silently fail to extract
these modified and new flags, causing them to be excluded from
clone_flags_array.c.

While a subsequent patch in the series attempts to fix this by replacing the
regex with one that exclusively matches 1ULL << X, this drops all standard
32-bit clone flags (like CLONE_VM and CLONE_FS) which remain defined as
hexadecimal literals in the header.

Could the script be updated to support both formats?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260507072632.37152-1-namhyung@kernel.org?part=4