Re: [PATCH v3 4/7] perf trace: Sync uapi/linux/sched.h with the kernel source

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The perf trace beauty script fails to parse the updated CLONE_ flags.
--

commit e023642b20fe09480cd6197b5038b768b3c71c47
Author: Namhyung Kim <namhyung@kernel.org>

perf trace: Sync uapi/linux/sched.h with the kernel source

This commit updates uapi/linux/sched.h to pick up changes related to clone
flags and mount namespaces. This is intended to beautify scheduler syscall
arguments in perf trace.

> diff --git a/tools/perf/trace/beauty/include/uapi/linux/sched.h b/tools/perf/trace/beauty/include/uapi/linux/sched.h
> index 359a14cc76a40..33a4624285cd4 100644
> --- a/tools/perf/trace/beauty/include/uapi/linux/sched.h
> +++ b/tools/perf/trace/beauty/include/uapi/linux/sched.h
[ ... ]
> @@ -34,8 +34,12 @@
>  #define CLONE_IO		0x80000000	/* Clone io context */
>  
>  /* Flags for the clone3() syscall. */
> -#define CLONE_CLEAR_SIGHAND 0x100000000ULL /* Clear any signal handler and reset to SIG_DFL. */
> -#define CLONE_INTO_CGROUP 0x200000000ULL /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_CLEAR_SIGHAND	(1ULL << 32) /* Clear any signal handler and reset to SIG_DFL. */
> +#define CLONE_INTO_CGROUP	(1ULL << 33) /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_AUTOREAP		(1ULL << 34) /* Auto-reap child on exit. */
> +#define CLONE_NNP		(1ULL << 35) /* Set no_new_privs on child. */
> +#define CLONE_PIDFD_AUTOKILL	(1ULL << 36) /* Kill child when clone pidfd closes. */
> +#define CLONE_EMPTY_MNTNS	(1ULL << 37) /* Create an empty mount namespace. */

Does this change break the beautifier script that parses these flags?

Looking at tools/perf/trace/beauty/clone.sh, it appears to rely on a regex
that strictly matches hex constants like (0x[[:xdigit:]]+). Because the new
flags use bit shifts instead of hex values, the grep command in the script
might fail to match these lines.

This could result in both the newly added flags and the modified existing
flags being silently ignored by the script, causing perf trace to fall back
to printing raw hex values instead of the beautified flag names.

I noticed that a fix for this regression was provided later in the patch
series in commit 640ffc6a21fbc.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510202346.49853-1-namhyung@kernel.org?part=4