Re: [PATCH v2 11/18] perf build: Pre-generate BPF skeleton tooling during umbrella prepare phase

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new `bpf-skel-prepare` target in `Makefile.perf` is a pseudo-target but is missing a `.PHONY` declaration.
--

commit 13c9711193709348ce5b064c3bbf8b66453f9cb5
Author: Ian Rogers <irogers@google.com>

perf build: Pre-generate BPF skeleton tooling during umbrella prepare phase

This commit decouples early skeleton tooling generation by attaching a
bpf-skel-prepare target to the umbrella prepare phase. This allows Make to
compile bpftool and dump vmlinux.h in the background at build startup.

> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 5af767415c113..df68d29ecab73 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
[ ... ]
> @@ -629,8 +629,12 @@ endif
>  __build-dir = $(subst $(OUTPUT),,$(dir $@))
>  build-dir   = $(or $(__build-dir),.)
>  
> +bpf-skel-prepare:
> +	$(Q)$(MAKE) -f bpf_skel.mak bpf-skel-prepare

Should bpf-skel-prepare be marked as .PHONY in Makefile.perf?

Without a .PHONY declaration, if a file or directory named bpf-skel-prepare
accidentally exists in the build directory, Make will consider the target
up-to-date and silently skip it.

While bpf-skel-prepare is marked .PHONY inside bpf_skel.mak, the top-level
Makefile.perf evaluates the target first before the child make is invoked.

> +
>  prepare: $(OUTPUT)PERF-VERSION-FILE \
>  	arm64-sysreg-defs \
> +	bpf-skel-prepare \
>  	$(LIBAPI) \

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260512174638.120445-1-irogers@google.com?part=11