Re: [PATCH 1/7] init/initramfs_test: wait_for_initramfs() before running

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch uses the per-test `.init` KUnit callback instead of the suite-level `.suite_init` callback.
--

commit 28e6f37006ed9a359c88f36fcc58752b6f3eb78e
Author: Jia He <justin.he@arm.com>

init/initramfs_test: wait_for_initramfs() before running

The commit introduces a wait_for_initramfs() call to ensure the boot-time
async do_populate_rootfs() is complete before the initramfs kunit tests run.
This prevents a race condition where the boot-time unpacker and the test
unpacker corrupt each other's module-static state.

> diff --git a/init/initramfs_test.c b/init/initramfs_test.c
> index 2ce38d9a8fd0f..eb76f63f302e0 100644
> --- a/init/initramfs_test.c
> +++ b/init/initramfs_test.c

[ ... ]

> @@ -510,8 +512,21 @@ static struct kunit_case __refdata initramfs_test_cases[] = {
>  	{},
>  };
>  
> -static struct kunit_suite initramfs_test_suite = {
> +static int __init initramfs_test_init(struct kunit *test)
> +{
> +	/*
> +	 * unpack_to_rootfs() uses module-static state (victim, byte_count,
> +	 * state, ...). The boot-time async do_populate_rootfs() may still be
> +	 * running, so wait for it to finish before we call unpack_to_rootfs()
> +	 * from the test thread, otherwise the two writers race and crash.
> +	 */
> +	wait_for_initramfs();
> +	return 0;
> +}
> +
> +static struct kunit_suite __refdata initramfs_test_suite = {
>  	.name = "initramfs",
> +	.init = initramfs_test_init,

The commit message notes this is added so the async unpack is quiescent
"before the first case runs". Should this be using .suite_init instead of
.init?

The .init callback is invoked by KUnit before every individual test case,
meaning wait_for_initramfs() will be called once for each of the test cases.

While functionally harmless since subsequent calls return instantly,
.suite_init is designed for one-time suite-level initialization and seems to
better match the intent.

>  	.test_cases = initramfs_test_cases,
>  };
>  kunit_test_init_section_suites(&initramfs_test_suite);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514050455.2954509-1-justin.he@arm.com?part=1