Re: [PATCH 1/3] rtla: Fix output files in source tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] `make clean` fails to remove the generated `$(OUTPUT)tests/bpf/bpf_action_map.o` file during out-of-tree builds.
--

commit ce6ce36bb0778cda3451364e21ac622e234e5df7
Author: Ben Hutchings <benh@debian.org>

rtla: Fix output files in source tree

This commit updates the rtla Makefile to place several generated BPF object
files and the skeleton header into the output directory to support fully
out-of-tree builds. It adds the $(OUTPUT) prefix to these files in the build
rules, tests, and the clean target.

> diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
> index 45690ee14544d..f54da7be735da 100644
> --- a/tools/tracing/rtla/Makefile
> +++ b/tools/tracing/rtla/Makefile
[ ... ]
> @@ -111,10 +118,10 @@ clean: doc_clean fixdep-clean
>  	$(Q)find . -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete
>  	$(Q)rm -f rtla rtla-static fixdep FEATURE-DUMP rtla-*
>  	$(Q)rm -rf feature
> -	$(Q)rm -f src/timerlat.bpf.o src/timerlat.skel.h example/timerlat_bpf_action.o
> +	$(Q)rm -f $(OUTPUT)src/timerlat.bpf.o $(OUTPUT)src/timerlat.skel.h $(OUTPUT)example/timerlat_bpf_action.o

[Severity: Low]
Does this leave $(OUTPUT)tests/bpf/bpf_action_map.o behind after a clean?

Previously, tests/bpf/bpf_action_map.o was cleaned up by the find command on
the first line of this target. Now that it is placed in the $(OUTPUT) directory,
the find command might not reach it during an out-of-tree build, and it does
not appear to be included in this explicit rm command either.

>  	$(Q)rm -f $(UNIT_TESTS)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/ag8X7gcDw6jpJsLq@decadent.org.uk?part=1