From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 987A52FE071 for ; Mon, 25 May 2026 23:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779753194; cv=none; b=a57aoDe/ApKZTG4mIZ6KQ3x01iszmUN8hVHekbBEQRrFpJ4YCHPTPz/e+JNBQmiJtxIk8sqPmc/VrGybms8IrdvWaTN+OERYfkN31EtB6AVPio7ETMNbjrMC3GOG0p1XQF8cdmCWJMjaeG8DlzDjV87Uy1bOXKJful2/glcBFD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779753194; c=relaxed/simple; bh=o+ketAn0H9LNHRu1TQELsO0gxay3H0Fb3BE1H6O7cFs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=i1gPZVZdpiMSBu/S1QMyjO6g4KbjLVxhXuWz0zK/PCyMUHs15YPbiamco7P/FzGwDJQTKm05UErC9gFz0KVp9rdSv6fJFMtluUP3xGAfy0MP6LUrB7eHZWQ0MsIPzEdHwxgUVKU24EVDZs/dolysuApQR+q/0RXPD5XAg5Kra8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AnYVc10q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AnYVc10q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 293611F000E9; Mon, 25 May 2026 23:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779753193; bh=Sfumms2vtHchQmP6YmMVLPAZARVqsm2GY9UzIJl+0tg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=AnYVc10q4z7tVROQlEN/gFgJ+ZzGIUWt0BshPZi22+K8g9q9iXwsO8pA23pJnqXaO NXGUdQ6KTs8o0PNxMj9bXJTg8UNNfLsrbq5PyataixI6Kn53hOZca0x3mMFvjDuKNv ad1nmsCV8lACNHfR/YjBQUqpIdGer1YH/26Uw6fGHYKAhEHfI8560/8y8clx2t2R2K xOeNBIyn34PHK+EUuqP72IklhsydczzexaKEh14Kc2IaaaglY70CSUSIfI+HomW4lm m34HCgYX8dG5p54RMc0TSVO7uTLeRj+2LamyvTufa82lzmFBWfKLlaqYl0aNu2KfxO EWHC4sDpa/Ufw== From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v2 14/14] perf stat: Extend PMU metrics value linter to validate --new outputs Reply-To: sashiko-reviews@lists.linux.dev To: "Ian Rogers" Cc: linux-perf-users@vger.kernel.org In-Reply-To: <20260525231900.3527228-15-irogers@google.com> References: <20260525231900.3527228-15-irogers@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 25 May 2026 23:53:12 +0000 Message-Id: <20260525235313.293611F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The New API validation run overwrites debug artifacts generated by = the legacy validation run. -- commit 40eff85b19a584a903ea2292617705adf84c2b46 Author: Ian Rogers perf stat: Extend PMU metrics value linter to validate --new outputs This patch updates the stat_metrics_values.sh test to run the validation linter a second time using the --new flag to ensure new Intel PMU metric outputs are validated. > diff --git a/tools/perf/tests/shell/stat_metrics_values.sh b/tools/perf/t= ests/shell/stat_metrics_values.sh > --- a/tools/perf/tests/shell/stat_metrics_values.sh > +++ b/tools/perf/tests/shell/stat_metrics_values.sh > @@ -22,9 +22,20 @@ for cputype in /sys/bus/event_source/devices/cpu_*; do > $PYTHON $pythonvalidator -rule $rulefile -output_dir $tmpdir -wl "${wor= kload}" \ > -cputype "${cputype}" > ret=3D$? > - rm -rf $tmpdir > if [ $ret -ne 0 ]; then > echo "Metric validation return with errors. Please check metrics repor= ted with errors." > + rm -rf $tmpdir > + exit $ret > + fi > + > + echo "Testing metrics for: $cputype (New API)" > + $PYTHON $pythonvalidator -rule $rulefile -output_dir $tmpdir -wl "${wor= kload}" \ > + -cputype "${cputype}" -new [Severity: Low] Does reusing the same $tmpdir here overwrite the debug artifacts from the legacy validation run? If a developer manually adds the -debug flag for troubleshooting, it appears the second python execution will silently overwrite the artifacts (such as perf_report.json and perf_data.json) generated by the first execution. Would writing to separate subdirectories help preserve both sets of debug artifacts? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260525231900.3527= 228-1-irogers@google.com?part=3D14